[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-09-29] [Wave 6: Tags] CRITICAL - Billable Toggle UI

[amyevans]

Reminder: only users in the beta will have the data

Design doc section

• https://docs.google.com/document/d/1eXGKhdUP98f6RUVYpRzxLi49El9Rizeqq-EYjrF24tU/edit#heading=h.646at3jzo9wo

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[amyevans]

Convenient auto-assignment 😄 (feel free to unassign if you don't want to be assigned though)

Callstack will be helping here!

[waterim]

Hello, Im Artem from Callstack, can I help with this one?

[puneetlath]

Thanks @waterim! Could you provide an ETA on when you think you'll be able to have a PR up?

Also, do you plan to tackle everything in one PR? Or break it up in some way?

[waterim]

Hello @puneetlath I think I will have enough capacity tomorrow and Friday to create a PR for this feature
I think 1 PR should be enough to handle a billable toggle

[puneetlath]

Ok sounds good. Looking forward to it!

[puneetlath]

hey @waterim just checking in on how this is going. Do you need any help?

[waterim]

Hey @puneetlath
Im sorry, but I had full capacity, need to finish 2 small things today and will fully dive into the billable toggle today evening and tomorrow, is it okay?😞

[puneetlath]

Ok sounds good!

[jeet-dhandha]

Just curious @amyevans can External member be assigned to this type of New Feature Requests ?

[waterim]

Hello @puneetlath, I have a question regarding this "policy.disabledFields.defaultBillable", from where I can get it? Because as I can see in Onyx data:

Policy doesn't have something like this at that moment on my side.
Do I need some beta or backend is not ready yet?

[amyevans]

@jeet-dhandha Not usually, but it isn't a hard and fast rule. Keep your eye out in the #expensify-open-source channel in Slack where internal engineers would likely recruit external help as needed (in addition to applying the External label on the issue).

@waterim, answered your question in Slack!

[waterim]

@puneetlath @amyevans PR is opened :)

[puneetlath]

@0xmiroslav think you'll have a chance to review today?

[0xmiros]

Oh, I didn't know that all feedback is addressed already. Reviewing now

[puneetlath]

Awesome, thanks!

[amyevans]

@waterim I realized #27172 did not include passing the billable param to CreateDistanceRequest.

What do you think about just including support for that in your PR for editing in #26793? Or would you prefer a separate PR here?

[waterim]

@amyevans I can add to the same PR, because thats bot a lot of changes and PR will not be huge

Sorry, I didn’t know that DistanceRequest requires billable as well(in documentation it was only for money request)

[amyevans]

Sounds good, and no worries!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Add Billable Toggle UI #27172

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

Looks like we just need to pay out @0xmiroslav for C+ on this.

@0xmiroslav should I send you an Upwork contract or will you track this separately for yourself?

[0xmiros]

I am tracking so let's close for now. Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: add jsDoc to billable #29327

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: add jsDoc to billable #29327

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty