[HOLD for payment 2023-10-09] [Wave 6: Tags] CRITICAL - Frontend: editing a tag and billable flag

[amyevans]

HELD on:

• [HOLD for payment 2023-10-02] [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI #26126
• [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-09-29] [Wave 6: Tags] CRITICAL - Billable Toggle UI #26128

Design doc section

• https://docs.google.com/document/d/1eXGKhdUP98f6RUVYpRzxLi49El9Rizeqq-EYjrF24tU/edit#heading=h.d4r80gwxgf3r

Implementation

• #26793: Edit a tag in a money request #27950
• Feat: Editable billable flag #27875
• #26793: show selected tag even if all are disabled #28151
• fix: allow creation of policyRecentlyUsedTags for policy if none exists #28493

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[amyevans]

Currently held but Callstack will help here when we're ready to move on it

[amyevans]

Not ready to be worked on yet

[waterim]

Hello, Im Artem from Callstack - expert group
And I would like to take this one

[waterim]

I have one question, do we want to have toggler in a new screen(MenuItemWithTopDescription) or as we have in create moneyRequest?

cc: @amyevans @puneetlath

[waterim]

Because from the Doc, we have described tags and billable together, but for creation we had another way of showing toggler, thats why I have this question

[puneetlath]

We want to leave it as it is in that image. No need for a new screen.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #26793: Edit a tag in a money request #27950
• Feat: Editable billable flag #27875
• #26793: show selected tag even if all are disabled #28151

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @jjcoffee requires payment
• @waterim does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[jjcoffee]

Just flagging that I've reviewed another linked PR.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: allow creation of policyRecentlyUsedTags for policy if none exists #28493

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @jjcoffee requires payment
• @waterim does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

Updated payment summary:
$500 - @parasharrajat - #28151 (to be paid via NewDot)
$500 - @jjcoffee - #27950 (paid via Upwork)
$500 - @jjcoffee - #28493 (paid via Upwork)

@parasharrajat can you open a request in NewDot and comment here when you have?
@jjcoffee I sent you another offer: https://www.upwork.com/nx/wm/offer/27101276

[jjcoffee]

@puneetlath Thanks, accepted!

[amyevans]

@parasharrajat can you open a request in NewDot and comment here when you have?

Friendly bump @parasharrajat 😄

[parasharrajat]

@amyevans I will request it later. Feel free to close this issue.

[parasharrajat]

Payment requested as per #26793 (comment)

[JmillsExpensify]

$500 payment approved for @parasharrajat based on summary.