#26793: show selected tag even if all are disabled #28151

BeeMargarida · 2023-09-25T14:41:03Z

Details

There was a wrong behaviour happening, this PR fixes it. Mentioned in https://callstack-hq.slack.com/archives/C02MW39LT9N/p1695649373962089?thread_ts=1695632734.639029&cid=C02MW39LT9N.

Expected behaviour:
When editing a money request with a previously selected tag, if all tags are disabled, it should show the previously selected tag in the picker and allow to de-select it.

Current behaviour (before this PR):
When editing a money request with a previously selected tag, if all tags are disabled, it showed an empty list, with no currently selected option.

Fixed Issues

$ #26793

Tests

Requires 3 things:

Have access to the newDotTags beta
Have a workspace with tags setup
Do the following setup in the collapsable below

Note: the edit tag behaviour is not yet supported in the backend, so the edit tag action won't be saved between reloads.

Mock disabled tags when editing a money request

Go to a workspace page
Copy the workspace/policyID in the URL
In EditRequestPage.js add the following code

    useEffect(() => {
        Onyx.set('policyTags_<POLICY_ID>', {
            Department: {
                name: 'Department',
                tags: {
                    Accounting: {
                        name: 'Accounting',
                        enabled: false,
                    },
                    Design: {
                        name: 'Design',
                        enabled: false,
                    },
                    Engineering: {
                        name: 'Engineering',
                        enabled: false,
                    },
                    HR: {
                        name: 'HR',
                        enabled: false,
                    },
                    Infra: {
                        name: 'Infra',
                        enabled: false,
                    },
                    Legal: {
                        name: 'Legal',
                        enabled: false,
                    },
                    Marketing: {
                        name: 'Marketing',
                        enabled: false,
                    },
                    Ops: {
                        name: 'Ops',
                        enabled: false,
                    },
                    Sales: {
                        name: 'Sales',
                        enabled: false,
                    },
                },
            },
        });
    }, []);

Make a money request with a tag or use a previously created one that contains a tag
Enter the money request report, to edit it
Click on the tag menu item
It should show the picker with only the currently selected tag (should appear selected)
Click on the selected tag
It should navigate back, de-select the tag and hide the tag menu item (since no tags are available)

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Make a money request with a tag or use a previously created one that contains a tag
Enter the money request report, to edit it
Click on the tag menu item
It should show the picker with only the currently selected tag (should appear selected)
Click on the selected tag
It should navigate back, de-select the tag and hide the tag menu item (since no tags are available)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

w_t.mp4

Mobile Web - Chrome

mc_t.mp4

Mobile Web - Safari

ms_t.mp4

Desktop

desk_t.mp4

iOS

ios_t.mp4

Android

android_t.mp4

…t it

melvin-bot · 2023-09-26T08:57:24Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-09-26T08:58:20Z

Reviewing it....

amyevans · 2023-09-26T13:35:22Z

Thanks for the fix @BeeMargarida! @parasharrajat please still review and complete the checklist

parasharrajat · 2023-09-26T18:28:53Z

Have access to the newDotTags beta
Have a workspace with tags setup
Do the following setup in the collapsable below

How can I get that? I force-enabled the beta from the permissions file but don't know how to do 2nd step.

amyevans · 2023-09-27T01:46:25Z

@parasharrajat Sorry, it's an either/or actually,

Either:

Have access to the newDotTags beta and 2. Have a workspace with tags setup

OR you can mock it with:

Do the following setup in the collapsable below

To set up a workspace with tags, you can:

Go to OldDot (expensify.com) and open or create a Control policy
In the JS console with the policy open do:
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();
Go to Policies > Tags and add tags to your policy
Go to Policies > People and invite a new user to the policy
Sign into that new user account in NewDot
Go through the request money flow and choose the policy that you just created
You now have a manual request on your Control workspace!

parasharrajat · 2023-09-27T09:22:18Z

Let me try. Thanks for the details.

parasharrajat · 2023-09-27T20:52:54Z

Resolved

So I noticed when we click the tag from the list, the tag section is removed from the request details view and it seems the tag is also removed as per the message.

but if I enable the tag back, the tag sections come back to view with the same tag value that we deselected. it does not look correct as we already removed it and a message has been shown to the user already. Now, there should be no tag.

@BeeMargarida

parasharrajat · 2023-09-27T20:56:36Z

My bad, I just noticed there is no API logic to reset the value so it is just a UI change. We are good here.

parasharrajat · 2023-09-27T21:08:52Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-09-28.at.2.48.56.AM.mov

🔲 iOS / Safari

Screen.Recording.2023-09-28.at.2.30.21.AM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-09-28.at.2.40.14.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-09-28.at.2.29.11.AM.mov

🔲 Android / Chrome

Screen.Recording.2023-09-28.at.2.30.49.AM.mov

🔲 Android / native

Screen.Recording.2023-09-28.at.2.53.38.AM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2023-09-28T02:22:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:17:06Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:21:02Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:49:37Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:50:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: show selected tag even if all are disabled, to allow to de-selec…

7cf7314

…t it

amyevans self-requested a review September 26, 2023 02:00

BeeMargarida marked this pull request as ready for review September 26, 2023 08:57

BeeMargarida requested a review from a team as a code owner September 26, 2023 08:57

melvin-bot bot requested review from parasharrajat and removed request for a team September 26, 2023 08:57

amyevans approved these changes Sep 26, 2023

View reviewed changes

parasharrajat approved these changes Sep 27, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans September 27, 2023 21:24

parasharrajat mentioned this pull request Sep 27, 2023

[HOLD for payment 2023-10-09] [Wave 6: Tags] CRITICAL - Frontend: editing a tag and billable flag #26793

Closed

4 tasks

amyevans approved these changes Sep 28, 2023

View reviewed changes

amyevans merged commit 87e6a80 into Expensify:main Sep 28, 2023
13 of 14 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

BeeMargarida mentioned this pull request Sep 29, 2023

fix: allow creation of policyRecentlyUsedTags for policy if none exists #28493

Merged

59 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

izarutskaya mentioned this pull request Oct 4, 2023

[$500] IOU - No "Recents" section in the tag selection menu #28804

Closed

6 tasks

rezkiy37 mentioned this pull request Oct 4, 2023

Allow Adding a category to a Split Bill #27936

Merged

59 tasks

eh2077 mentioned this pull request Nov 3, 2023

[HOLD for payment 2023-12-04] [$500] [Wave 6: Tags] In the Tag list, two tags are highlighted at the same time #30465

Closed

6 tasks

rayane-djouah mentioned this pull request Nov 9, 2023

Fix: Tags under "All" section displayed not in alphabetic order #31129

Merged

58 tasks

robertKozik mentioned this pull request Nov 20, 2023

fix: 30380 Tag - Unable to unselect tag from created expense when the tag is disabled #30672

Merged

58 tasks

luacmartins mentioned this pull request Nov 21, 2023

Fix tagList highlight #31652

Closed

47 tasks

c3024 mentioned this pull request Nov 27, 2023

[$500] Tag - Child tags are not indented on list #31753

Closed

6 tasks

c3024 mentioned this pull request Dec 5, 2023

[$500] [Wave 6: Tags] Expense - Selected subcategory shows different view in Tag & Category #32489

Closed

6 tasks

FitseTLT mentioned this pull request Mar 7, 2024

[CP staging] Fix - allow receipt split bill tag editing #37879

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#26793: show selected tag even if all are disabled #28151

#26793: show selected tag even if all are disabled #28151

BeeMargarida commented Sep 25, 2023

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

amyevans commented Sep 26, 2023

parasharrajat commented Sep 26, 2023 •

edited

Loading

amyevans commented Sep 27, 2023

parasharrajat commented Sep 27, 2023

parasharrajat commented Sep 27, 2023 •

edited

Loading

parasharrajat commented Sep 27, 2023 •

edited

Loading

parasharrajat commented Sep 27, 2023 •

edited

Loading

parasharrajat left a comment

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

#26793: show selected tag even if all are disabled #28151

#26793: show selected tag even if all are disabled #28151

Conversation

BeeMargarida commented Sep 25, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

amyevans commented Sep 26, 2023

parasharrajat commented Sep 26, 2023 • edited Loading

amyevans commented Sep 27, 2023

parasharrajat commented Sep 27, 2023

parasharrajat commented Sep 27, 2023 • edited Loading

parasharrajat commented Sep 27, 2023 • edited Loading

parasharrajat commented Sep 27, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

parasharrajat commented Sep 26, 2023 •

edited

Loading

parasharrajat commented Sep 27, 2023 •

edited

Loading

parasharrajat commented Sep 27, 2023 •

edited

Loading

parasharrajat commented Sep 27, 2023 •

edited

Loading