[$500] IOU - No "Recents" section in the tag selection menu

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #28493

Action Performed:

Prerequisites:
Have a workstation with tag setup - #28151 (comment)

Steps:

1. Open https://staging.new.expensify.com/
2. Sign in onto an account (log out and then sign in again just to clear Onyx)
3. Click on the FAB button
4. Click on 'Request Money'
5. Choose 'Manual' and add an amount
6. Click on the "Next" button
7. Select the configured WS
8. Click 'show more' and click on 'Category'
9. Select a category
10. Choose a tag
11. Save money request
12. Repeat steps 3-8

Expected Result:

When re-creating an IOU, the "Recents" section with the previously selected tags should be displayed.

Actual Result:

No "Recents" section in the tag selection menu when creating an IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224387_1696406694791.Recording__420.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017a1f123eb0bd3dbe
• Upwork Job ID: 1709535841184526336
• Last Price Increase: 2023-10-18

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017a1f123eb0bd3dbe

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[ayazalavi]

There is no tags option. How to enable it?

[abdel-h66]

From the code, the recent tags will only appear if there are more than 8 tags enabled

App/src/libs/OptionsListUtils.js

Lines 859 to 869 in 743a041

	if (numberOfTags < CONST.TAG_LIST_THRESHOLD) {
	tagSections.push({
	// "All" section when items amount less than the threshold
	title: '',
	shouldShow: false,
	indexOffset,
	data: getTagsOptions(enabledTags),
	});
	return tagSections;
	}

[abdel-h66]

To enable the tags @ayazalavi follow these steps

#28151 (comment)
And make sure you have the permissions to use tags

App/src/libs/Permissions.ts

Lines 4 to 6 in 743a041

	function canUseAllBetas(betas: Beta[]): boolean {
	return betas?.includes(CONST.BETAS.ALL);
	}

I personally just have

function canUseAllBetas(betas: Beta[]): boolean {
    return true;
}

[NicMendonca]

Waiting for proper proposals?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[NicMendonca]

@ayazalavi @abdel-h66 either of you interested in submitting proposals? 👀

[melvin-bot]

@NicMendonca, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

[NicMendonca]

@izarutskaya is this still reproducible?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@NicMendonca @robertKozik this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[robertKozik]

I think this can be the case @abdel-h66 described here. From the issue video we see that the user has only 4 tags - where we want at least 8 to include recents tags in the list

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue. I was one of who introduced categories and tags for the app.

[rezkiy37]

@izarutskaya, @NicMendonca, @mvtglobally. Guys, actually, there is not any bug here.
There are a few variants of the category/tag list:

1. When items less than 8, it is a simple list. The app does not have any special sorting or sections.
2. When items more or equal 8, it has a search bar and few sections: "Selected", "Recent" and "All". First 2 sections exist only when it has items, the last section exist always.
3. When user use the search bar, it is a simple list. Items amount does not matter.

Example

Small.list.mp4

I've added more tags, to have more than 8

Large.list.mp4

[abdel-h66]

Yes, it's the same conclusion as the above #28804 (comment)

[rezkiy37]

Yes, I just clarified the question. So, the issue can be closed, I think.

[melvin-bot]

@NicMendonca, @robertKozik Eep! 4 days overdue now. Issues have feelings too...