Deploy Checklist: New Expensify 2023-10-03

[OSBotify]

Release Version: 1.3.77-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Begin porting the web POC to react native #10
• fix(#22204): Toggle label correctly #24199
• Implement details page for expense/iouReport #24533
• Remove unused attachment placeholder code #25557
• fix undo message after delete #25583
• Save queued updates to memory only #25614
• Rewrite to functional component #26079
• Chore: migrate index.js class to function component #26374
• Fix: User experienced big delay when posting the messages #26729
• chore: migrate BaseInvertedFlatList.js to function component #26921
• [TS migration] Migrate 'compose.js' lib to TypeScript #26970
• Hoverable component refactored from class into functional approach #27223
• Highlight linked comment #27227
• [TS migration] Migrate 'LoginUtils.js' lib to TypeScript #27257
• [No QA] [TS Migration] Migrate 'openReportActionComposeViewWhenClosingMessageEdit' lib to TypeScript #27312
• fix: Web - Members page search bar does not get focused #27497
• [No QA][TS migration] Migrate 'AddLastVisibleActionCreated.js' lib to TypeScript #24857 #27539
• [No QA] [TS migration] Migrate 'Plaid.js' lib to TypeScript #27689
• Add margin between unread marker and the created action #27766
• Selection List refactor phase 3: base #27767
• [No QA][TS migration] Migrate 'UserUtils.js' lib to TypeScript #27778
• 26773-bug-user_is_able_to_delete_default_contact_method #27788
• Fix - User is hard to close a Phone account if it contains spaces #27818
• refactor: migrated ScreenWrapper o function component #27922
• [No QA] [TS migration] Migrate 'ApiUtils.js' lib to TypeScript #27935
• Display correct message when editing distance requests #27979
• Fix/27773: User still can remove invalid member #27991
• Update optimistic IDs in sequential queue #27996
• Rate unit page accessed from url #28004
• [No QA] [TS migration] Migrate 'TransactionUtils.js' lib to TypeScript #28005
• [TS migration] Migrate 'ComposerUtils' lib to TypeScript #28008
• [No QA][TS migration] Migrate 'DateUtils.js' lib to TypeScript #28009
• feat: address remaining design inconsistencies for distance requests #28110
• Remove focus on the main composer when closing the phone menu #28121
• Fix/27165: Only display recent destination if search input is empty #28124
• update get contract method from url when open deep link #28125
• Don't add optimistic replies to task assignee report #28128
• Limit decimals in select currencies in Money request form #28137
• Fix: email is not shown in authenticator app #28164
• Fix NotFound page for categories and tags #28165
• Update pending action when we cancel task #28211
• Fix Green drag and drop area #28219
• fix: 27862 Web - Deleting a manual request in the IOU room that still has a scan request redirects the user to the main chat #28247
• include task status messages in last message text #28248
• Allow anonymous user to copy url #28261
• fix: prevent requesting for amounts larger than the allowed maximum #28266
• Fix Task shared in admin-only room can be marked done in chat, but not in the task report  #28268
• fix: add proper fallback route for private notes pages #28273
• Split Bill - Number keeps on changing its initials #28274
• [HelpDot] Policy and domain settings fix subcategories #28275
• Create Indirect-Accounting-Integrations.md #28284
• Reattempt using OSBotify installation token in actions #28291
• Fix inconsistent spacing after typing an emoji #28297
• fix: Chat - Space is not added after an emoji is selecte #28302
• Update Vacation-Delegate.md #28303
• fix: The font for unread messages is not bolded in Android #28309
• Fix validation bug in FormProvider #28311
• Update Individual-Users.md #28351
• Add linking config for search #28360
• Fix/28007: City field is not clear when choosing new country #28362
• [CP Staging] fix crash on room name validation #28366
• Upgrade react-native-key-command version #28370
• Update Create-Expenses.md #28371
• Allow bubbling Enter key press event on Button #28374
• convert currency param from URL toUpperCase for case-insensitive comparison #28382
• Add images to ExpensifyHelp #28383
• Fix: Status emoji is overlap in report action item #28392
• rerender country and state if visited via deep link #28404
• Update User-Roles.md #28405
• fix: status bar color when modal is visible #28407
• Fix: Regression - Infinite loading in request money page #28410
• Update and rename Global-Reimbursement.md to International-Reimbursem… #28413
• Update and rename Account-Access.md to Account-Details.md #28415
• added coordinates in get bounds #28416
• Refocus when clicking on add split button #28423
• Update Scheduled-Submit.md #28428
• Update Global-VaTax.md #28430
• Add conditional wallet terms based on program ID #28433
• Update Auto-Reconciliation.md #28436
• Update Currency.md #28437
• [CP Staging] Fix race condition in onyx to stop app crashing when opening a new thread #28440
• Update Report-Fields-And-Titles.md #28446
• Update Gusto.md #28455
• Update Workday.md #28457
• [CP Staging] fix: regression 28417 #28458
• Update Zenefits.md #28460
• Fix: Private notes page shows not found in offline mode #28461
• [CP Staging] fix composer focus after deleting a message from edit mode #28462
• fix: allow creation of policyRecentlyUsedTags for policy if none exists #28493
• Update Expenses.md #28506
• [NoQA] Fix useFlipper warning #28507
• Fix expand button won't show if composer contains only new lines/spaces #28512
• [CP Staging] Fix notification navigation to report #28525
• [CP Staging] fix: use correct variables for navigateToNextPage fn #28527
• Fix readFileAsync to extract type also for file upload #28533
• Make the logic for money request options in composer quick actions more robust #28542
• Fix checkbox outline in TaskView #28543
• [HelpDot] Redirect old article links to new articles #28556
• [CP-Staging]:fix crash while opening emoji picker #28558
• prevent thread report crash for a member when workspace is deleted by owner #28559
• [CP Staging] prevent OpenReport api call with "null" report #28560
• Remove unnecessary StatusBar code #28571
• Fix/27362: Draft icon show even there is not anything #28574
• Update Default-Export-Templates.md #28577
• update 'chooseFile' translation in en.ts #28578
• Fix desktop green drag and drop area #28579
• [NoQA] Add small comment about REPORT_METADATA onyx key #28581
• Remove Mark as complete menu item from threeDotMenuItems for tasks #28582
• fix: Chat - App displays mention suggestion for sometime when we remove spaces before #28583
• [CP Staging] Fixes not found page not being shown properly when not having access to report #28584
• define and use canUseTouchScreen to get apply correct value for marginTop in Button #28595
• Fix LHN display name ellipsis doesn't show tooltip when the text is updated #28598
• fix: invalid amount error message displayed after clearing amount input #28607
• [CP Staging] Revert "Blur Magic Code input when click outside" #28611
• Revert "Reattempt using OSBotify installation token in actions" #28612
• [CP Staging] fix cursor moving to new line when tapped return #28613
• Fix console error on visiting /sign-in-with-google #28617
• Remove the close button from security page #28620
• [NoQA] From docs refactor #28627
• [HelpDot] Fix redirect on github pages #28637
• [No QA]Remove check to only look for blockers when run via workflow_call #28659
• [NoQA] Skip flaky google address tests #28661
• Fix: @__fake__ shows in task preview with no assignee #28684
• [No QA] Upgrade react-native-onyx to 1.0.98 #28725
• [CP Staging] Revert "Handle suggestions only on selection change" #28794
• [CP Staging] Fix: No notification when closing account #28800
• [CP Staging] fix: Distance - App crashes when tapping on the receipt thumbnail while receipt is generating #28852
• [CP Staging] fix persisted request #28857

Internal QA:

• Refactor/16232/migration enable payments page to function component #28236 - @barttom
• refactor: migrated IdologyQuestions to the function component #28123 - @barttom

Deploy Blockers:

• [HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748
• [Hold PR#26307] [$500] Android - Distance - Start and Finish points blink when navigate to Distance tab #28752
• [$500] Conversation - "Chat Skeleton" is blinking on Staging and Chat crashes on PROD site #28799
• [HOLD for payment 2024-01-24] [$250] Workspace members - Members deleted offline are not crossed out #28807
• [$500] Connect Bank account - Crash when completed adding BA manually #28811
• [HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$250] Distance - App crashes when tapping on the receipt thumbnail while receipt is generating #28814
• [$250] BA - Personal Information form isn't filled out with information that was added while offline #28818
• [HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$500] Contact Method - Reloading the page does not clear the error on Contact Methods #28825
• [$500] IOU - App redirects to same page after deleting Manual IOU and returning to previous page #28839

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.77-2 🚀

[kavimuru]

Checked off PRs from the past builds:
#24199 #28137 #28362 #28440
#25557 #28164 #28366 #28446
#25583 #28165 #28370 #28611
#25614 #28211 #28371 #28612
#26079 #28219 #28374 #28458
#26374 #28248 #28460 #28584
#26729 #28261 #28392 #28462
#26921 #28266 #28404 #28506
#28268 #28405 #28525 #28613
#27223 #28273 #28407 #28527
#27227 #28274 #28410 #28533
#27767 #28275 #28556 #28598
#27788 #28284 #28415 #28558
#28291 #28423 #28560
#28004 #28297 #28428 #28571
#28008 #28303 #28430
#28124 #28311 #28433 #28578
#28125 #28351 #28436 #28582
#28128 #28360 #28437 #28583

[mountiny]

@kavimuru #26921 was not released yet

[kavimuru]

@mountiny My bad, There was no QA steps, so checked it off. Not from past build.

[mountiny]

• Implement details page for expense/iouReport #24533
• chore: migrate BaseInvertedFlatList.js to function component #26921
• [TS migration] Migrate 'compose.js' lib to TypeScript #26970
• [TS migration] Migrate 'LoginUtils.js' lib to TypeScript #27257
• fix: Web - Members page search bar does not get focused #27497
• [No QA][TS migration] Migrate 'AddLastVisibleActionCreated.js' lib to TypeScript #24857 #27539
• [No QA] [TS migration] Migrate 'Plaid.js' lib to TypeScript #27689
• Add margin between unread marker and the created action #27766
• Fix - User is hard to close a Phone account if it contains spaces #27818
• refactor: migrated ScreenWrapper o function component #27922
• Display correct message when editing distance requests #27979
• Fix/27773: User still can remove invalid member #27991
• Update optimistic IDs in sequential queue #27996
• [No QA][TS migration] Migrate 'DateUtils.js' lib to TypeScript #28009
• feat: address remaining design inconsistencies for distance requests #28110
• Remove focus on the main composer when closing the phone menu #28121
• refactor: migrated IdologyQuestions to the function component #28123
• fix: 27862 Web - Deleting a manual request in the IOU room that still has a scan request redirects the user to the main chat #28247
• fix: Chat - Space is not added after an emoji is selecte #28302
• fix: The font for unread messages is not bolded in Android #28309
• convert currency param from URL toUpperCase for case-insensitive comparison #28382
• Add images to ExpensifyHelp #28383
• Update and rename Global-Reimbursement.md to International-Reimbursem… #28413
• added coordinates in get bounds #28416
• Update Gusto.md #28455
• Update Workday.md #28457
• Fix: Private notes page shows not found in offline mode #28461
• fix: allow creation of policyRecentlyUsedTags for policy if none exists #28493
• [NoQA] Fix useFlipper warning #28507
• Fix expand button won't show if composer contains only new lines/spaces #28512
• Make the logic for money request options in composer quick actions more robust #28542
• Fix checkbox outline in TaskView #28543
• prevent thread report crash for a member when workspace is deleted by owner #28559
• Fix/27362: Draft icon show even there is not anything #28574
• Update Default-Export-Templates.md #28577
• Fix desktop green drag and drop area #28579
• define and use canUseTouchScreen to get apply correct value for marginTop in Button #28595
• fix: invalid amount error message displayed after clearing amount input #28607
• Fix console error on visiting /sign-in-with-google #28617
• Remove the close button from security page #28620
• [HelpDot] Fix redirect on github pages #28637
• [CP Staging] Revert "Hoverable component refactored from class into functional approach" #28642
• Use Continue for button copy for camera permissions #28655
• [No QA]Remove check to only look for blockers when run via workflow_call #28659
• [NoQA] Skip flaky google address tests #28661
• [CP Staging] Revert "Fix: User experienced big delay when posting the messages" #28673
• Fix: @__fake__ shows in task preview with no assignee #28684
• [CP Staging] fix: pass decimals parameter to validateAmount in MoneyRequestConfirmationList #28685
• [CP Staging] Fix LoginList types #28686
• [CP Staging] fix null coallescing logic #28706

[kavimuru]

Regression TR is at 76% progress. We still have to validate few PRs.
#28121 failing with #26763 (not fixed in mweb and android) - Okay to check it off?

[tienifr]

FYI I have a proposal for this deploy blocker

I can quickly raise a PR for it if assigned.

[puneetlath]

Checking off #28752 as discussed in the issue.

[kavimuru]

@mountiny We are at 96% in Regression TR. Validating CPs and few iOS slots PR.
#28121 failing with #26763 (not fixed in mweb and android)
#28559 failing with #28336 (not fixed in desktop)
#28493 failing with #28804 repro in production (ok to check if off?)

[mountiny]

Demoted #28807 to normal bug

[mountiny]

Checking #28121, #28559 and #28493 off, not blcokers

[mountiny]

Checking #28123 off as the tests in the PR seem to be sufficient

[kavimuru]

#28542 failing with #28816
#27257 failing with #28805 reproduced in production (ok to check it off?)
#27818 failing with #27283 - repro in production (Ok to check it off?)
#28461 failing with #27591

[puneetlath]

Checking off #28818 as discussed in the issue.

[mvtglobally]

@mountiny Regression is completed

Current Open Blockers
#28799
#28811
#28814
#28839

Unchecked PRs
#28461 failing with #27591
#28542 failing with #28816

Checking off PROD repro issues
#27257 failing with #28805 reproduced in production. Checking off
#27818 failing with #27283 - repro in production. Checking off

[mountiny]

#28839 demoted

[mountiny]

Demoted #28799

[mountiny]

Girhub status, graphs and crashes looking good

[mountiny]

[mountiny]