[HOLD for payment 2023-10-12] [$500] Close account - Phone account cannot be closed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to NewDot with phone account
2. Go to Settings > Security > Close account
3. Try in input phone number in any possible format to "default contact method" field
4. Click close account

Expected Result:

Account should be closed

Actual Result:

Error message is displayed. Account is not closed. User is blocked from closing account
User can use any number entry option to log in but to close your account there is only one suggested on this page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.68-15

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6198017_video_29.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4a7e63cc4598b24
• Upwork Job ID: 1701734067417325568
• Last Price Increase: 2023-09-12
• Automatic offers:
• hoangzinh | Contributor | 26745151

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

I can reproduce this one. I even tried adding the @expensify.sms to see if that was the cause, and it didn't work either.

I5kRaKH8DM.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4a7e63cc4598b24

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @peterdbarkerUK (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Close account - Phone account cannot be closed

What is the root cause of that problem?

At the moment, The user needs to enter exactly the phone number including spaces between. According to the recording, there are spaces between in the phone number, but when he tried to close his account, he forgot to add them => Unable to close account because they're unmatched

App/src/pages/settings/Security/CloseAccountPage.js

Lines 66 to 72 in 85f950a

	const requiredFields = ['phoneOrEmail'];
	const userEmailOrPhone = props.formatPhoneNumber(props.session.email);
	const errors = ValidationUtils.getFieldRequiredErrors(values, requiredFields);
	if (values.phoneOrEmail && userEmailOrPhone.toLowerCase() !== values.phoneOrEmail.toLowerCase()) {
	errors.phoneOrEmail = 'closeAccountPage.enterYourDefaultContactMethod';
	}

What changes do you think we should make in order to solve the problem?

I think, in order to solve the issue, we can remove whitespaces before matching them in this line

App/src/pages/settings/Security/CloseAccountPage.js

Line 70 in 85f950a

if (values.phoneOrEmail && userEmailOrPhone.toLowerCase() !== values.phoneOrEmail.toLowerCase()) {

What alternative solutions did you explore? (Optional)

• If we would like user to enter exactly the phone number, we can update the error message to be more meaning. I.e "Please enter your default contact method to close your account (exactly contact method showed above, including spaces...)"
• Moreover, we can add a copy icon at the end of the contact method, it will help user easier to copy their contact method just in cases they need.

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[trjExpensify]

Wow, why does it need the space between 07814 266906? I think we should remove that. I also like the idea of the clipboard icon to make this easy.

[trjExpensify]

Waiting for proposals!

[robertKozik]

Hi @hoangzinh! I appreciate your proposal as it directly addresses the root cause. Both adding the copy button and trimming whitespaces are valid options. Personally, I lean towards the latter as the close account option should not be too easy to perform. Requiring the user to type out the contact method acts as an extra confirmation step. While I'm open to further discussion on this, for now, I'm inclined towards the current solution proposed by @hoangzinh.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hoangzinh]

@robertKozik @Gonals Thanks for accepting my proposal. The PR is ready here #27818. Please help me review it. Thanks

[hoangzinh]

cc @robertKozik to review PR #27818 when you get a chance. Thanks

[trjExpensify]

Where are we at here?

[robertKozik]

@trjExpensify I asked a quetion about the implementation. We are currently in review

[trjExpensify]

Excellent, thanks!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-09-19 03:24:38 Z
• when the PR got merged: 2023-10-03 13:56:10 UTC
• days elapsed: 10

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - User is hard to close a Phone account if it contains spaces #27818

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh / @robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh / @robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh / @robertKozik] Determine if we should create a regression test for this bug.
• [@hoangzinh / @robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @robertKozik] The PR that introduced the bug has been identified. Link to the PR: It was an edge-case which was not hovered (hovered differently) so no particular PR introduced it.
• [@hoangzinh / @robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@hoangzinh / @robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@hoangzinh / @robertKozik] Determine if we should create a regression test for this bug. It was an edge-case which was not hovered (hovered differently) so no particular PR introduced it.I don't think we need the regression tests for it
• [@hoangzinh / @robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[hoangzinh]

cc @trjExpensify for the payout.

[trjExpensify]

Strange, not sure how this one fell off my radar to settle up last week. My bad, thanks the bump!

I agree we don't need a regression test here because Applause caught it within their regression testing for closing accounts already. Proceeding with payments as follows:

$500 to @hoangzinh for the fix

No #urgency bonus to be applied as per here.

[trjExpensify]

Settled up, closing!