-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Bill - Number keeps on changing its initials #28274
Split Bill - Number keeps on changing its initials #28274
Conversation
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hello ) plus a little explanation Besides my bug, I found one Screen.Recording.2023-09-26.at.19.37.29.movThis is due to the fact that after clicking on the user, we first update the section state and call re-rendering and also update the usEffect dependencies inside this function Which also updates the section state I was looking for a reason why was added setNewChatOptions in the press function Or should I remove these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great to me, and thanks for fixing that additional bug. I agree there was no reason to run getFilteredOptions
twice.
@robertKozik please test soon and then I'll merge assuming it tests well. |
Will test it today 👀 |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeios.-.android.-.web.movMobile Web - Safariios.-.android.-.web.movDesktopdesktop.moviOSios.-.android.-.native.movAndroidios.-.android.-.native.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@neil-marcellini |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.77-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
Selected and unselected users are displayed differently on the split screen found by a phone number
Fixed Issues
$ #27557
PROPOSAL: #27557 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-09-26.at.19.25.33.mov
Mobile Web - Chrome
Screen.Recording.2023-09-26.at.19.29.10.mov
Mobile Web - Safari
Screen.Recording.2023-09-26.at.19.29.55.mov
Desktop
Screen.Recording.2023-09-26.at.19.32.18.mov
iOS
Screen.Recording.2023-09-26.at.19.33.25.mov
Android
Screen.Recording.2023-09-26.at.19.34.33.mov