[HOLD for payment 2024-01-24] [$250] Workspace members - Members deleted offline are not crossed out

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Login with account
3. Go to Settings -> Workspace -> Open any WS -> Invite several members
4. Turn off the internet connection
5. Delete WS member

Expected Result:

Members deleted offline crossed out

Actual Result:

Members deleted offline are not crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.77-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224496_1696416059346.Record_2023-10-03-23-20-42_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d912d0feb7321c7
• Upwork Job ID: 1709541114926034944
• Last Price Increase: 2023-10-18
• Automatic offers:
• hoangzinh | Reviewer | 27291935

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d912d0feb7321c7

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[izarutskaya]

Not repro on Prod

Screen_Recording_20231004_110047_New.Expensify.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

@mountiny I'm able to reproduce the issue in staging and production in IOS app.

RPReplay_Final1696423506.1.MP4

RPReplay_Final1696423327.1.MP4

Not able to reproduce on Android production build v1.3.69-2

Screen_Recording_20231004_210044_New.Expensify.1.mp4

Would you like us to keep the DB label or remove it?

[mountiny]

I cant repro in web

[mountiny]

Same for mweb

I am going to remove the blocker label, lets see if people can reliably reproduce this one

[melvin-bot]

Upwork job price has been updated to $250

[hoangzinh]

Screen.Recording.2023-10-07.at.10.05.40.mov

I can reproduce in the latest main in native apps. @mountiny I think we should bump the price as a normal bug to get more eyes on this issue.

[hoangzinh]

Ping @madmax330 on Slack https://expensify.slack.com/archives/C02NK2DQWUX/p1704235537820639

[madmax330]

This solution looks good to me: #28807 (comment)

[hoangzinh]

Hi @madmax330, because @keisyrzk took over this issue from @Swor71, could you help to assign him and unassign @Swor71 so he can start to work on the PR. Thanks

[madmax330]

Done

[keisyrzk]

@hoangzinh @madmax330
To conclude - is the solution (posted below as reminder) accepted so I could make a PR?

Changes in UserListItem as follows

(...)
import useStyleUtils from '@styles/useStyleUtils';

function UserListItem({item, textStyles, alternateTextStyles, showTooltip, style}) {
     const StyleUtils = useStyleUtils();
     (...)

     <Text
           style={StyleUtils.combineStyles(textStyles, style)}
           numberOfLines={1}
       >

      (...)

     <Text
          style={StyleUtils.combineStyles(alternateTextStyles, style)}
          numberOfLines={1}
      >
}

[hoangzinh]

Yes, it's. @keisyrzk

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace members - Members deleted offline are not crossed out #34093

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @keisyrzk does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

@hoangzinh I sent you a new offer, the previous one expired. Accept it when you can so I can pay promptly on the 24th!

[miljakljajic]

new offer to pay on 24: https://www.upwork.com/nx/wm/offer/100561859

[hoangzinh]

Regression Test Proposal

1. Sign in to any account
2. Create a workspace if the user doesn't have any workspace yet.
3. Go to Settings -> Workspace -> Open any workspace -> Invite a member
4. Turn off the internet connection
5. Remove a member in that workspace
6. Verify that the member being deleted in step (5) becomes crossed out.

Do we agree 👍 or 👎

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Selection List refactor phase 3: base #27767
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27767/files#r1462085599
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2024-01-24] [$250] Workspace members - Members deleted offline are not crossed out #28807 (comment)

[miljakljajic]

Paid and closing