Allow bubbling Enter key press event on Button #28374

parasharrajat · 2023-09-28T08:20:16Z

Details

Fixed Issues

$ #28022
PROPOSAL: #28022 (comment)

Tests

Test 1

Open the app.
Click on the FAB button > Request Money.
Select the Manual Tab.
Enter amount.
Press Enter on the keyboard.
Observe that the Form is moved to the next step.

Test 2

Open the app.
Click on the FAB button > Request Money.
Select the Distance Tab.
Enter start and finish waypoints. These should be correct values and the Next button should be enabled.
Press Enter on the keyboard.
Observe that the Form is moved to the next step.

Verify that no errors appear in the JS console

Offline tests

Run Test 1 from above.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-29.at.6.29.44.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-29.at.6.31.36.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-29.at.6.35.48.PM.mov

Desktop

Screen.Recording.2023-09-29.at.6.38.20.PM.mov

iOS

Screen.Recording.2023-09-29.at.6.36.47.PM.mov

Android

melvin-bot · 2023-09-28T08:28:39Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-09-28T08:29:09Z

I am seeing a full screen loader on Manual Tab on Desktop. Seems like a bug on main.

parasharrajat · 2023-09-28T10:04:05Z

The settlement button is not rendered on any screen. How can I test this? Also, can you please clarify what changes you are expecting on this?

eVoloshchak

The settlement button is not rendered on any screen

Apologies @parasharrajat, it should be ButtonWithDropdownMenu (though I suppose SettlementButton would need the same fix too)

Also, can you please clarify what changes you are expecting on this?

I expect to be able to submit the distance request by pressing enter (the last step, MoneyRequestConfirmPage)

Screen.Recording.2023-09-28.at.12.47.08.mov

…tton-bubble

parasharrajat · 2023-09-29T10:37:14Z

Question: Why press enter was disabled on the Confirm button? Did we face any issue earlier so we disabled it?

think we should also apply the same fix to MoneyRequestConfirmationList/SettlementButton, it's the last step of request money flow and it also cannot be submitted by pressing enter

I found out that simply passing pressonEnter prop was enough. Why did you think that same solution could be applied there? it will be great to know the context.

I'll leave the Settlement button for now as this page is disabled and has not updated for a long time. Though added it to ButtonWithDropdownMenu. Since so much has changed about requesting money, I think it is better to not touch it for now. Secondly, I won't have enough time to test it and follow up if you find any issues. I won't be available from tomorrow for a few days.

@eVoloshchak Can you please confirm these quickly so that I can wrap this up? Thanks. I won't be available from tomorrow for a few days.

#28374 (review)

eVoloshchak · 2023-09-29T11:35:00Z

Why press enter was disabled on the Confirm button? Did we face any issue earlier so we disabled it?

I went through the history of changes and it never had a pressOnEnter property. On one hand, this could be by design and we should leave it as it is since that's how it was always implemented, but on the other, I think it's inconsistent to be able to confirm the first two steps with Enter, but not the final one, so I lean towards the last option

I found out that simply passing pressonEnter prop was enough. Why did you think that same solution could be applied there?

By 'the same fix' I meant being able to confirm it with enter, not necessarily button with bubbling. If we can achieve the same result with only pressOnEnter property, that's even better

I'll leave the Settlement button for now as this page is disabled and has not updated for a long time. Though added it to ButtonWithDropdownMenu. Since so much has changed about requesting money, I think it is better to not touch it for now.

Yes, completely agree with this

cc: @parasharrajat

parasharrajat · 2023-09-29T13:11:07Z

@eVoloshchak Ready for review. I am facing Android build issues. I think I won't be able to add screenshots for it ATM.

eVoloshchak · 2023-09-30T10:57:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-30.at.12.33.14.mov

Mobile Web - Chrome

Screen.Recording.2023-09-30.at.13.16.41.mov

Mobile Web - Safari

Screen.Recording.2023-09-30.at.13.06.01.mov

Desktop

Screen.Recording.2023-09-30.at.13.11.33.mov

iOS

Screen.Recording.2023-09-30.at.13.03.27.mov

Android

Screen.Recording.2023-09-30.at.13.28.03.mov

eVoloshchak

LGTM

I'm getting mixed results on mobile, however

I can't connect a real external keyboard to the phone at the moment, so testing with hardware keyboard passthrough on emulators
I don't think we fully support keyboard navigation on mobile devices (please correct me if I'm wrong)

johnmlee101

Generally everything looks good 👍

OSBotify · 2023-10-02T12:59:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:45:37Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:46:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:10:51Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:17:41Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2023-10-30T07:52:50Z

We found out that this PR caused an unexpected bug #29051. When two pages the stacked on the web the focused navigation state of the hidden page switched to true immediately after pressing back while the single Enter key event was bubbling. Due to this, it triggers an event on two pages.

parasharrajat added 3 commits September 28, 2023 13:09

Allow bubbling Enter key press event on Button

1d43c02

Add story for bubbling effect

b93018d

Enable Enter key submission on page under tab selector

42c2dfb

parasharrajat marked this pull request as ready for review September 28, 2023 08:28

parasharrajat requested a review from a team as a code owner September 28, 2023 08:28

melvin-bot bot requested review from eVoloshchak and removed request for a team September 28, 2023 08:28

Prettier changes

1b9e5a9

eVoloshchak reviewed Sep 28, 2023

View reviewed changes

parasharrajat added 4 commits September 29, 2023 15:39

Merge branch 'main' of github.com:Expensify/App into parasharrajat/bu…

f1e3aff

…tton-bubble

PressonEnter for ButtonWithDropdownMenu

4c1af37

Fix: comment

56be20a

Allow Entry key submission on confirmation page.

c40cf89

Lint

2d89659

eVoloshchak approved these changes Sep 30, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 September 30, 2023 11:47

johnmlee101 approved these changes Oct 2, 2023

View reviewed changes

johnmlee101 merged commit 5ec89d4 into Expensify:main Oct 2, 2023
12 checks passed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

melvin-bot bot mentioned this pull request Oct 3, 2023

[HOLD for payment 2023-10-10] [$500] Request money flow is not proceeded to the next page #28022

Closed

6 tasks

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

Ollyws mentioned this pull request Oct 3, 2023

[HOLD for payment 2023-10-30] [$500] Log in - Keyboard is not consistent in safari and pressing enter does not submit a form #28569

Closed

6 tasks

Victor-Nyagudi mentioned this pull request Oct 10, 2023

[$250] Can't go back in "Contact methods" if triggering "Back" button using Enter #29132

Closed

6 tasks

bernhardoj mentioned this pull request Oct 14, 2023

[$500] Send money - Enter keypress on amount page triggers pay with expensify popup and displays in corner #29608

Closed

6 tasks

parasharrajat mentioned this pull request Oct 30, 2023

[HOLD for payment 2023-11-06][$500] Web - Split bill - Enter key in Edit amount page directly creates split bill #29051

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow bubbling Enter key press event on Button #28374

Allow bubbling Enter key press event on Button #28374

parasharrajat commented Sep 28, 2023 •

edited

Loading

melvin-bot bot commented Sep 28, 2023

parasharrajat commented Sep 28, 2023

parasharrajat commented Sep 28, 2023

eVoloshchak left a comment

parasharrajat commented Sep 29, 2023 •

edited

Loading

eVoloshchak commented Sep 29, 2023

parasharrajat commented Sep 29, 2023 •

edited

Loading

eVoloshchak commented Sep 30, 2023 •

edited

Loading

eVoloshchak left a comment

johnmlee101 left a comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

parasharrajat commented Oct 30, 2023

Allow bubbling Enter key press event on Button #28374

Allow bubbling Enter key press event on Button #28374

Conversation

parasharrajat commented Sep 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Test 1

Test 2

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 28, 2023

parasharrajat commented Sep 28, 2023

parasharrajat commented Sep 28, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

parasharrajat commented Sep 29, 2023 • edited Loading

eVoloshchak commented Sep 29, 2023

parasharrajat commented Sep 29, 2023 • edited Loading

eVoloshchak commented Sep 30, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

johnmlee101 left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

parasharrajat commented Oct 30, 2023

parasharrajat commented Sep 28, 2023 •

edited

Loading

parasharrajat commented Sep 29, 2023 •

edited

Loading

parasharrajat commented Sep 29, 2023 •

edited

Loading

eVoloshchak commented Sep 30, 2023 •

edited

Loading