[Hold PR#26307] [$500] Android - Distance - Start and Finish points blink when navigate to Distance tab

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to ND app
2. Tap on + button> Request money > Distance tab

Expected Result:

Distance tab should be displayed without any errors and blinking

Actual Result:

Start and Finish points blink for a second when User navigate to Distance tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6223888_1696362280194.az_recorder_20231003_135135.mp4

Bug6223888_1696362280175.az_recorder_20231003_134935.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b68d47c6a36a025
• Upwork Job ID: 1709317169412087808
• Last Price Increase: 2023-10-03

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b68d47c6a36a025

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[izarutskaya]

Not reproduced on Prod

Screen_Recording_20231004_024121_New.Expensify.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Start and Finish points blink when navigate to Distance tab

What is the root cause of that problem?

When we are opening the screen we have an empty list of waypoints

What changes do you think we should make in order to solve the problem?

We can update this line and add default waypoints without values

const waypoints = useMemo(() => lodashGet(transaction, 'comment.waypoints', {waypoint0: {}, waypoint1: {}}), [transaction]);

App/src/components/DistanceRequest.js

Line 98 in 81a6a52

const waypoints = useMemo(() => lodashGet(transaction, 'comment.waypoints', {}), [transaction]);

What alternative solutions did you explore? (Optional)

NA

[abdulrahuman5196]

Taking a look into this

[abdulrahuman5196]

Testing. Will update. Android taking lots of time to build 😮‍💨

[abdulrahuman5196]

@ZhenjaHorbach The suggested solution is working. Can you provide more information root cause?
I don't see any recent changes in the root cause code mentioned?

Is this regression from some PR? Or why is it happening ?

[abdulrahuman5196]

@ZhenjaHorbach Sorry, I tested again. And the solution is causing other issues like, If I click on finish before I enter a start point, its leading to NotFound page. And after inputting start, finish just disappears.

az_recorder_20231004_130326.mp4

[abdulrahuman5196]

@puneetlath We don't have any worthy fix proposals yet.

[situchan]

This will be fixed in #26307

[trjExpensify]

Oh hm, okay. In which case, we probably need to let this one go to prod because the other PR allegedly fixing it can’t be CP’d to staging now that it has merged, IIRC.

[puneetlath]

It can be CP'd to staging, not prod.

But I think this bug isn't one worth CP'ing that over. What do you think @mountiny? I'm thinking we just remove this as a deploy blocker, but leave it open to ensure that #26307 fixes it.

[trjExpensify]

It can be CP'd to staging, not prod.

Oh really, even after the PR has merged without adding the CP staging label already?

[puneetlath]

Yep! We got rid of the label and all CPs have to be triggered manually now.

[abdulrahuman5196]

No worthy proposals yet

cc: @trjExpensify

[trjExpensify]

Allegedly it's going to be fixed by #26307?

[abdulrahuman5196]

@trjExpensify thank you for that. Missed the message.
I think it could be. Can we put this issue on hold for that PR?

[trjExpensify]

Yup! It's on staging as well, I think. @izarutskaya Applause should be able to retest this one on an Android device now.

[melvin-bot]

@puneetlath, @trjExpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kbecciv]

Unable to reproduce it on build 1.3.83.10

Screen_Recording_20231013_113913_New.Expensify.mp4

[puneetlath]

Great, sounds like it was fixed!