Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-13] 🟡 Implement a DraggableList for waypoints #22716

Closed
neil-marcellini opened this issue Jul 11, 2023 · 32 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Jul 11, 2023

Please follow the plan in the design doc: Implement a DraggableList for waypoints.

Issue OwnerCurrent Issue Owner: @twisterdotcom
@hayata-suenaga hayata-suenaga self-assigned this Jul 26, 2023
@hayata-suenaga hayata-suenaga changed the title [HOLD 22703, Expensify 299222] Implement a DraggableList for waypoints [HOLD App 22703, Expensify 299222] Implement a DraggableList for waypoints Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 26, 2023
@hayata-suenaga hayata-suenaga changed the title [HOLD App 22703, Expensify 299222] Implement a DraggableList for waypoints [HOLD App 22703, Expensify 299229] Implement a DraggableList for waypoints Jul 26, 2023
@hayata-suenaga
Copy link
Contributor

not overdue just assigned myself

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 4, 2023
@hayata-suenaga
Copy link
Contributor

This is on hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@hayata-suenaga
Copy link
Contributor

This is on hold and has less priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@neil-marcellini neil-marcellini changed the title [HOLD App 22703, Expensify 299229] Implement a DraggableList for waypoints Implement a DraggableList for waypoints Aug 21, 2023
@neil-marcellini neil-marcellini added Daily KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

@hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor

the latest update here: Expensify/react-native-x-draggable-list#7 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@hayata-suenaga hayata-suenaga changed the title Implement a DraggableList for waypoints [HOLD SBE] Implement a DraggableList for waypoints Aug 31, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Oct 6, 2023
@melvin-bot melvin-bot bot changed the title 🟡 Implement a DraggableList for waypoints [HOLD for payment 2023-10-13] 🟡 Implement a DraggableList for waypoints Oct 6, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor

Payment summary.

@DylanDylann and @situchan reviewed this PR by a SWM engineer.

@laurenreidexpensify laurenreidexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot Oct 23, 2023
@twisterdotcom
Copy link
Contributor

twisterdotcom commented Oct 24, 2023

Apologies folks, who should I be paying here and how much? Is it $500 for @DylanDylann and @situchan?

@hayata-suenaga
Copy link
Contributor

@twisterdotcom both please. This was a big PR and needed several C+'s eyes

@DylanDylann
Copy link
Contributor

@twisterdotcom @hayata-suenaga It seems we have a mistake here, I didn't review this PR so I am not eligible for payment here 😄

@situchan
Copy link
Contributor

There was only 1 C+ review. Other than efforts, I think original base price (1k) applies here as PR was raised 3 hrs before announcement.

@twisterdotcom
Copy link
Contributor

Okay @hayata-suenaga so, $1k for @situchan and that's it?

@twisterdotcom
Copy link
Contributor

bump @hayata-suenaga.

@hayata-suenaga
Copy link
Contributor

@twisterdotcom yes $1k for @situchan please 🙇

@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@twisterdotcom
Copy link
Contributor

Paid $1000 to @situchan here: upwork.com/nx/wm/offer/27434574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants