Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD react-native-x-draggable-list #5] Implement draggable list #25740

Closed
hayata-suenaga opened this issue Aug 23, 2023 · 7 comments
Closed
Assignees
Labels
Daily KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


We’re going to create a draggable list component that is cross-platform in a new React Native library. The new library/component should support both mobile and web.

The new library has already been setup with the support for TypeScript. Please write the new library in TypeScript.

This component should essentially wrap react-native-draggable-flatlist (a React Native library) and react-beautiful-dnd (a React library) and to provide a consistent API.

The only features/APIs we need for the new component is the ability to take an array and display the list item for each item in the array. We also want to provide a call back? to make sure that the re-ordering behavior can be listened to.

This new library is used in the DistanceRequest component to replace this part.

@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 23, 2023
@hayata-suenaga hayata-suenaga self-assigned this Aug 23, 2023
@hayata-suenaga hayata-suenaga removed the Bug Something is broken. Auto assigns a BugZero manager. label Aug 23, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Aug 23, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Aug 23, 2023
@hayata-suenaga
Copy link
Contributor Author

removing the bug label and related melvin comments. This is a new feature and is not a bug.

@hayata-suenaga hayata-suenaga changed the title [react-native-x-draggable-list #5] Implement draggable list [HOLD react-native-x-draggable-list #5] Implement draggable list Aug 23, 2023
@hayata-suenaga hayata-suenaga added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 23, 2023
@pradeepmdk
Copy link
Contributor

@hayata-suenaga can I work on this

@kosmydel
Copy link
Contributor

Hey, I'm from Software Mansion, and I'm going to work on this.

@melvin-bot melvin-bot bot added Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 23, 2023
@hayata-suenaga
Copy link
Contributor Author

the PR is being worked on

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@stephanieelliott, @hayata-suenaga, @kosmydel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott
Copy link
Contributor

Hey @hayata-suenaga, is this still on hold in some capacity, or should we remove Hold from the title?

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@hayata-suenaga
Copy link
Contributor Author

ah sorry this issue is a dupe of this one

closing this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants