Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] BA - Personal Information form isn't filled out with information that was added while offline #28818

Closed
4 of 6 tasks
lanitochka17 opened this issue Oct 4, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 4, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-requisite: user must be logged in and start the process to add a bank account to workspace until the "Personal information" form

  1. Disable the internet connection
  2. Fill out all the fields in the form
  3. Refresh the page
  4. Enable internet connection
  5. Refresh the page

Expected Result:

Personal Information form should be filled out with information that was added while offline

Actual Result:

Personal Information form isn't filled out with information that was added while offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.77-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224637_1696426863802.bandicam_2023-10-03_17-30-50-334.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011b6caa1544280915
  • Upwork Job ID: 1709580621374832640
  • Last Price Increase: 2023-10-04
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 4, 2023
@melvin-bot melvin-bot bot changed the title BA - Personal Information form isn't filled out with information that was added while offline [$500] BA - Personal Information form isn't filled out with information that was added while offline Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011b6caa1544280915

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@mountiny mountiny changed the title [$500] BA - Personal Information form isn't filled out with information that was added while offline [$250] BA - Personal Information form isn't filled out with information that was added while offline Oct 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

Upwork job price has been updated to $250

@Ollyws
Copy link
Contributor

Ollyws commented Oct 4, 2023

I could reproduce this on staging but it seems to be fixed on the latest main. cc: @puneetlath

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Oct 4, 2023
@puneetlath
Copy link
Contributor

Ah great, thanks @Ollyws. Removing the deploy blocker label in that case. I think it's fine for us to just let what is on main reach production naturally. I'll leave this open so we can test it again after the next deploy.

@puneetlath puneetlath added Daily KSv2 and removed Hourly KSv2 labels Oct 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@Ollyws
Copy link
Contributor

Ollyws commented Oct 9, 2023

Can't reproduce on production, I think we're good to close.

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@puneetlath
Copy link
Contributor

Thanks for checking @Ollyws!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants