[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

izarutskaya · 2023-10-03T20:43:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the App
Login with any account
Go to Settings -> Security -> Close account
Enter your default contact method -> Close account -> Confirm

Expected Result:

The notification that account successfully closed appears

Actual Result:

There is no notification that account successfully closed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.77-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6223881_1696362104411.Record_2023-10-03-21-17-27_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01379be296b685c84c
Upwork Job ID: 1709308267924353024
Last Price Increase: 2023-10-03
Automatic offers:

abdulrahuman5196 | Reviewer | 27016138
tienifr | Contributor | 27016141

melvin-bot · 2023-10-03T20:43:45Z

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-03T20:43:45Z

Job added to Upwork: https://www.upwork.com/jobs/~01379be296b685c84c

melvin-bot · 2023-10-03T20:43:47Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-03T20:43:51Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

izarutskaya · 2023-10-03T20:44:31Z

Not repro in Prod

20231004_030840.mp4

OSBotify · 2023-10-03T20:51:55Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-03T20:51:57Z

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

tienifr · 2023-10-04T03:52:28Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no notification that account successfully closed

What is the root cause of that problem?

This comes from this PR

In here, we check if the key.startsWith to proceed with the middleware. However in the case of closingAccount, there's a {onyxMethod: 'clear'} update which doesn't have the key, causing that middleware to throw since we're accessing startsWith of undefined.

This leads to the SaveResponseInOnyx (which is a later middleware) not being triggered, so the close account message never shows since it's an Onyx key that's supposed to be updated via SaveResponseInOnyx.

This can be easily validated by adding catch here

.catch(error => console.log('error', error));

and go through the flow

What changes do you think we should make in order to solve the problem?

We should check the key exists before continuing in the HandleUnusedOptimisticID. If the key doesn't exist, the Onyx update is not relevant to that middleware so we can early return here

if (!key) {
    return;
}

What alternative solutions did you explore? (Optional)

I think we should also add catch and log the error in the middleware in the console (or Log.alert), to avoid silent error like in this case.

abdulrahuman5196 · 2023-10-04T05:22:04Z

Taking a look into this

abdulrahuman5196 · 2023-10-04T05:46:38Z

@tienifr 's proposal here #28748 (comment) looks good and works well.
We should add the suggested fix along with the catch mentioned to make sure we see errors in console.

🎀 👀 🎀
C+ Reviewed

cc: @puneetlath

melvin-bot · 2023-10-04T05:46:43Z

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot · 2023-10-04T10:57:52Z

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-04T10:57:56Z

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-13T21:55:29Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T21:55:33Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix #28748 and Remove catching error in SaveResponseInOnyx #29117

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T21:55:34Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:48:39Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix #28748 and Remove catching error in SaveResponseInOnyx #29117

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:48:42Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:11:21Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix #28748 and Remove catching error in SaveResponseInOnyx #29117

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:11:23Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:36:35Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix #28748 and Remove catching error in SaveResponseInOnyx #29117

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@abdulrahuman5196 requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:36:36Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mountiny · 2023-10-19T23:26:18Z

@tienifr @abdulrahuman5196 Can you please complete the checklist and leave a summary of what should be the payment here, thanks!

abdulrahuman5196 · 2023-10-23T18:36:24Z

The PR that introduced the bug has been identified. Link to the PR:

#27996

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/27996/files#r1369099302

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. We seem to have UTs for this.

stephanieelliott · 2023-10-25T22:56:13Z

Summarizing payment on this issue:

Issue reporter: N/A
Contributor: @tienifr $750, paid via Upwork
Contributor+: @abdulrahuman5196 $750, paid via Upwork

Upwork job is here, 50% bonus is included on final payout

izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 3, 2023

melvin-bot bot changed the title ~~Android - Close account - There is no notification that account successfully closed~~ [$500] Android - Close account - There is no notification that account successfully closed Oct 3, 2023

melvin-bot bot assigned puneetlath Oct 3, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 3, 2023

melvin-bot bot assigned abdulrahuman5196 Oct 3, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 3, 2023

OSBotify mentioned this issue Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

mountiny assigned mountiny and tienifr and unassigned puneetlath Oct 4, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 4, 2023

tienifr mentioned this issue Oct 4, 2023

[CP Staging] Fix: No notification when closing account #28800

Merged

57 tasks

melvin-bot bot added Daily KSv2 Weekly KSv2 and removed Daily KSv2 labels Oct 11, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

abdulrahuman5196 mentioned this issue Oct 23, 2023

Update optimistic IDs in sequential queue #27996

Merged

58 tasks

stephanieelliott closed this as completed Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

izarutskaya commented Oct 3, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

izarutskaya commented Oct 3, 2023

OSBotify commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

tienifr commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

mountiny commented Oct 19, 2023

abdulrahuman5196 commented Oct 23, 2023

stephanieelliott commented Oct 25, 2023

[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

Comments

izarutskaya commented Oct 3, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 3, 2023

izarutskaya commented Oct 3, 2023

OSBotify commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

tienifr commented Oct 4, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 4, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

mountiny commented Oct 19, 2023

abdulrahuman5196 commented Oct 23, 2023

stephanieelliott commented Oct 25, 2023

izarutskaya commented Oct 3, 2023 •

edited by melvin-bot bot

Loading

tienifr commented Oct 4, 2023 •

edited

Loading