Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268

hoangzinh · 2023-09-26T15:22:49Z

Details

Fixed Issues

Tests

Precondition: As user A, create a room with admin-only posting permission with User B and C. In that room, create a Task that assigned to user B

Login as user B
Go to room above
Verify that user B can press on the checkbox of updating Task status
Press on the task, to go to Task report details
Verify that user B can press on the checkbox of updating Task status
Sign out and sign as user C
Go to room above
Verify that user C can not press on the checkbox of updating Task status
Press on the task, to go to Task report details
Verify that user C can not press on the checkbox of updating Task status

Verify that no errors appear in the JS console

Offline tests

PR changes are not affected by network status

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-26.at.22.52.20.-.web.mp4

Mobile Web - Chrome

Screen.Recording.2023-09-26.at.23.13.57.-.android.chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-09-26.at.23.02.32.-.ios.safari.mp4

Desktop

Screen.Recording.2023-09-26.at.22.56.41.-.desktop.mp4

iOS

Screen.Recording.2023-09-26.at.23.01.31.-.ios.2.mp4

Screen.Recording.2023-09-26.at.23.00.03.-.ios.1.mp4

Android

Screen.Recording.2023-09-26.at.23.17.30.-.android.mp4

melvin-bot · 2023-09-26T16:22:17Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr

Mostly looks good, couples of comments left.

mollfpr · 2023-09-28T16:53:00Z

src/components/ReportActionItem/TaskPreview.js

@@ -51,6 +52,8 @@ const propTypes = {
    }),

    ...withLocalizePropTypes,
+
+    ...withCurrentUserPersonalDetailsPropTypes,


We also need to use withCurrentUserPersonalDetailsDefaultProps.

Updated in commit d2b8d08

mollfpr · 2023-09-28T16:53:41Z

src/components/ReportActionItem/TaskView.js

@@ -102,7 +101,7 @@ function TaskView(props) {
                                            containerBorderRadius={8}
                                            caretSize={16}
                                            accessibilityLabel={taskTitle || props.translate('task.task')}
-                                            disabled={isCanceled || !canModifyTask}
+                                            disabled={disableState}


I think it's more readable directly using Task.canModifyTask(props.report, props.currentUserPersonalDetails.accountID). Similar to what we did for other components.

Updated in commit 15a30eb. I think we should use the existing flag canModifyTask instead of recalling the function again.

mollfpr · 2023-09-29T16:02:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

28268.Web.-.A.mov

28268.Web.-.B.mov

Mobile Web - Chrome

28268.mWeb.Chrome.-.A.mp4

28268.mWeb.Chrome.-.B.mp4

Mobile Web - Safari

28268.mWeb.Safari.-.A.mp4

28268.mWeb.Safari.-.B.mp4

Desktop

28268.Desktop.-.A.mov

28268.Desktop.-.B.mov

iOS

28268.iOS.-.A.mp4

28268.iOS.-.B.mp4

Android

28268.Android.-.A.mp4

28268.Android.-.B.mp4

mollfpr

LGTM 👍

mollfpr · 2023-10-01T11:09:30Z

@hoangzinh There's a Jest unit test failed. I think you can just pull the main and retest it again.

hoangzinh · 2023-10-01T12:00:43Z

Thanks @mollfpr. I updated with latest main and all checks have passed 🚀

OSBotify · 2023-10-02T09:09:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:46:19Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:47:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:11:39Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:18:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Centralize disable updating task status checkboxes

4a17c1b

hoangzinh marked this pull request as ready for review September 26, 2023 16:22

hoangzinh requested a review from a team as a code owner September 26, 2023 16:22

melvin-bot bot requested review from mollfpr and removed request for a team September 26, 2023 16:22

hoangzinh mentioned this pull request Sep 26, 2023

[c+ checklist needs completion] [$500] Task - Task shared in admin-only room can be marked done in chat, but not in the task report #27402

Closed

6 tasks

mollfpr reviewed Sep 28, 2023

View reviewed changes

hoangzinh added 2 commits September 29, 2023 00:16

Add default props of current user personal details

d2b8d08

Use flag canModifyTask for more readable

15a30eb

mollfpr approved these changes Oct 1, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch October 1, 2023 01:38

hoangzinh added 2 commits October 1, 2023 18:17

Merge branch 'main' into df/27402

46d88bb

Empty-Commit

839e52b

nkuoch approved these changes Oct 2, 2023

View reviewed changes

nkuoch merged commit dee1632 into Expensify:main Oct 2, 2023

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268

Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268

hoangzinh commented Sep 26, 2023 •

edited

Loading

melvin-bot bot commented Sep 26, 2023

mollfpr left a comment

mollfpr Sep 28, 2023

hoangzinh Sep 28, 2023

mollfpr Sep 28, 2023

hoangzinh Sep 28, 2023

mollfpr commented Sep 29, 2023 •

edited

Loading

mollfpr left a comment

mollfpr commented Oct 1, 2023

hoangzinh commented Oct 1, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268

Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268

Conversation

hoangzinh commented Sep 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 26, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Sep 28, 2023

Choose a reason for hiding this comment

hoangzinh Sep 28, 2023

Choose a reason for hiding this comment

mollfpr Sep 28, 2023

Choose a reason for hiding this comment

hoangzinh Sep 28, 2023

Choose a reason for hiding this comment

mollfpr commented Sep 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr commented Oct 1, 2023

hoangzinh commented Oct 1, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

hoangzinh commented Sep 26, 2023 •

edited

Loading

mollfpr commented Sep 29, 2023 •

edited

Loading