[CP Staging] Fixes not found page not being shown properly when not having access to report #28584

ospfranco · 2023-10-02T07:45:18Z

Details

Attempts to fix the skeleton being shown instead of a not found page. I tried slowing the network and could not reproduce the issue either. @fedirjh and @b4s36t4 could you take a look at let me know if it fixes it.

Also partly tackles skeleton being shown instead of the you don't have access page. That one also suggests a change in the default value for isLoadingReportActions which might also help here? Not sure.

Fixed Issues

$ #28489
$ #28508
PROPOSAL:

Tests

Log in to User A's account.
Open User B's chat.
Navigate to the "Assign task" section.
Create a task by entering a title.
Open another browser and log in to User B's account.
Open User A's chat and open the task.

Open a URL with a non-existing ID: localhost:8082/r/12345. Not found view is shown properly.
Repeated the same with a slow 3g connection throttled via Chrome Network tab. Skeleton is shown while page is loading, then eventually not found page is shown.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-10-02T07:45:23Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-10-02T08:20:52Z

@ospfranco Could you please add tests steps 🙏🏼

ospfranco · 2023-10-02T08:26:29Z

I just did the original steps in #28489.

Open a URL with a non-existing ID: localhost:8082/r/12345. Not found view is shown properly.
Repeated the same with a slow 3g connection throttled via Chrome Network tab. Skeleton is shown while page is loading, then eventually not found page is shown.

I didn't quite get the comments from @b4s36t4 on the original issue, so not sure if this is really the use case it was being solved when switching threads.

dukenv0307 · 2023-10-02T08:29:42Z

Just add a note here that we should change the default value of isLoadingReportActions to true. This is important to resolve this issue.

App/src/pages/home/ReportScreen.js

Lines 107 to 109 in 52f0e3c

    
           reportMetadata: { 
        
               isLoadingReportActions: false, 
        
               isLoadingMoreReportActions: false,

ospfranco · 2023-10-02T08:31:41Z

Let's do it all in a single PR then.

ospfranco · 2023-10-02T08:36:44Z

Test steps for fixing #28508:

Log in to User A's account.
Open User B's chat.
Navigate to the "Assign task" section.
Create a task by entering a title.
Open another browser and log in to User B's account.
Open User A's chat and open the task.

fedirjh · 2023-10-02T08:48:30Z

I didn't quite get the comments from @b4s36t4 on the original issue, so not sure if this is really the use case it was being solved when switching threads.

I think the test case is :

Be on slow network
Join Thread
Leave Thread
Re-open the same thread and verify 'not found' is not displayed

fedirjh · 2023-10-02T09:03:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-10-02.at.09.19.29.mp4

Mobile Web - Chrome

CleanShot.2023-10-02.at.09.22.24.mp4

Mobile Web - Safari

CleanShot.2023-10-02.at.09.53.47.mp4

Desktop

CleanShot.2023-10-02.at.10.02.41.mp4

iOS

CleanShot.2023-10-02.at.09.48.55.mp4

Android

CleanShot.2023-10-02.at.09.40.15.mp4

fedirjh · 2023-10-02T10:04:45Z

Screenshots for #28584 (comment) :

Screenshots/Videos

Web

CleanShot.2023-10-02.at.10.38.09.mp4

Mobile Web - Chrome

CleanShot.2023-10-02.at.10.48.52.mp4

Mobile Web - Safari

CleanShot.2023-10-02.at.10.25.11.mp4

Desktop

CleanShot.2023-10-02.at.10.15.54.mp4

iOS

CleanShot.2023-10-02.at.10.22.02.mp4

Android

CleanShot.2023-10-02.at.11.03.49.mp4

fedirjh · 2023-10-02T10:05:39Z

@ospfranco Let's add the steps to 'QA Steps' section

fedirjh

@ospfranco Could you please update this check to check for reportActions emptiness : more context #28508 (comment)

if (report.reportID && report.reportID === getReportID(route) && !isLoadingInitialReportActions) {
    return;
}

ospfranco · 2023-10-02T11:22:38Z

@fedirjh done

src/pages/home/ReportScreen.js

Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>

mountiny

Thanks!

[CP Staging] Fixes not found page not being shown properly when not having access to report (cherry picked from commit fac61c8)

OSBotify · 2023-10-02T11:52:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T13:36:23Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.75-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-02T17:19:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:11:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:17:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fixes not found page not being shown properly

a6996da

ospfranco requested a review from a team as a code owner October 2, 2023 07:45

melvin-bot bot requested review from rushatgabhane and removed request for a team October 2, 2023 07:45

ospfranco changed the title ~~Fixes not found page not being shown properly~~ Fixes not found page not being shown properly when not having access to report Oct 2, 2023

mountiny assigned ospfranco Oct 2, 2023

mountiny requested review from fedirjh and removed request for rushatgabhane October 2, 2023 08:12

mountiny changed the title ~~Fixes not found page not being shown properly when not having access to report~~ [CP Staging] Fixes not found page not being shown properly when not having access to report Oct 2, 2023

mountiny self-requested a review October 2, 2023 08:14

Change initial value for ReportScreen metadata->isLoadingReportActions

8b4e9ae

Merge branch 'main' into osp/fix-not-found-page

a846928

fedirjh reviewed Oct 2, 2023

View reviewed changes

Update check for calling openReport

a18d2fc

fedirjh reviewed Oct 2, 2023

View reviewed changes

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

ospfranco and others added 2 commits October 2, 2023 13:27

Update src/pages/home/ReportScreen.js

ee43f7e

Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>

Update src/pages/home/ReportScreen.js

e841dd0

Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>

fedirjh approved these changes Oct 2, 2023

View reviewed changes

mountiny approved these changes Oct 2, 2023

View reviewed changes

mountiny merged commit fac61c8 into Expensify:main Oct 2, 2023
14 checks passed

OSBotify pushed a commit that referenced this pull request Oct 2, 2023

Merge pull request #28584 from margelo/osp/fix-not-found-page

f6c11e0

[CP Staging] Fixes not found page not being shown properly when not having access to report (cherry picked from commit fac61c8)

ospfranco deleted the osp/fix-not-found-page branch October 2, 2023 11:54

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

ospfranco mentioned this pull request Oct 4, 2023

Fix concurrent writes in the update operation Expensify/react-native-onyx#384

Merged

tienifr mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-12-15] [$500]Thread - Undefined displayed in header offline when opening left thread #28997

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fixes not found page not being shown properly when not having access to report #28584

[CP Staging] Fixes not found page not being shown properly when not having access to report #28584

ospfranco commented Oct 2, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Oct 2, 2023

fedirjh commented Oct 2, 2023

ospfranco commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

ospfranco commented Oct 2, 2023

ospfranco commented Oct 2, 2023

fedirjh commented Oct 2, 2023

fedirjh commented Oct 2, 2023

fedirjh commented Oct 2, 2023

fedirjh commented Oct 2, 2023

fedirjh left a comment •

edited

Loading

ospfranco commented Oct 2, 2023

mountiny left a comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

[CP Staging] Fixes not found page not being shown properly when not having access to report #28584

[CP Staging] Fixes not found page not being shown properly when not having access to report #28584

Conversation

ospfranco commented Oct 2, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 2, 2023

fedirjh commented Oct 2, 2023

ospfranco commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

ospfranco commented Oct 2, 2023

ospfranco commented Oct 2, 2023

fedirjh commented Oct 2, 2023

fedirjh commented Oct 2, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh commented Oct 2, 2023

Screenshots/Videos

fedirjh commented Oct 2, 2023

fedirjh left a comment • edited Loading

Choose a reason for hiding this comment

ospfranco commented Oct 2, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

ospfranco commented Oct 2, 2023 •

edited by mountiny

Loading

fedirjh left a comment •

edited

Loading