fix(#22204): Toggle label correctly #24199

hannojg · 2023-08-07T06:35:50Z

Details

A recent change to our input component introduced a bug where the label of the input wouldn't activate under some circumstances. This PR fixes this issue.

Fixed Issues

$ #22204
PROPOSAL: #22204 (comment)

Tests

On home screen, press the FAB and choose "Assign task"
Enter a title and a description
On the overview screen click on the description
Remove the description
Click next
You are on the overview screen again, now press the back button
You should be on the first screen for creating the task again, the description field should be empty and the input label should look correctly
Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Same as testing

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-07.at.08.30.34.mov

Mobile Web - Chrome

Screen.Recording.2023-08-07.at.08.43.04.mov

Mobile Web - Safari

mWeb-Safari.mp4

Desktop

Screen.Recording.2023-08-07.at.08.40.49.mov

iOS

ios.mp4

Android

melvin-bot · 2023-08-07T06:35:54Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-08-07T06:36:01Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-08-13T17:23:39Z

Reviewing now

abdulrahuman5196

@hannojg I checked and the code is fixing the current issue. Will do couple more testing to see if it causes any regression. Meanwhile could you check on the minor comments posted.

abdulrahuman5196 · 2023-08-13T17:40:47Z

src/components/TextInput/BaseTextInput.js

-            activateLabel();
-        } else if (!hasValueRef.current && !isFocused) {
-            deactivateLabel();
+        if (props.value === undefined || props.value > 0) {


We can use underscore functions to combine both check into one

@hannojg Can you kindly check on this minor comment?

abdulrahuman5196 · 2023-08-13T17:44:49Z

src/components/TextInput/BaseTextInput.js

-        }
+    // The ref is needed when the component is uncontrolled and we don't have a value prop
+    const hasValueRef = useRef(initialValue.length > 0);
+    const inputValue = props.value || '';


what is the difference between initialValue and inputValue and their purpose? Unable to understand clearly.

initialValue is the value that we have when the component got created for the first time.
inputValue is the value prop but with the fallback to an empty string (instead of undefined)

Montchy · 2023-08-16T09:04:15Z

I tested it and found no errors. Lgtm :)

abdulrahuman5196 · 2023-08-21T11:41:56Z

Hi @hannojg Can you check on the minor comment above and fix merge conflicts?
I tested on web and it seems to be working fine. Once the above is done, I can test on all platforms

hannojg · 2023-08-23T13:10:08Z

@abdulrahuman5196 all updated 😊

hannojg · 2023-08-23T13:18:10Z

Ah whoops, please hold on, the last commit implements a wrong logic

hannojg · 2023-08-24T09:32:24Z

@abdulrahuman5196 okay please check again now!

Note: I don't see how the if statement could be composed into one

abdulrahuman5196 · 2023-09-11T18:37:49Z

@hannojg Sorry for my delay here.

Meanwhile we also had merge freeze so paused sometime on PR since anyways we would end up doing a re-test after merge freeze.

Could you kindly do a merge from main as suggested here https://expensify.slack.com/archives/C01GTK53T8Q/p1694405959277169 and resolve conflicts as well?

abdulrahuman5196 · 2023-09-15T16:20:43Z

Gentle ping @hannojg

abdulrahuman5196 · 2023-09-27T05:11:05Z

@hannojg Gentle bump

…esc-stays-on-top

hannojg · 2023-09-27T05:55:22Z

@abdulrahuman5196 Resolved the conflicts, can you please test again? Thank you

abdulrahuman5196 · 2023-09-27T09:21:34Z

Reviewing now

abdulrahuman5196 · 2023-09-27T10:03:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-27.at.3.01.53.PM.mp4

Mobile Web - Chrome

az_recorder_20230927_151149.mp4

Mobile Web - Safari

Screen.Recording.2023-09-27.at.3.05.41.PM.mp4

Desktop

Screen.Recording.2023-09-27.at.3.24.30.PM.mp4

iOS

Screen.Recording.2023-09-27.at.3.16.25.PM.mp4

Android

Screen.Recording.2023-09-27.at.3.17.27.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @hayata-suenaga

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2023-09-27T10:13:17Z

@hannojg Unit tests are failing in main. https://expensify.slack.com/archives/C01GTK53T8Q/p1695796810686659

Kindly merge from main a little while after and we should be good to merge this PR

…/22204-task-desc-stays-on-top

hannojg · 2023-09-28T05:58:04Z

@abdulrahuman5196 updated again with main, I think we are good now?

abdulrahuman5196 · 2023-09-28T06:24:16Z

@hannojg Another Unit test is failing. I don't think its related to this PR as well 😢

hayata-suenaga · 2023-09-28T07:07:07Z

please merge main. that should fix the test failures

abdulrahuman5196 · 2023-09-30T05:48:07Z

ping @hannojg

…b.com:margelo/expensify-app-fork into fix/22204-task-desc-stays-on-top

hannojg · 2023-09-30T08:13:08Z

@abdulrahuman5196 Updated!

abdulrahuman5196 · 2023-09-30T09:29:15Z

All checks are now passing @hayata-suenaga

OSBotify · 2023-09-30T17:17:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:47:13Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:48:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:12:45Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:19:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Toggle label correcty

4b6941f

hannojg marked this pull request as ready for review August 7, 2023 06:35

hannojg requested a review from a team as a code owner August 7, 2023 06:35

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team August 7, 2023 06:35

hannojg mentioned this pull request Aug 7, 2023

[HOLD for payment 2023-10-10] [$1000] Task description label stays on top #22204

Closed

6 tasks

abdulrahuman5196 reviewed Aug 13, 2023

View reviewed changes

hannojg added 3 commits August 23, 2023 14:51

Merge branch 'main' into fix/22204-task-desc-stays-on-top

b3fa53b

reapply changes

c2d3126

use isEmpty

620831f

fix

eb3796d

bernhardoj mentioned this pull request Aug 25, 2023

Workspaces - 'Find a member' text doesn't move back as a placeholder #25938

Closed

6 tasks

hannojg added 2 commits September 27, 2023 07:53

Merge branch 'main' of github.com:Expensify/App into fix/22204-task-d…

ab48f3f

…esc-stays-on-top

add comment back

5da55f7

abdulrahuman5196 approved these changes Sep 27, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga September 27, 2023 10:12

Merge branch 'main' of github.com:margelo/expensify-app-fork into fix…

5aaccfb

…/22204-task-desc-stays-on-top

Merge branches 'fix/22204-task-desc-stays-on-top' and 'main' of githu…

052f23d

…b.com:margelo/expensify-app-fork into fix/22204-task-desc-stays-on-top

hayata-suenaga approved these changes Sep 30, 2023

View reviewed changes

hayata-suenaga merged commit 7c86d09 into Expensify:main Sep 30, 2023
14 checks passed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(#22204): Toggle label correctly #24199

fix(#22204): Toggle label correctly #24199

hannojg commented Aug 7, 2023 •

edited

Loading

melvin-bot bot commented Aug 7, 2023

melvin-bot bot commented Aug 7, 2023

abdulrahuman5196 commented Aug 13, 2023

abdulrahuman5196 left a comment

abdulrahuman5196 Aug 13, 2023

abdulrahuman5196 Aug 21, 2023

abdulrahuman5196 Aug 13, 2023

hannojg Aug 14, 2023

Montchy commented Aug 16, 2023

abdulrahuman5196 commented Aug 21, 2023

hannojg commented Aug 23, 2023

hannojg commented Aug 23, 2023

hannojg commented Aug 24, 2023

abdulrahuman5196 commented Sep 11, 2023

abdulrahuman5196 commented Sep 15, 2023

abdulrahuman5196 commented Sep 27, 2023

hannojg commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023 •

edited

Loading

abdulrahuman5196 left a comment

abdulrahuman5196 commented Sep 27, 2023

hannojg commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

hayata-suenaga commented Sep 28, 2023 •

edited

Loading

abdulrahuman5196 commented Sep 30, 2023

hannojg commented Sep 30, 2023

abdulrahuman5196 commented Sep 30, 2023

OSBotify commented Sep 30, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

fix(#22204): Toggle label correctly #24199

fix(#22204): Toggle label correctly #24199

Conversation

hannojg commented Aug 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 7, 2023

melvin-bot bot commented Aug 7, 2023

abdulrahuman5196 commented Aug 13, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 Aug 13, 2023

Choose a reason for hiding this comment

abdulrahuman5196 Aug 21, 2023

Choose a reason for hiding this comment

abdulrahuman5196 Aug 13, 2023

Choose a reason for hiding this comment

hannojg Aug 14, 2023

Choose a reason for hiding this comment

Montchy commented Aug 16, 2023

abdulrahuman5196 commented Aug 21, 2023

hannojg commented Aug 23, 2023

hannojg commented Aug 23, 2023

hannojg commented Aug 24, 2023

abdulrahuman5196 commented Sep 11, 2023

abdulrahuman5196 commented Sep 15, 2023

abdulrahuman5196 commented Sep 27, 2023

hannojg commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023

abdulrahuman5196 commented Sep 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Sep 27, 2023

hannojg commented Sep 28, 2023

abdulrahuman5196 commented Sep 28, 2023

hayata-suenaga commented Sep 28, 2023 • edited Loading

abdulrahuman5196 commented Sep 30, 2023

hannojg commented Sep 30, 2023

abdulrahuman5196 commented Sep 30, 2023

OSBotify commented Sep 30, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

hannojg commented Aug 7, 2023 •

edited

Loading

abdulrahuman5196 commented Sep 27, 2023 •

edited

Loading

hayata-suenaga commented Sep 28, 2023 •

edited

Loading