[No QA]Remove check to only look for blockers when run via workflow_call

[AndrewGable]

Details

This check does not seem to be working (github.event_name appears to not work for workflow_call) and we should check for blockers on both workflow_call and workflow_dispatch cases.

Fixed Issues

$ #27919 (comment)

Tests

• Merge this PR
• Verify that the Check if test failed, if so post the results and add the DeployBlocker label step is run

Offline tests

N/A

QA Steps

• N/A

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A - Fixing tests

Mobile Web - Chrome

N/A - Fixing tests

Mobile Web - Safari

N/A - Fixing tests

Desktop

N/A - Fixing tests

iOS

N/A - Fixing tests

Android

N/A - Fixing tests

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1164.751 ms → 1256.934 ms (+92.183 ms, +7.9%) 🔴
App start runJsBundle	802.419 ms → 878.344 ms (+75.924 ms, +9.5%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1164.751 ms Stdev: 32.479 ms (2.8%) Runs: 1103.4089040001854 1108.7609249996021 1108.8377790004015 1118.5717129996046 1128.122402000241 1128.980406000279 1138.5114519996569 1141.8788599995896 1145.5116379996762 1149.5668700002134 1153.6619859999046 1156.1260949997231 1158.2988839996979 1161.050691000186 1163.9988829996437 1165.4676149999723 1169.3309159995988 1172.1492630001158 1172.3446180000901 1173.8765700003132 1174.2750580003485 1183.3562700003386 1184.5232640001923 1188.9496879996732 1189.096234999597 1198.9764489997178 1205.4714620001614 1206.1846709996462 1213.9055709997192 1214.7294770004228 1229.360077000223 Current Mean: 1256.934 ms Stdev: 49.245 ms (3.9%) Runs: 1141.566924000159 1166.739330000244 1190.315713999793 1194.3819099999964 1202.5485990000889 1212.4842370003462 1214.9796350002289 1218.4479639995843 1227.4338980000466 1233.9272429998964 1240.2909040004015 1240.9842290002853 1242.1714000003412 1243.5792060000822 1245.5338460002095 1252.5099700000137 1252.8547310000286 1260.7193649997935 1266.0252240002155 1272.6879909997806 1275.6990949995816 1283.4366480000317 1283.7300969995558 1292.79195600003 1295.4621440004557 1311.6308660004288 1315.7594809997827 1322.6705609997734 1324.3469949997962 1330.437347999774 1332.5465169996023 1333.1836029998958
App start runJsBundle	Baseline Mean: 802.419 ms Stdev: 23.755 ms (3.0%) Runs: 748 762 770 773 779 781 782 788 788 792 793 795 797 798 798 801 803 805 806 809 814 814 819 820 822 823 827 834 835 849 850 Current Mean: 878.344 ms Stdev: 39.523 ms (4.5%) Runs: 804 819 828 830 839 848 852 853 854 858 861 861 865 866 867 867 871 872 878 881 885 887 891 894 911 916 920 921 921 953 955 979

Meaningless Changes To Duration

Show entries

Name	Duration
App start nativeLaunch	19.200 ms → 19.581 ms (+0.381 ms, +2.0%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +7.3%)
Open Search Page TTI	622.181 ms → 621.995 ms (-0.186 ms, ±0.0%)

Show details

Name	Duration
App start nativeLaunch	Baseline Mean: 19.200 ms Stdev: 1.400 ms (7.3%) Runs: 17 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 21 22 22 23 Current Mean: 19.581 ms Stdev: 1.498 ms (7.6%) Runs: 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 20 20 21 21 21 21 21 22 22 23 23
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (5.2%) Runs: 0.013061000034213066 0.013184000737965107 0.013345999643206596 0.013427999801933765 0.0134680001065135 0.013630999252200127 0.013631000183522701 0.013631000183522701 0.013671999797224998 0.013671999797224998 0.013753000646829605 0.013794000260531902 0.013834000565111637 0.0139979999512434 0.0139979999512434 0.01403799932450056 0.014119000174105167 0.014241999946534634 0.0143630001693964 0.014566999860107899 0.014688999392092228 0.014728999696671963 0.0147299999371171 0.0147299999371171 0.014891999773681164 0.015015000477433205 0.015219000168144703 0.015258999541401863 0.015381000004708767 0.015461999922990799 0.015544000081717968 0.015625 Current Mean: 0.015 ms Stdev: 0.001 ms (6.0%) Runs: 0.014159999787807465 0.014282000251114368 0.014363999478518963 0.014444999396800995 0.014485000632703304 0.014485999941825867 0.014566999860107899 0.014607999473810196 0.014688999392092228 0.01476999931037426 0.014810999855399132 0.014812000095844269 0.014812000095844269 0.014891999773681164 0.014891999773681164 0.014932999387383461 0.014973999932408333 0.014973999932408333 0.015015000477433205 0.015177999623119831 0.015381000004708767 0.015544000081717968 0.016153999604284763 0.01639800053089857 0.016439000144600868 0.016439000144600868 0.016520999372005463 0.01680499967187643 0.016885999590158463 0.0170889999717474 0.017129999585449696
Open Search Page TTI	Baseline Mean: 622.181 ms Stdev: 18.123 ms (2.9%) Runs: 597.5372310001403 598.9165439996868 599.788045999594 600.9276940003037 601.8415120001882 604.135498999618 605.2139490004629 606.4794919993728 608.2708740001544 609.9359940001741 611.3146970001981 612.8577070003375 614.1892099995166 615.4348550001159 617.4495849991217 618.5092370007187 621.0021569998935 622.5367839997634 623.0648600002751 624.6437590001151 626.394164999947 629.0054120002314 630.3154699997976 630.8847260000184 634.8850910002366 635.9196370001882 636.0306810000911 639.7247319994494 646.3371990006417 658.7156990002841 663.2228600000963 664.2940270006657 Current Mean: 621.995 ms Stdev: 15.770 ms (2.5%) Runs: 597.578451000154 603.956910001114 604.2958170007914 605.3516850005835 606.0354820005596 607.9895019996911 612.1866460014135 614.5983890015632 615.5782479997724 615.9320480003953 616.1485599996522 616.2843430005014 616.9135749991983 619.1860760003328 619.218547001481 620.1693529998884 620.2462980002165 620.3978679999709 620.503539999947 621.991007999517 623.8894859999418 624.0432540010661 624.6357020009309 624.7562259994447 631.1473390003666 639.437947999686 640.9048669990152 646.7587080001831 657.9712320007384 671.7374270008877

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[AndrewGable]

Ran it here and it works.. But it's already failing the performance part compared to our previous release 😭

https://github.com/Expensify/App/actions/runs/6385892599/job/17332602006

[mountiny]

Not sure how to treat this PR? I dont think this is a real blocker right now, we need to run these tests on specific PRs because from this I have no clue what could be the offending change or how to find it

[mountiny]

Removing the label discussed here

Going to deploy this now and we will see now the E2E to run on PRs merged to main

[mountiny]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅