[HOLD for payment 2023-10-18] [$500] Log in - Can't login with google button when open 2 tabs

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go go Login expensify screen
2. Copy URL on browser
3. Open a new tab and paste the copied URL -> Enter
4. Click Google button -> select account and login

Expected Result:

Can login to main space of Expensify

Actual Result:

The page hangs, can't login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Hang.Login.mp4

Login.mp4

bandicam.2023-08-29.00-26-57-998.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ Le Thi Thu Thuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692681137050609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0185c017a22df15531
• Upwork Job ID: 1699385050983682048
• Last Price Increase: 2023-09-06

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@flaviadefaria Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0185c017a22df15531

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[naveedauliat]

I want to be a contributor

[melvin-bot]

📣 @naveedauliat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[naveedauliat]

Contributor details
Your Expensify account email: naveedauliat@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/naveedauliat

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[naveedauliat]

Contributor details
Your Expensify account email: naveedauliat@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/naveedauliat

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[robertKozik]

Hello @naveedauliat, if you'd like to contribute to this issue, please feel free to draft a proposal with your suggested solution. For additional details on contributing, you can refer to our contribution guidelines.

[Selyatin]

Contributor details

Your Expensify account email: selyatinismet@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016e2c0344b1f727ea

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Selyatin]

@robertKozik @izarutskaya

The issue is caused by ActiveClientManager picking the most recently opened browser tab as the Leader Client, meaning all the request processing must be handled through the most recently opened tab to keep all tabs synchronized.

Here's the SequentialQueue line that checks if the current client is the leader or not, then processes the request if it's the leader, otherwise it doesn't take any action.

Removing the leader check causes issues in the app, as demonstrated here.

2023-09-07.03-58-06.mp4

Using the latest opened tab works as displayed here:

2023-09-07.04-05-16.mp4

The most straightforward solution to this problem is disabling the Login form on the page that's not the leader and displaying a message to the user such as You've opened the Login page in a separate tab, please Login from that specific tab.

The complex path involves implementing a synchronization method. This method would include polling the persistent data stored in IndexDB and removing the task that is executed by the current tab to prevent it from being executed by other tabs.

I'll prepare a PR with the straightforward solution, since the complex path doesn't seem to be a viable solution, it would most likely require quite a bit of changes on how the queue is handled. However I might be wrong since I've only dabbled my feet in the project for merely 3 hours.

[robertKozik]

Hello @Selyatin! Your input is greatly appreciated. Could you please create your proposal using this template? I'll review it, and if you're assigned, you can proceed with preparing a PR. You can find additional information in our contributing guidelines.

[Selyatin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user opens multiple tabs of the login page and tries to login with any tab other than the most recently opened one the page will keep in loading state and will not issue any requests to the back-end.

What is the root cause of that problem?

We only make requests from the leader tab which is the most recently opened one. Thus meaning if the user uses any tab that is not the leader, then the app will not make any requests to make sure all tabs are properly synchronized.

What changes do you think we should make in order to solve the problem?

Informing the user that they've opened a separate tab and that they should use that tab to Login would be the best option. Such as You've opened the Login page in a separate tab, please Login from that specific tab.

What alternative solutions did you explore? (Optional)

We could implement a more complex synchronization method which could be done via fetching the networkRequestQueue from OnxyDB before every action, and whenever a tab is going to start executing a task it would immediately remove the task from networkRequestQueue, to ensure that no other tabs would execute that task.

[melvin-bot]

@robertKozik, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show notification instead of login page when user has another tab open - #26161 #27385

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Selyatin requires payment
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Cannot determine any particular PR, it's new edge-case which was not handed
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I believe it's highly unlikely for this bug to be reproduced. Therefore, in my opinion, creating a new regression test might be redundant.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[flaviadefaria]

Payment Summary:

@Selyatin requires payment
@robertKozik does not require payment (Contractor)

@Selyatin - $500 - 50% penalty = $250
@ Le Thi Thu Thuy - $50 (reporting bonus)

[flaviadefaria]

@ Le Thi Thu Thuy isn't an actual GH handle so I can't communicate with or pay this contributor.
@Selyatin I can't find you in UW can you please send me your profile link? Thanks!

[situchan]

@thuyle04 is the correct GH handle (found on slack)
cc: @flaviadefaria

[Selyatin]

@flaviadefaria https://www.upwork.com/freelancers/~016e2c0344b1f727ea

[flaviadefaria]

@Selyatin offer sent!
@thuyle04 I can't find you in UW can you please send me your profile link? Thanks!

[flaviadefaria]

Bump @thuyle04!

[flaviadefaria]

@Selyatin you've been paid!
@thuyle04 please reopen this GH once you're ready to share your UW credentials.

[thuyle04]

Contributor details
Your Expensify account email: thuy.lethithu@antbuddy.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01fcd9ed589276332f

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[thuyle04]

Contributor details
Your Expensify account email: thuy.lethithu@antbuddy.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01fcd9ed589276332f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[flaviadefaria]

@thuyle04 thanks! I sent you an offer, now I just need you to accept it so that I can process your payment.

[thuyle04]

@flaviadefaria I think I will be paid 250 USD instead of 50 USD (old payment structure ) because the new payment structure was just changed on August 31 while the bug was approved before that.

[flaviadefaria]

Cool, np! You can accept the contract and I'll pay the 200 difference as a bonus. Can you let me know once you have accepted it?

[flaviadefaria]

@thuyle04 you've been paid so closing this.