Show notification instead of login page when user has another tab open - #26161 #27385

Selyatin · 2023-09-13T18:35:45Z

@robertKozik

Details

Fixed Issues

$ #26161
PROPOSAL: #26161 (comment)

Tests

Verify that no errors appear in the JS console
Open the Login page.
Open a new Login page in a new window or tab.
Check if Another Login Page is Open. text is shown in the first window/tab.

Offline tests

No specific offline tests are required.

QA Steps

Open the Login page.
Open a new Login page in a new window or tab.
Check if the Another Login Page is Open. text is shown in the first window/tab.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1694629875604069
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-09-13.19-47-29.mp4

Mobile Web - Chrome

2023-10-05.14-54-36.mp4

Mobile Web - Safari

2023-10-05.15-00-12.mp4

Desktop

2023-10-05.15-12-44.mp4

iOS

2023-10-05.16-02-33.mp4

Android

2023-10-05.16-47-19.mp4

melvin-bot · 2023-09-13T18:35:50Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-09-13T18:35:58Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Selyatin · 2023-09-13T18:41:00Z

I have read the CLA Document and I hereby sign the CLA

robertKozik · 2023-09-26T11:46:09Z

Sorry for the delay. Could you fill the PR author checklist? I see a lot unticked boxes

Selyatin · 2023-09-26T23:04:53Z

@robertKozik Done.

robertKozik · 2023-09-29T06:26:01Z

I'm still seeing that you didn't test the PR on High traffic account, also as the side note, if some checkboxes are not applicable for your PR (fe. mobile videos/screenshots) please tick them as well as it's stated on the last checkbox

robertKozik · 2023-09-29T10:06:26Z

@Selyatin eslint is failing. screen attached with errors.

Selyatin · 2023-10-04T12:24:28Z

@robertKozik I've fixed the errors.

robertKozik · 2023-10-04T12:41:22Z

Sorry missed that. Will review today

robertKozik · 2023-10-04T21:32:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.-.ios.-.web.mov

Mobile Web - Safari

android.-.ios.-.web.mov

Desktop

desktop.mov

iOS

android.-.ios.-native.mov

Android

android.-.ios.-native.mov

robertKozik · 2023-10-04T22:16:12Z

I'm still seeing that you didn't test the PR on High traffic account, also as the side note, if some checkboxes are not applicable for your PR (fe. mobile videos/screenshots) please tick them as well as it's stated on the last checkbox

As I stated above, please refill remaining videos - if nothing changed, please just go through login flow to see there is no regressions

Selyatin · 2023-10-05T13:50:41Z

All videos have been added @robertKozik.

robertKozik · 2023-10-05T14:03:51Z

Also we are missing test steps, please update them to cover login flow, and opening another instance on web.

Once done, again please tick all the checkboxes from the PR Author checklist ( I see not ticked the ones about the tests on platforms)

Selyatin · 2023-10-05T15:29:27Z

@robertKozik Done.

robertKozik

LGTM

melvin-bot · 2023-10-06T06:54:02Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #26161 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

cristipaval · 2023-10-06T12:29:39Z

Lint is not happy, @Selyatin 🙏

Selyatin · 2023-10-06T19:36:18Z

@cristipaval Should be fine now, had to run prettier.

OSBotify · 2023-10-06T21:43:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-09T23:02:01Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T04:42:17Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T05:11:11Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T22:00:17Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:12:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:28:33Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:03:58Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:15:38Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:51:58Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ntdiary · 2023-10-28T03:26:53Z

src/pages/signin/SignInPage.js

@@ -93,6 +98,8 @@ function SignInPage({credentials, account, isInModal}) {
        App.setLocale(Localize.getDevicePreferredLocale());
    }, []);

+    const isClientTheLeader = activeClients && ActiveClientManager.isClientTheLeader();


Coming from #29170.
This is a good start, but there is a second step in this page where we also need to check for the client leader (validate code form). : )

jjcoffee · 2024-02-05T14:54:00Z

src/pages/signin/SignInPage.js

        },
    );

    let welcomeHeader = '';
    let welcomeText = '';
    const headerText = translate('login.hero.header');
-    if (shouldShowLoginForm) {
+
+    if (!isClientTheLeader) {


Coming from #34567, we haven't considered here that we should also check if the tab is actually visible before switching display of the "another login page is open" message.

Selyatin added 2 commits September 13, 2023 19:18

Show notification instead of login page when user has another tab open

bf41580

Remove capitalization from 'Login' and 'Page'.

a26b91b

Selyatin requested a review from a team as a code owner September 13, 2023 18:35

melvin-bot bot requested review from robertKozik and removed request for a team September 13, 2023 18:35

Selyatin added 2 commits September 13, 2023 21:38

Update comment

8dfde8e

Update comment again

21a9a90

Fix eslint errors

74b5261

robertKozik approved these changes Oct 6, 2023

View reviewed changes

melvin-bot bot requested a review from cristipaval October 6, 2023 06:54

cristipaval previously approved these changes Oct 6, 2023

View reviewed changes

Fix lint by running prettier

0029936

Selyatin dismissed cristipaval’s stale review via 0029936 October 6, 2023 19:34

cristipaval approved these changes Oct 6, 2023

View reviewed changes

cristipaval merged commit c0fe505 into Expensify:main Oct 6, 2023

OSBotify mentioned this pull request Oct 9, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

This was referenced Oct 10, 2023

[HOLD for payment 2023-10-27] [$500] Web - Login - Login page loads infinitely when logging in from 'Another login page is open' page #29170

Closed

[$500] mWeb/Chrome - Login - Google logo flickers with white box when swiping between two login tabs #29172

Closed

melvin-bot bot mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-18] [$500] Log in - Can't login with google button when open 2 tabs #26161

Closed

6 tasks

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

ntdiary reviewed Oct 28, 2023

View reviewed changes

dummy-1111 mentioned this pull request Jan 17, 2024

[HOLD for payment 2024-02-07] [$500] Magic code - An additional page appears when navigate from Abracadabra page #34567

Closed

6 tasks

jjcoffee reviewed Feb 5, 2024

View reviewed changes

greg-schroeder mentioned this pull request Feb 16, 2024

[$500] Another Login Page is Open view is not shown in the first window/tab #36651

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show notification instead of login page when user has another tab open - #26161 #27385

Show notification instead of login page when user has another tab open - #26161 #27385

Selyatin commented Sep 13, 2023 •

edited

Loading

melvin-bot bot commented Sep 13, 2023

github-actions bot commented Sep 13, 2023 •

edited

Loading

Selyatin commented Sep 13, 2023

robertKozik commented Sep 26, 2023

Selyatin commented Sep 26, 2023

robertKozik commented Sep 29, 2023

robertKozik commented Sep 29, 2023

Selyatin commented Oct 4, 2023

robertKozik commented Oct 4, 2023

robertKozik commented Oct 4, 2023 •

edited

Loading

robertKozik commented Oct 4, 2023

Selyatin commented Oct 5, 2023

robertKozik commented Oct 5, 2023

Selyatin commented Oct 5, 2023

robertKozik left a comment

melvin-bot bot commented Oct 6, 2023

cristipaval commented Oct 6, 2023

Selyatin commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

ntdiary Oct 28, 2023

jjcoffee Feb 5, 2024 •

edited

Loading

Show notification instead of login page when user has another tab open - #26161 #27385

Show notification instead of login page when user has another tab open - #26161 #27385

Conversation

Selyatin commented Sep 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 13, 2023

github-actions bot commented Sep 13, 2023 • edited Loading

Selyatin commented Sep 13, 2023

robertKozik commented Sep 26, 2023

Selyatin commented Sep 26, 2023

robertKozik commented Sep 29, 2023

robertKozik commented Sep 29, 2023

Selyatin commented Oct 4, 2023

robertKozik commented Oct 4, 2023

robertKozik commented Oct 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

robertKozik commented Oct 4, 2023

Selyatin commented Oct 5, 2023

robertKozik commented Oct 5, 2023

Selyatin commented Oct 5, 2023

robertKozik left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 6, 2023

cristipaval commented Oct 6, 2023

Selyatin commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

ntdiary Oct 28, 2023

Choose a reason for hiding this comment

jjcoffee Feb 5, 2024 • edited Loading

Choose a reason for hiding this comment

Selyatin commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

robertKozik commented Oct 4, 2023 •

edited

Loading

jjcoffee Feb 5, 2024 •

edited

Loading