Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed
64 tasks done
OSBotify opened this issue Oct 9, 2023 · 15 comments
Closed
64 tasks done

Deploy Checklist: New Expensify 2023-10-09 #29131

OSBotify opened this issue Oct 9, 2023 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

Release Version: 1.3.80-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 10, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.80-0 🚀

@kavimuru
Copy link

kavimuru commented Oct 10, 2023

@jasperhuangg Regression TR is 81% progress. We are still validating couple PRs.

#25543 failing with #29163 (blocker)
#28628 failing with #29178
Need help with these 2 PRs (not sure if our QA team can validate) #28377 (comment) and #28920 (comment)

@kavimuru
Copy link

@jasperhuangg Regression TR is just1% left.

#25543 failing with #29163 (blocker)
#28628 failing with #29178

We have open blockers #29159, #29160, #29162, #29163, #29170, #29172, #29183, #29184 and #29186

@mvtglobally
Copy link

@jasperhuangg

Regression is completed.

Open Blockers:
#29159
#29160
#29162
#29163
#29170
#29172
#29183
#29184
#29186

Unchecked PRs:
#25543 failing with #29163 (blocker)
#28628 failing with #29178

Can you pls tag us if there are any CPs needed to re-test

@jasperhuangg jasperhuangg self-assigned this Oct 10, 2023
@jasperhuangg
Copy link
Contributor

@mvtglobally #29189 CP'd, should fix #29160, please retest, thanks!

@jasperhuangg
Copy link
Contributor

#29162 is a known follow-up issue, so checking it off

@jasperhuangg
Copy link
Contributor

#29160 was fixed by #29189, checking it off

@jasperhuangg
Copy link
Contributor

Checking off #29172 not a blocker

@jasperhuangg
Copy link
Contributor

Closed #29184

@jasperhuangg
Copy link
Contributor

Closed #29186

@jasperhuangg
Copy link
Contributor

Checking off #29221, doesn't need to be a blocker

@jasperhuangg
Copy link
Contributor

#29183 is reproducible on prod, checking it off

@jasperhuangg
Copy link
Contributor

Checking off #28628 since the failing QA is also reproducible on production

@jasperhuangg
Copy link
Contributor

Checking off #29159 CP'd #29251 to fix it

@jasperhuangg
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants