[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

izarutskaya · 2023-10-10T08:04:49Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Go to staging.new.expensify.com or open iOS/Android/Desktop App
Login with any account
Open a chat with many messages
Mark any message as unread
Check that a green line "New" appears above the message
Mark another message as unread

Expected Result:

Green line "New" appears above the another message

Actual Result:

Green line still marks the previous message

Green line appears above another message only after the chat is reloaded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6231446_1696914315542.iOS-Greenline-appear-1st-message-only-until-chat-reload.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Bug6231446_1696914315537.Desktop-Greenline-appear-1st-message-only-until-chat-reload.mp4

View all open jobs on GitHub

melvin-bot · 2023-10-10T08:04:54Z

Job added to Upwork: https://www.upwork.com/jobs/~01de5cb06e0da1953b

melvin-bot · 2023-10-10T08:04:55Z

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-10T08:04:57Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-10T08:04:59Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

OSBotify · 2023-10-10T08:06:26Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-10T08:06:29Z

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

izarutskaya · 2023-10-10T08:07:43Z

Not repro in Prod

Screen_Recording_20231010_121919_New.Expensify.mp4

hungvu193 · 2023-10-10T08:47:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green line only appears on the first message marked as unread until the chat is reloaded

What is the root cause of that problem?

This is a regression from #28146
it's race condition between our 2 useEffect:

App/src/pages/home/report/ReportActionsList.js

Lines 304 to 314 in 562f9d8

    
           useEffect(() => { 
        
               // Iterate through the report actions and set appropriate unread marker. 
        
               // This is to avoid a warning of: 
        
               // Cannot update a component (ReportActionsList) while rendering a different component (CellRenderer). 
        
               _.each(sortedReportActions, (reportAction, index) => { 
        
                   if (!shouldDisplayNewMarker(reportAction, index)) { 
        
                       return; 
        
                   } 
        
                   setCurrentUnreadMarker(reportAction.reportActionID); 
        
               }); 
        
           }, [sortedReportActions, report.lastReadTime, messageManuallyMarkedUnread, shouldDisplayNewMarker]);

and

App/src/pages/home/report/ReportActionsList.js

Lines 178 to 187 in 562f9d8

    
           useEffect(() => { 
        
               const didManuallyMarkReportAsUnread = report.lastReadTime < DateUtils.getDBTime() && ReportUtils.isUnread(report); 
        
               if (didManuallyMarkReportAsUnread) { 
        
                   // Clearing the current unread marker so that it can be recalculated 
        
                   setCurrentUnreadMarker(null); 
        
                   setMessageManuallyMarkedUnread(new Date().getTime()); 
        
                   return; 
        
               } 
        
               setMessageManuallyMarkedUnread(0);

The first one tried to update new currentUnreadMarker while the second one tried to reset currentUnreadMarker, so the logic of shouldDisplayNewMarker will be wrong because currentUnreadMarker will never be null once it's set.

What changes do you think we should make in order to solve the problem?

Update the first useEffect (mentioned above) to only update the currentUnreadMarker only when didManuallyMarkReportAsUnread is false:

 const didManuallyMarkReportAsUnread = report.lastReadTime < DateUtils.getDBTime() && ReportUtils.isUnread(report);
        _.each(sortedReportActions, (reportAction, index) => {
            if (!shouldDisplayNewMarker(reportAction, index) || didManuallyMarkReportAsUnread) {
                return;
            }

What alternative solutions did you explore? (Optional)

N/a

Result

Screen.Recording.2023-10-10.at.15.48.15.mp4

lakchote · 2023-10-10T11:10:06Z

@aimane-chnaif please review the proposals as soon as possible since it's a deploy blocker.

aimane-chnaif · 2023-10-10T13:37:57Z

I don't like @hungvu193's proposal. It will cause another regression of "New message" badge not appearing after scrolling up because currentUnreadMarker is set to null.
I suggest to revert offending PR and let original contributors rework considering this regression as original bug is not critical than this one.

aimane-chnaif · 2023-10-10T13:47:37Z

@lakchote PR is ready

melvin-bot · 2023-10-13T21:58:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Revert "Fix unread marker showing double lines on task comment" #29189

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T21:58:45Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:51:22Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Revert "Fix unread marker showing double lines on task comment" #29189

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:51:24Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:13:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Revert "Fix unread marker showing double lines on task comment" #29189

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:14:01Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:39:23Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Revert "Fix unread marker showing double lines on task comment" #29189

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:39:25Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

NicMendonca · 2023-10-18T20:19:27Z

@aimane-chnaif can you apply to the job please? https://www.upwork.com/jobs/~01de5cb06e0da1953b

aimane-chnaif · 2023-10-18T20:20:32Z

@NicMendonca please unassign and assign me back. Melvin will send offer automatically.

NicMendonca · 2023-10-18T20:34:24Z

Are you sure? Melv couldn't get payment date right 😂

NicMendonca · 2023-10-19T18:02:36Z

@aimane-chnaif offer sent

NicMendonca · 2023-10-20T20:27:42Z

@aimane-chnaif you've been paid!

izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 10, 2023

melvin-bot bot changed the title ~~Chat - Green line only appears on the first message marked as unread until the chat is reloaded~~ [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded Oct 10, 2023

melvin-bot bot assigned NicMendonca Oct 10, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 10, 2023

melvin-bot bot assigned aimane-chnaif Oct 10, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 10, 2023

OSBotify mentioned this issue Oct 10, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

melvin-bot bot assigned lakchote Oct 10, 2023

aimane-chnaif mentioned this issue Oct 10, 2023

Revert "Fix unread marker showing double lines on task comment" #29189

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 10, 2023

jasperhuangg mentioned this issue Oct 10, 2023

Fix unread marker showing double lines on task comment #28146

Merged

59 tasks

melvin-bot bot removed the Weekly KSv2 label Oct 11, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 17, 2023

NicMendonca assigned aimane-chnaif and unassigned aimane-chnaif Oct 18, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2023

NicMendonca closed this as completed Oct 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

izarutskaya commented Oct 10, 2023 •

edited

Loading

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

OSBotify commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

izarutskaya commented Oct 10, 2023

hungvu193 commented Oct 10, 2023 •

edited

Loading

lakchote commented Oct 10, 2023

aimane-chnaif commented Oct 10, 2023 •

edited

Loading

aimane-chnaif commented Oct 10, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

NicMendonca commented Oct 18, 2023

aimane-chnaif commented Oct 18, 2023 •

edited

Loading

NicMendonca commented Oct 18, 2023

NicMendonca commented Oct 19, 2023

NicMendonca commented Oct 20, 2023

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

Comments

izarutskaya commented Oct 10, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Green line still marks the previous message

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 10, 2023

OSBotify commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

izarutskaya commented Oct 10, 2023

hungvu193 commented Oct 10, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

lakchote commented Oct 10, 2023

aimane-chnaif commented Oct 10, 2023 • edited Loading

aimane-chnaif commented Oct 10, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

NicMendonca commented Oct 18, 2023

aimane-chnaif commented Oct 18, 2023 • edited Loading

NicMendonca commented Oct 18, 2023

NicMendonca commented Oct 19, 2023

NicMendonca commented Oct 20, 2023

izarutskaya commented Oct 10, 2023 •

edited

Loading

hungvu193 commented Oct 10, 2023 •

edited

Loading

aimane-chnaif commented Oct 10, 2023 •

edited

Loading

aimane-chnaif commented Oct 18, 2023 •

edited

Loading