[HOLD for payment 2023-09-20] [$250] Translate the MODIFIEDEXPENSE messages

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

Stemming from the follow up clean up issue here #23961

1. Create money request
2. Edit some of its values
3. change language to Spanish

Expected Result:

Describe what you think should've happened

1. The modified expense messages are tranlated to Spannish

Actual Result:

Describe what actually happened

1. The messages stay in English

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab76a73fe3e15035
• Upwork Job ID: 1697104195145465856
• Last Price Increase: 2023-08-31
• Automatic offers:
• ntdiary | Reviewer | 26425879
• hungvu193 | Contributor | 26425881

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ab76a73fe3e15035

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Upwork job price has been updated to $250

[hungvu193]

Proposal

Please re-state the feature request that we are trying to solve in this issue.

Translate the MODIFIEDEXPENSE messages

What is the root cause of that problem?

We're using hard code text instead of translation text for getModifiedExpenseMessage and getProperSchemaForModifiedExpenseMessage

App/src/libs/ReportUtils.js

Line 1458 in c20c387

function getModifiedExpenseMessage(reportAction) {

App/src/libs/ReportUtils.js

Lines 1439 to 1450 in c20c387

	function getProperSchemaForModifiedExpenseMessage(newValue, oldValue, valueName, valueInQuotes) {
	const newValueToDisplay = valueInQuotes ? `"${newValue}"` : newValue;
	const oldValueToDisplay = valueInQuotes ? `"${oldValue}"` : oldValue;
	if (!oldValue) {
	return `set the ${valueName} to ${newValueToDisplay}`;
	}
	if (!newValue) {
	return `removed the ${valueName} (previously ${oldValueToDisplay})`;
	}
	return `changed the ${valueName} to ${newValueToDisplay} (previously ${oldValueToDisplay})`;
	}

What changes do you think we should make in order to solve the problem?

• Add all the missing translation text with formart from getModifiedExpenseMessage and getProperSchemaForModifiedExpenseMessage into en.js and es.js file.
• Replace the existing text from these above 2 functions with Localize.translateLocal.
  ie:

    if (_.isEmpty(reportActionOriginalMessage)) {
        return Localize.translateLocal("iou.changedRequest");
    }

What alternative solutions did you explore? (Optional)

N/A

[ntdiary]

This looks like a relatively straightforward task, and we can move forward quickly with @hungvu193 's proposal.

🎀 👀 🎀 C+ reviewed

cc @mountiny

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

lets ship it

[hungvu193]

Posting on slack for Spanish translation 👯‍♂️
https://expensify.slack.com/archives/C01GTK53T8Q/p1693468779417329

[BhuvaneshPatil]

I reported this issue way earlier but was marked as dupe
https://expensify.slack.com/archives/C049HHMV9SM/p1692079562836389

Even though the linked GH issue didn't solve the problem

[mountiny]

@BhuvaneshPatil thanks for the link, we knew about this polish when we implemented the feature initially thats why we marked it as a dupe

[mountiny]

I have just separated it to a new one now as the follow ups issue already had many of them

[BhuvaneshPatil]

Thank you for confirmation @mountiny

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Translate the MODIFIEDEXPENSE messages #26370

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment offer (Reviewer)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@ntdiary @hungvu193 Can you please finished the checklist

@garrettmknight can you please help with the payment? thanks!

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Ah, sorry, I missed this one.
This is just a translation task, so I feel there is no need to create a regression for this issue. : )

[garrettmknight]

Payment summary for this issue:

• urgency bonus: no
• Reporter: N/A
• Contributor: @hungvu193 $250 paid via Upwork
• Contributor+: @ntdiary $250 paid via Upwork