[HOLD for payment 2023-10-23] [$500] [Android] User isn't prompted for Camera permission via the native Modal

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Ensure the Camera permission is denied
2. Tap FAB > Request money > Scan
3. Click the 'Give Permission' button

Expected Result:

• We should show the native Android request permission modal
• Given that the user has tapped give permission, I don't think an initial 'We are going to ask you for permission' modal is required (it would in other cases in order to prevent the OS from blocking future permission requests)
• The solution should work exactly the same as it does for native Android/iOS apps

Actual Result:

I am deep linked directly to the top level generic app settings page, and must manually tap 'Permissions > Camera'

Workaround:

I must manually tap 'Permissions > Camera'. Some users might not know how to do this.

screen-20230901-162220.mp4

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1
Reproducible in staging?: yes
Reproducible in production?: yes (once deployed)
Issue reported by: @Julesssss
Slack conversation: N/A

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5f4967e2e242138
• Upwork Job ID: 1698645305652506624
• Last Price Increase: 2023-09-04
• Automatic offers:
• ntdiary | Reviewer | 26488566
• ishpaul777 | Contributor | 26488567
• zoontek | Contributor | 26980722

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

This is more of a feature improvement than a bug

[ishpaul777]

@Julesssss what if we directly request permission with native pop up on click of button, if permission "denied" or "restricted" then show native alert modal similar to flow of launching camera while adding attachements.
ref - https://github.com/Expensify/App/blob/main/src/components/AttachmentPicker/launchCamera.android.js#L14C5-L23C11

Screeshot

[akinwale]

@Julesssss It's not possible to deep-link directly to the Camera settings page. The best option is to open the App settings page which is what is currently happening.

Also, the current implementation seems weird. I would assume that the app should try to request for the camera permission at least once (which shows a dialog to grant or deny the request), before making the user have to navigate to the device app settings.

[sakluger]

@Julesssss do you need me to triage this issue or anything, or are you going to mostly manage the issue and I can just handle any contributor payments that come up?

[Julesssss]

It's not possible to deep-link directly to the Camera settings page.

Ah, right. We can deep link directly to the location permission so I assumed it worked for all permissions. Oh well.

I would assume that the app should try to request for the camera permission at least once (which shows a dialog to grant or deny the request), before making the user have to navigate to the device app settings.

100% agree with this and ishpaul777's comment. That's what we should be doing on native Android.

@sakluger I'll update the description and will manage it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f5f4967e2e242138

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[ishpaul777]

Can i pick this @Julesssss ?

[ishpaul777]

Proposal

Problem

User isn't prompted for Camera permission via the native Modal

Root cause

N/a , new feature/improvement

Changes

• Modify askForPermissions to ask for permission everytime button is clicked

const askForPermissions = () => {
            Camera.requestCameraPermission().then((permissionStatus) => {
                setPermissionStatus(permissionStatus)
            })
            // optional Catch runtime errors
  };

[Julesssss]

@ishpaul777 correct me if I'm wrong, but I think only the second part of your solution is necessary. We are already checking for permission and showing the 'Grant Permission' button, so we can immediately show the prompt.

Why would we want to show the native modal if they deny the permission? (showPermissionsAlert )

[ishpaul777]

that's what we do while launching camera in report.

Record_2023-09-04-16-30-47.mp4

"We are already checking for permission and showing the 'Grant Permission' button, so we can immediately show the prompt."

We can omit showing alert modal in this case then.

[Julesssss]

Ahm, so that is NOT a native permission modal. Cool

[ishpaul777]

Proposal

Updated

[Julesssss]

I still think that's not necessary in this case though. By tapping the button we can assume they intend to grant the permission. And if they then choose to deny it, we don't need to warn them. It's pretty obvious due to the illustration and 'Grant Permission' button that they won't be able to do anything until granted.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Android camera permission prompt #28619

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @zoontek requires payment offer (Contributor)
• @ntdiary requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

Can be paid out today

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Add ability to Take/Upload Receipts #23046
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23046/files#r1368834273
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This is not a regression, just a UX improvement.

[sakluger]

Looks like the offer to @ntdiary somehow expired. I sent a new offer, can you please accept?

@zoontek it also looks like you haven't accepted our offer for this job yet. Could you please accept and let me know so I can complete payment?

Thanks!

[zoontek]

@sakluger Sorry, I accepted it.

[sakluger]

Thanks @zoontek! I completed your payment.

[ntdiary]

Looks like the offer to @ntdiary somehow expired. I sent a new offer, can you please accept?

@sakluger, thank you! Accepted. : )

[sakluger]

All done, thanks everyone!