[HOLD for payment 2023-09-18] [$500] Dev: console error if we open RHN page directly

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Try to open direct link of RHN(for eg, http://localhost:8082/settings)
2. Observe the console error

Expected Result:

Should not occur console error
Actual Result:
Error Failed prop type: The prop isBlockedFromConciergeis marked as required inAttachmentPickerWithMenuItems, but its value is undefined. occurs

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: DEV
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-26.at.00.20.43.mov

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692985306887049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013c4503a94278a1ad
• Upwork Job ID: 1699435322866675712
• Last Price Increase: 2023-09-06
• Automatic offers:
• situchan | Reviewer | 26527992
• Pujan92 | Contributor | 26527994
• Pujan92 | Reporter | 26527998

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @Pujan92

Please re-state the problem that we are trying to solve in this issue.

Console error for isBlockedFromConcierge passed undefined but it’s required prop

What is the root cause of that problem?

In PR we added prop isBlockedFromConcierge required in AttachmentPickerWithMenuItems & ComposerWithSuggestions components. But from ReportActionCompose it gets passed undefined when we directly open the RHN screen.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 158 in 7217a18

const isBlockedFromConcierge = useMemo(() => ReportUtils.chatIncludesConcierge(report) && User.isBlockedFromConcierge(blockedFromConcierge), [report, blockedFromConcierge]);

Bcoz by the time the report gets loaded it has a default value {reportID: ‘0’}, so condition ReportUtils.chatIncludesConcierge(report) returns undefined, with that undefined && false returns undefined and issue persist.

What changes do you think we should make in order to solve the problem?

We need to update the condition to make sure it will return a boolean value instead of undefined.

App/src/libs/ReportUtils.js

Lines 809 to 811 in 57603a0

	function chatIncludesConcierge(report) {
	return report.participantAccountIDs && _.contains(report.participantAccountIDs, CONST.ACCOUNT_ID.CONCIERGE);
	}

!_.isEmpty(report.participantAccountIDs)

OR
We can use double negate or Boolean constructor to make ReportUtils.chatIncludesConcierge a boolean value.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 158 in 7217a18

const isBlockedFromConcierge = useMemo(() => ReportUtils.chatIncludesConcierge(report) && User.isBlockedFromConcierge(blockedFromConcierge), [report, blockedFromConcierge]);

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

DEV: console error on ReportActionCompose

What is the root cause of that problem?

We calculate isBlockedFromConcierge here

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 159 in bb432aa

const isBlockedFromConcierge = useMemo(() => ReportUtils.chatIncludesConcierge(report) && User.isBlockedFromConcierge(blockedFromConcierge), [report, blockedFromConcierge]);

In chatIncludesConcierge, before the data is loaded completely report.participantAccountIDs is undefined that makes this function return undefined and then isBlockedFromConcierge is undefined because undefined && boolean = undefined

App/src/libs/ReportUtils.js

Lines 809 to 811 in bb432aa

	function chatIncludesConcierge(report) {
	return report.participantAccountIDs && _.contains(report.participantAccountIDs, CONST.ACCOUNT_ID.CONCIERGE);
	}

What changes do you think we should make in order to solve the problem?

We should update chatIncludesConcierge function to make sure it always returns a boolean by getting participantAccountIDs or set it as an empty array

function chatIncludesConcierge(report) {
    const participantAccountIDs = report.parentReportActionIDs || []
    return participantAccountIDs && _.contains(participantAccountIDs, CONST.ACCOUNT_ID.CONCIERGE);
}

App/src/libs/ReportUtils.js

Lines 809 to 811 in bb432aa

	function chatIncludesConcierge(report) {
	return report.participantAccountIDs && _.contains(report.participantAccountIDs, CONST.ACCOUNT_ID.CONCIERGE);
	}

What alternative solutions did you explore? (Optional)

We can also set default isBlockedFromConcierge prop value in AttachmentPickerWithMenuItems and ComposerWithSuggestions

[situchan]

Just doing an expedited review as this is annoying. When refresh app every time, hard to see other console errors caused by test branch as this one shows always.

@Pujan92's proposal looks good - !_.isEmpty(report.participantAccountIDs)

@sonialiap as this is dev-only issue, I am going to pull up engineer directly - 🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkuoch]

@Pujan92 's proposal looks good, but seems like I can't assign them to the issue, maybe because they didn't post the proposal to this issue by themselves?

[situchan]

@Pujan92 's proposal looks good, but seems like I can't assign them to the issue, maybe because they didn't post the proposal to this issue by themselves?

correct.

@Pujan92 please comment with any word here so @nkuoch can assign.
@nkuoch please assign me too 🙂

[Pujan92]

Commenting to get assigned.

[Pujan92]

I think external and help-wanted labels also required to generate offers.

[situchan]

@nkuoch can you please do actions in this order?

• unassign @Pujan92
• assign @situchan
• add External label
• after a few seconds, assign @Pujan92

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013c4503a94278a1ad

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

Payments - sent ✔️
@Pujan92 report + fix + bonus = $50 + $500 + $250 = $800 edit based on this $250 + $500 + $250 = $1000
@situchan review + bonus = $500 + $250 = $750

[sonialiap]

@situchan please fill out the checklist so that we can close this issue :)

[situchan]

This doesn't require BZ checklist.
Console error check is already in PR checklist and it's just dev error, not affecting production app.

[Pujan92]

@sonialiap Can you plz check this slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1694444733848299 and confirm whether this should be eligible for old payment price or not as this issue gets reported on 25th aug before new pay price(31st aug) applied.

[sonialiap]

@Pujan92 Thanks for bringing this up! I went by the date the gh issue was opened and didn't check the reporting date.

The reporting date was Aug 26 so you are eligible for the old reporting bonus of $250. I have already issued a payment of $50 so you're owed $200. I just sent an offer for $200.

[Pujan92]

Thanks @sonialiap for reconsidering but I believe contributor price also needs to be updated by considering it($1000+$500 for urgency bonus)

[melvin-bot]

@nkuoch, @Pujan92, @sonialiap, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

@Pujan92 The GH issue was created and became available after the pricing change so the fix and review are both $500

[Pujan92]

Oh, ok @sonialiap. I thought all payments needs to be with old price. Thanks for clearing.

[melvin-bot]

@nkuoch, @Pujan92, @sonialiap, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

I believe all payments have been processed, please reopen if I missed anything in the discussion

[Pujan92]

I believe all payments have been processed, please reopen if I missed anything in the discussion

@sonialiap payment is pending here, could you plz check.

[Pujan92]

Bump @sonialiap

[Pujan92]

Bump @sonialiap for remaining payment

[sonialiap]

@Pujan92 my apologies! Payment completed!

[Pujan92]

No issues, Thanks!