[HOLD for payment 2023-10-09] [HOLD for payment 2023-09-29] [$500] There is a larger gap between the Apple icon and the Google icon on Android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to login page

Expected Result:

The gap should be consistent across all platforms

Actual Result:

The gap is larger on Android

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693020637974179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0158363a81364181da
• Upwork Job ID: 1698574418489659392
• Last Price Increase: 2023-09-04
• Automatic offers:
• aman-atg | Contributor | 26711713
• aman-atg | Reporter | 26711715

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @aman-atg

Please re-state the problem that we are trying to solve in this issue.

There is a larger gap between the Apple icon and the Google icon on Android

What is the root cause of that problem?

The root cause of the problem is the styles provided to IconButton here as it provides margin:10px for both buttons resulting in a larger gap in native devices since IconButton is being used there.

What changes do you think we should make in order to solve the problem?

We should make changes here to avoid horizontal margin for both buttons. Then, we can use gap: 12 for button containers or marginLeft: 12 for Google Button on all platforms to have consistent spacing.

What alternative solutions did you explore? (Optional)

[sophiepintoraetz]

@kavimuru - please make sure you're checking all the affected platforms.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0158363a81364181da

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a smaller gap between the Apple icon and the Google icon on Web/mWeb

What is the root cause of that problem?

In Desktop/Native apps, we use the IconButton component to render Apple and Google icon

App/src/components/SignInButtons/GoogleSignIn/index.desktop.js

Lines 21 to 26 in d58bc2a

	<IconButton
	onPress={() => {
	window.open(googleSignInWebRouteForDesktopFlow);
	}}
	provider={CONST.SIGN_IN_METHOD.GOOGLE}
	/>

But in Web, we use a primitive div to render them

App/src/components/SignInButtons/AppleSignIn/index.website.js

Lines 84 to 94 in d58bc2a

	<div
	id="appleid-signin"
	data-mode="center-align"
	data-type="continue"
	data-color="white"
	data-border="false"
	data-border-radius="50"
	data-width={CONST.SIGN_IN_FORM_WIDTH}
	data-height="52"
	style={{cursor: 'pointer'}}
	/>

So I think the inconsistency here is in Web/mWeb, it's not in neither Desktop or native apps. In Web/mWeb platform, we forgot to apply the same margin for icons here

App/src/components/SignInButtons/IconButton.js

Line 39 in d58bc2a

style={styles.signInIconButton}

What changes do you think we should make in order to solve the problem?

In AppleSignIn and GoogleSignIn components for web, we need to apply the same style as we applied for native platforms, which is styles.signInIconButton. So the gap between icons will be consistency among platforms.

App/src/components/SignInButtons/AppleSignIn/index.website.js

Line 104 in d58bc2a

style={{cursor: 'pointer'}}

[payal-lathidadiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a smaller gap between the Apple icon and the Google icon on Web/mWeb

What is the root cause of that problem?

The cause of this inconsistent UI layout is due to different styles applied for component/elements in web and mWeb.

• On mWeb and native app, it renders as IconButton here. And it applies these CSS style
• On web, the same style is not applied for web component here

This resulted in inconsistency of margin/padding across platforms.

What changes do you think we should make in order to solve the problem?

To fix this inconsistency, we can replace below style of web component to have same as sign in IconButton of mWeb/native here and here

style={styles.signInIconButton} 

This changes should be applied to both Google and Apple sign in components

What alternative solutions did you explore? (Optional)

None

[sophiepintoraetz]

Waiting on @robertKozik to review the proposals!

[robertKozik]

Hi all! Thank you for your proposals 🙇🏼

It appears that all of you have accurately identified the root cause of the issue. Furthermore, all the proposed solutions were quite similar. However, I would prefer the solution from @aman-atg, as it moves the setting of gap to a file that is not platform-dependent. This way, we can ensure consistency without style repetition.

Selected Proposal: proposal
contributor: @aman-atg

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@marcochavezf, @sophiepintoraetz, @robertKozik Huh... This is 4 days overdue. Who can take care of this?

[sophiepintoraetz]

@marcochavezf - please can you review the proposal on this issue?

[marcochavezf]

Thanks @robertKozik for reviewing the proposals. I agree with what you commented, assigning here @aman-atg 🚀

[marcochavezf]

Hmm it seems I cannot assign @aman-atg, is this the first GH issue that you will be assigned as contributor?

[aman-atg]

@marcochavezf No, it's not the first one.

[aman-atg]

It might be because I hadn't commented on the thread. Can you please try again?

cc: @marcochavezf

[thienlnam]

QA found that this was not fixed in Android #27837 (comment)

[aman-atg]

I think it is due to this padding style being used in src/components/SignInButtons/IconButton.js

App/src/styles/styles.js

Lines 3721 to 3723 in b225b53

	signInIconButton: {
	padding: 2,
	},

App/src/components/SignInButtons/IconButton.js

Line 39 in b225b53

style={styles.signInIconButton}

cc: @robertKozik

[robertKozik]

@aman-atg Yeah, I think you're right. We overlooked this one during the initial PR. But maybe let's stick to changing the padding to be only vertical. This way, we won't introduce any change on the vertical axis.

[aman-atg]

PR is ready for review!

cc: @robertKozik

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• use gap in login button row container for consistency #27441

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aman-atg requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)
• @aman-atg requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

Not awaiting payment yet. Followup PR is under review

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @aman-atg got assigned: 2023-09-16 22:23:28 Z
• when the PR got merged: 2023-09-27 02:38:32 UTC
• days elapsed: 6

On to the next one 🚀

[sophiepintoraetz]

Payment date is elapsed - paid out!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• use vertical padding for signInIconButton #27953

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aman-atg requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)
• @aman-atg requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: