Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-10] [$1000] No activity yet appears in task item of search RHN. #26679

Closed
1 of 6 tasks
kavimuru opened this issue Sep 4, 2023 · 69 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Sep 4, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Assign a task.
  2. Click on Mark as done.
  3. Send a message.
  4. Delete the message.
  5. Open search RHN by pressing CRTL+K.
  6. Observe the created task item in search RHN.

Expected Result:

No activity yet appears in task item of search RHN.

Actual Result:

No activity yet should not appear.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.62-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-09-04.20-03-21-003.mp4
2023-08-25_16-28-00.mp4

Expensify/Expensify Issue URL:
Issue reported by: @oleksandr-pantsyr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692977375401449

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dac65c2c994b81e0
  • Upwork Job ID: 1699721930034528256
  • Last Price Increase: 2023-09-20
  • Automatic offers:
    • rojiphil | Contributor | 26875557
Issue OwnerCurrent Issue Owner: @rushatgabhane
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Sep 7, 2023
@bfitzexpensify
Copy link
Contributor

Reproduced, sending this external

@melvin-bot melvin-bot bot removed the Overdue label Sep 7, 2023
@bfitzexpensify bfitzexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 7, 2023
@melvin-bot melvin-bot bot changed the title No activity yet appears in task item of search RHN. [$500] No activity yet appears in task item of search RHN. Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dac65c2c994b81e0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@DylanDylann
Copy link
Contributor

Screenshot 2023-09-07 at 17 09 45

The BE return lastMessagetext is '' after deleting a message. We should fix it in BE

@Santhosh-Sellavel
Copy link
Collaborator

@thienlnam
Is this valid bug?
Your thoughts seems like backend?

@Santhosh-Sellavel
Copy link
Collaborator

I am unassigning due to low bandwidth, if C+ assistance required assign a new C+ by reapplying External label

cc: @bfitzexpensify

@Santhosh-Sellavel Santhosh-Sellavel removed their assignment Sep 7, 2023
@thienlnam
Copy link
Contributor

Hmm yeah looks like a BE update is needed for this specific scenario

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam thienlnam added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bfitzexpensify
Copy link
Contributor

OK, adding the engineering label in that case

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 17, 2023

  1. The PR that introduced the bug has been identified. Link to the PR: Create Task FrontEnd Changes #17992

  2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17992/files#r1396870570

  3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required because it was a new feature.

  4. Determine if we should create a regression test for this bug. Yes

  5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

    1. Click on FAB for a Chat Report and Assign a Task
    2. In the Task Report, click on Mark as done button in header.
    3. Send a message in Task Report.
    4. Delete the message in Step 3 in Task Report
    5. Navigate to Search Page via CTRL+K or LHN Search button.
    6. Expected Behaviour: Verify that the Task Status message for completed task is displayed as subtitle/alternate text in Search Page.

@rushatgabhane
Copy link
Member

created a payment request on new dot https://staging.new.expensify.com/r/3693896450043765

@JmillsExpensify
Copy link

$1,500 payment approved for @rushatgabhane based on BZ summary.

@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@bfitzexpensify
Copy link
Contributor

Friendly bump on that BZ checklist @rushatgabhane - thank you!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

@rojiphil, @Gonals, @rushatgabhane, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@bfitzexpensify
Copy link
Contributor

Another bump on the checklist @rushatgabhane - thanks!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2023
@bfitzexpensify
Copy link
Contributor

Reminder on the BZ checklist @rushatgabhane

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2023

@rojiphil, @Gonals, @rushatgabhane, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@bfitzexpensify
Copy link
Contributor

@rushatgabhane can you please complete this checklist so we can close this issue out?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 31, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

@rojiphil, @Gonals, @rushatgabhane, @bfitzexpensify Huh... This is 4 days overdue. Who can take care of this?

@bfitzexpensify
Copy link
Contributor

Just waiting on BZ checklist here, Melv

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 7, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

@rojiphil, @Gonals, @rushatgabhane, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 14, 2023

@rojiphil, @Gonals, @rushatgabhane, @bfitzexpensify Still overdue 6 days?! Let's take care of this!

@rushatgabhane
Copy link
Member

@bfitzexpensify updated the checklist #26679 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Nov 17, 2023
@bfitzexpensify
Copy link
Contributor

Thanks @rushatgabhane! Created a regression test update. We're all done here, thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests