[HOLD for payment 2023-09-13] [$500] Tapping download on download banner should deeplink to App and dismiss banner

[JmillsExpensify]

We recently added a download banner as part of our sign-up flow for upcoming conferences, though oddly, if you tap download and we correctly deeplink you to the App Store, the download banner still appears.

Solution: We should dismiss the download banner no matter which option a user choose, either ignore or `download1.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d3134e73e0c4471
• Upwork Job ID: 1698771665257160704
• Last Price Increase: 2023-09-04

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d3134e73e0c4471

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping download on download banner should deeplink to App and dismiss banner

What is the root cause of that problem?

We we click on download we're just opening the app using deeplink but not closing the modal.

What changes do you think we should make in order to solve the problem?

We should close the modal by setting state here. in this function

App/src/components/DownloadAppModal.js

Line 46 in 1e0a249

const handleOpenAppStore = () => {

setshouldShowBanner & setShowDownloadAppModal to false.

What alternative solutions did you explore? (Optional)

NA

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We're not closing the download app banner after clicking download.

What is the root cause of that problem?

In the handleOpenAppStore function, we're not closing the modal.

What changes do you think we should make in order to solve the problem?

We need to add the following in the handleOpenAppStore method:

        setShowDownloadAppModal(false);
        setshouldShowBanner(false);

This will also save the modal visibility in Onyx so that it does not appear again in the user session.

What alternative solutions did you explore? (Optional)

None

[allroundexperts]

For the person reviewing this, please note that I proposed the complete solution earlier.

[b4s36t4]

I agree with @allroundexperts, he proposed the full solution (setShowDownloadAppModal) includes this. It took me sometime to verify my solution and update it.

[parthpvaghani]

Proposal

What is the root cause of that problem?
In the handleOpenAppStore function, we're not closing the modal by not calling the handleCloseBanner function.

What changes do you think we should make in order to solve the problem?
We need to make sure we first call handleCloseBanner function inside handleOpenAppStore function so that visually UI/UX wise it represents the closing modal and then visits the external app Url

const handleOpenAppStore = () => {
    handleCloseBanner()
    Link.openExternalLink(link, true);
};

What alternative solutions did you explore? (Optional)

1st >>
const handleOpenAppStore = () => {
setShowDownloadAppModal(false);
setshouldShowBanner(false);
Link.openExternalLink(link, true);
};

2nd >>
We can remove custom logic being set from our DownloadAppModal component and move it to the upper-level parent component

so shouldShowBanner and onClose be propped to our DownloadAppModal and we can utilise it anymore with more controls in the future with callback

const handleOpenAppStore = () => {
    if (onClose) {
        onClose();
    }
    Link.openExternalLink(link, true);
};

[melvin-bot]

📣 @parthpvaghani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[parthpvaghani]

Contributor details
Your Expensify account email: parthvaghani14@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[narefyev91]

Proposal from @allroundexperts looks good to me #26706 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91 / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91 / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91 / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91 / @allroundexperts] Determine if we should create a regression test for this bug.
• [@narefyev91 / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

@allroundexperts Mind getting us kick off with the bug zero checklist?

[JmillsExpensify]

In the meantime, here's the payment summary:

• Contributor: @allroundexperts $750 (incl. urgency bonus)
• Contributor+: @narefyev91 Agency

[melvin-bot]

@JmillsExpensify, @cristipaval, @narefyev91, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR: - it's a fully additional functionality which was not coming from any regressions
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A

[melvin-bot]

@JmillsExpensify, @cristipaval, @narefyev91, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[cristipaval]

@JmillsExpensify @allroundexperts what's the status for te payment here?

[cristipaval]

bump @JmillsExpensify @allroundexperts

[allroundexperts]

@cristipaval I have requested the payment in ND. Waiting for @JmillsExpensify to approve the request!

[cristipaval]

Alright, @JmillsExpensify might be delayed with some chores due to the traveling over the weekend.

[cristipaval]

It seems that @JmillsExpensify was ooo last days. He'll hopefully take care of this one soon.

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.