[HOLD for payment 2023-10-18] [HOLD for payment 2023-09-20] [$500] BUG: [distance] Tapping date on iOS confirmation screen crashes the app

[neil-marcellini]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings> preferences> language> choose spanish.
2. Click green plus, request money, distance
3. Enter start and finish addresses
4. Click next
5. Click the date field

Expected Result:

You are navigated to the date selector page

Actual Result:

The app crashes

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

date-crash.MP4

Expensify/Expensify Issue URL:
Issue reported by: @ahmedGaber93 originally, and @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693773862316259 and https://expensify.slack.com/archives/C05DWUDHVK7/p1693858687755119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01410dc76d9aff99d8
• Upwork Job ID: 1698795084385435648
• Last Price Increase: 2023-09-04
• Automatic offers:
• situchan | Contributor | 26532576
• ahmedGaber93 | Reporter | 26532579
• mkhutornyi | Contributor | 26532619

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01410dc76d9aff99d8

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[ahmedGaber93]

@neil-marcellini
I report this issue yesterday in slack expensify-bugs channel here https://expensify.slack.com/archives/C049HHMV9SM/p1693773862316259
can you check which is reported first? Because the attached Slack conversation not opened with me.

[neil-marcellini]

Oh thanks I missed that, I'll update the description with your report.

[JmillsExpensify]

Taking this one from Anu as part of wave5.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Native app crashes on Date picker page when language is set to Spanish

What is the root cause of that problem?

The crash happens from moment.js library
ref: facebook/react-native#1629 (comment)

What changes do you think we should make in order to solve the problem?

import moment/locale/es anywhere in the app. I think lib/actions/App.js is the suitable place.
ref: facebook/react-native#1629 (comment)

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[neil-marcellini]

@situchan jumped in as the C+ from Slack and since he got this moving I'm going to have him take it over.

[neil-marcellini]

We both like the proposal from @mkhutornyi and Situ verified that it fixes the issue. Please raise a PR soon.

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

Hold on here. We are going to remove the moment soon #19810. I don't think we should be doing this change unless it is going to stay.

[neil-marcellini]

Ah ok good call out. So maybe we should consider replacing the use of moment here with some other library in line with the replacement plan on that issue?

That being said, it's most important to fix the crash now and we can always replace the use of moment.js later.

[situchan]

@neil-marcellini seems like moment will be fully removed soon - #19810 (comment)

[neil-marcellini]

This is still reproducible. While we could wait for moment.js to be removed fully, I think we should re-implement the fix that was accidentally reverted. Having the whole app crash when using this feature in Spanish is pretty bad. @mkhutornyi would you please put up a PR today?

RPReplay_Final1696524243.mov

[mkhutornyi]

This is still reproducible. While we could wait for moment.js to be removed fully, I think we should re-implement the fix that was accidentally reverted. Having the whole app crash when using this feature in Spanish is pretty bad. @mkhutornyi would you please put up a PR today?

RPReplay_Final1696524243.mov

sure

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @mkhutornyi got assigned: 2023-09-06 19:03:54 Z
• when the PR got merged: 2023-10-06 18:50:51 UTC
• days elapsed: 21

On to the next one 🚀

[neil-marcellini]

^ that's incorrect, he did that within 3 days of being requested.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• import moment for es locale #28948

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)
• @ahmedGaber93 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[neil-marcellini]

@situchan please fill out the checklist

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Datetime polyfill, removed moment.tz.guess() #26248
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Datetime polyfill, removed moment.tz.guess() #26248 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to Settings > Preferences > Language > Choose Spanish
2. Click FAB > Request money > Select Distance tab
3. Enter start and finish addresses
4. Click Next
5. Click the date field
6. Verify that app doesn't crash and date picker shows

We may not need regression test for this because this bug is specific to momentjs library which will be removed soon.
And there's already comment in code to avoid regression.

App/src/libs/actions/App.js

Lines 1 to 3 in 18acd82

	// Do not remove this import until moment package is fully removed.
	// Issue - https://github.com/Expensify/App/issues/26719
	import 'moment/locale/es';

[neil-marcellini]

Yeah I don't think we need the regression test.

[neil-marcellini]

@anmurali if you would please pay this then I think it's done.

[anmurali]

Everyone's paid.