Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold #24482] [$500] mWeb - Blank space is shown while scrolling through country list, Personal details #26732

Closed
1 of 6 tasks
kbecciv opened this issue Sep 4, 2023 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 4, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to settings > profile > personal details
  2. Go to home address
  3. Enter a home address and save
  4. Go to home address > select the country field
  5. Clear the search input
  6. Type a common letter so you have lots of results i.e A or S
  7. Now scroll the list view and notice that screen cuts through midway and a blank space is shown.

Expected Result:

Blank space should not appear in scrolling through the list in mweb.

Actual Result:

Blank space is shown while scrolling through country list, Personal details in mweb

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.63.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-08-31-16-50-15.mp4
Screen_Recording_20230904_194053_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693480395646199

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c5e6c8d70ee65eb0
  • Upwork Job ID: 1699220262429036544
  • Last Price Increase: 2023-09-06
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@trjExpensify
Copy link
Contributor

The repro steps could be improved a bit to follow, so I changed them to this and can reproduce it:

  1. Go to settings > profile > personal details
  2. Go to home address
  3. Enter a home address and save
  4. Go to home address > select the country field
  5. Clear the search input
  6. Type a common letter so you have lots of results i.e A or S
  7. Now scroll the list view and notice that screen cuts through midway and a blank space is shown.
gqT6U2yVi5.mp4

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Sep 6, 2023
@melvin-bot melvin-bot bot changed the title mWeb - Blank space is shown while scrolling through country list, Personal details [$500] mWeb - Blank space is shown while scrolling through country list, Personal details Sep 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c5e6c8d70ee65eb0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@pradeepmdk
Copy link
Contributor

pradeepmdk commented Sep 6, 2023

dube #24397

@trjExpensify
Copy link
Contributor

Yeah, you're probably right that's the same root cause. Putting it on hold for this: #24482

@trjExpensify trjExpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 7, 2023
@trjExpensify trjExpensify changed the title [$500] mWeb - Blank space is shown while scrolling through country list, Personal details [Hold #24482] [$500] mWeb - Blank space is shown while scrolling through country list, Personal details Sep 7, 2023
@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Sep 11, 2023

@trjExpensify This is dupe.
We should close this issue and re-open the other issue #24397 (comment) as discussed previously.

@trjExpensify
Copy link
Contributor

I think we should keep it on hold to test against the react native version bump, no? This issue is consistently reproducible, whereas the other one people are claiming might not be.

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@trjExpensify
Copy link
Contributor

Linked PR is still in review.

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@trjExpensify
Copy link
Contributor

Still on hold!

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2023
@trjExpensify
Copy link
Contributor

Still waiting on the RNW version bump.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@trjExpensify
Copy link
Contributor

Still waiting on the RNW version bump.

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@trjExpensify
Copy link
Contributor

Still waiting on the RNW version bump.

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2023
@trjExpensify
Copy link
Contributor

RNW bump is merged and on staging 🎉

@ashimsharma10 can you retest on Android Chrome staging? Preferably a native device. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@trjExpensify
Copy link
Contributor

Bump @ashimsharma10.

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2023
@trjExpensify
Copy link
Contributor

@situchan do you have a native Android device to test this please?

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@situchan
Copy link
Contributor

yes I have. Will test shortly

@trjExpensify
Copy link
Contributor

trjExpensify commented Nov 29, 2023 via email

@situchan
Copy link
Contributor

Reproduced but blank space disappears quickly. I think it's not worth fixing and can be closed

@trjExpensify
Copy link
Contributor

Cool, works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants