[$500] [Teachers Unite!] Implement optimistic whisper message

[marcochavezf]

After the volunteer referral flow ("I know a teacher") is completed, we redirect the user to the public room. But if the user performs this action in offline mode, we’ll just display the chat report as loading (since we’ll persist the request, we will share the room anyway once the request has been made).

Given that’s the default offline behavior for public rooms (i.e. when the user opens the native app from a deep link), we’ll implement, as a follow-up, the optimistic whisper message to notify the user that at least something is happening.

Whisper message for the inviter/referrer:

"Hey @" + inviterDisplayName + "! Thanks for referring your friend " + firstName + " to <a href=\"https://www.expensify.org\" rel=\"noreferrer noopener\">Expensify.org</a> Teachers Unite. We have gone ahead and reached out to them! We'll continue to share any important announcements here to keep you in the loop about the campaign's impact. If you'd like to refer someone else, just click on Save The World in the app's main menu. Thanks for helping us to Save The World!"

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab3acade482df27d
• Upwork Job ID: 1699130464263553024
• Last Price Increase: 2024-02-15

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

I can help to implement this feature request

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Teachers Unite!] Implement optimistic whisper message

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

In this function, we can add an optimistic Data of a report action with whisperedToAccountIDs data, same as we did for reportReview or IOU report action

App/src/libs/actions/TeachersUnite.js

Lines 34 to 44 in 8150ce0

	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.REPORT}${optimisticPublicRoom.reportID}`,
	value: {
	...optimisticPublicRoom,
	reportID: optimisticPublicRoom.reportID,
	policyName: CONST.TEACHERS_UNITE.POLICY_NAME,
	},
	},
	];

[rezkiy37]

Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue.

[rezkiy37]

I was investigating the issue. Already have an idea how to do it clear.

Guys, I’m OOO from tomorrow until next Monday due the RNEU conference. If it is not an urgent issue, I can continue to work on.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ab3acade482df27d

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[tjferriss]

@burczu can you take a look at @hoangzinh proposal?

[burczu]

@tjferriss Yes - I'll review it today.

[burczu]

@hoangzinh Could you be more specific how exactly you want to add this whisperedToAccountIDs parameter to optimistic data? I've tried it with no luck...

[burczu]

Just to inform: I'll be OOO on Thursday and Friday (7-8 September).

[hoangzinh]

It seems it should make this issue on-hold until "Save The World" is added back to FAB #26930

[rezkiy37]

Hi, guys!
I am back. So, please let me know do you need my help here?

[melvin-bot]

@burczu, @tjferriss Huh... This is 4 days overdue. Who can take care of this?

[burczu]

Not overdue - @tjferriss are we gonna assign @rezkiy37 as he is back? Or maybe we are going to put this on hold (#26738 (comment))?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rezkiy37]

@tjferriss, just to friendly reminder about - #26738 (comment).

[tjferriss]

Yes, I think we can put this on hold for now while we figure out when we'll be launch the Save the World flow. The tracking issue for the project is here: https://github.com/Expensify/Expensify/issues/223645

[marcochavezf]

Sorry no update, I've been focused on wave bugs

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[marcochavezf]

Sorry no update, I've been focused on wave bugs

Same, but fortunately most of them are done. I will move it to daily to continue with this one next week

[marcochavezf]

No update today, wrapping up other dailies, then I will continue with this one

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[marcochavezf]

Phew, I thought I was going to have time to check out this one, still a bit behind with some critical bugs

[melvin-bot]

@marcochavezf, @tjferriss, @rezkiy37 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcochavezf]

Prioritizing today some critical bugs

[strepanier03]

Looks like we need a new BZ here, reassigning.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

https://expensify.slack.com/archives/C01GTK53T8Q/p1708375641196609
Closing