[HOLD for payment 2023-09-29] [$500] Assign task - Colon (:) added to completed/reopened task messages when copy pasting

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. login to staging new dot
2. Go to any chat with a task
3. Copy the completed or reopened task message using the copy to clipboard icon
4. Paste the copied content in the composer and observe that a colon is added after completed or reopend when pasting

Expected Result:

Pasted content should be identical to copied content

Actual Result:

Pasted content has colon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

scrnli_8_25_2023_8-37-21.PM.mp4

Recording.1448.mp4

Expensify/Expensify Issue URL:

Issue reported by: @SofoniasN @oleksandr-pantsyr (reported first here)

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692985594255829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012810233ffe197834
• Upwork Job ID: 1699809589610123264
• Last Price Increase: 2023-09-07
• Automatic offers:
• Ollyws | Reviewer | 26589564
• sofoniasN | Reporter | 26589566
• oleksandr-pantsyr | Contributor | 26974844

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Colon (:) added to completed/reopened task messages when copy pasting

What is the root cause of that problem?

• Currently, the copied text is from the originalMessage that has the colon (:):

  App/src/pages/home/report/ContextMenu/ContextMenuActions.js

  Line 189 in f67bf9f

  const originalMessage = _.get(reportAction, 'originalMessage', {});

• But the displayed task action message is from: ${taskStatusText} ${taskReportName} that does not has the colon (:):
  

  App/src/components/ReportActionItem/TaskAction.js

  Lines 38 to 63 in f67bf9f

  	function TaskAction(props) {
  	const taskReportName = props.taskReport.reportName || '';
  	let taskStatusText = '';
  	switch (props.actionName) {
  	case CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED:
  	taskStatusText = props.translate('task.messages.completed');
  	break;
  	case CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED:
  	taskStatusText = props.translate('task.messages.canceled');
  	break;
  	case CONST.REPORT.ACTIONS.TYPE.TASKREOPENED:
  	taskStatusText = props.translate('task.messages.reopened');
  	break;
  	default:
  	taskStatusText = props.translate('task.task');
  	}
  	return (
  	<>
  	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
  	<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText} ${taskReportName}`}</Text>
  	</View>
  	</>
  	);
  	}

What changes do you think we should make in order to solve the problem?

• We can change the way to get the copied text to the same way that used to get the task action message like below:
• Create the getTaskReportActionMessage that is used for both <TaskAction /> and copiedText:

const getTaskReportMessage = (reportAction, translate) => {
    const taskReport = ReportUtils.getReport(reportAction.originalMessage.taskReportID.toString());
    const taskReportName = taskReport.reportName || '';

    let taskStatusText = '';
    switch (reportAction.actionName) {
        case CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED:
            taskStatusText = translate('task.messages.completed');
            break;
        case CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED:
            taskStatusText = translate('task.messages.canceled');
            break;
        case CONST.REPORT.ACTIONS.TYPE.TASKREOPENED:
            taskStatusText = translate('task.messages.reopened');
            break;
        default:
            taskStatusText = translate('task.task');
    }
    return `${taskStatusText} ${taskReportName}`;
};

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We use originalMessage to get the text to be copied here -

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 190 in b95c1dd

const messageHtml = isTaskAction ? lodashGet(originalMessage, 'html', '') : lodashGet(message, 'html', '');

and it looks like this

Observe it contains semicolon.
but while rendering it we display that separately(prop translation)

App/src/components/ReportActionItem/TaskAction.js

Lines 57 to 63 in b95c1dd

	<>
	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
	<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText} ${taskReportName}`}</Text>
	</View>
	</>
	);
	}

What changes do you think we should make in order to solve the problem?

There are two approaches that to solve this -

• We either change the TaskAction and add colon there

<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText}: ${taskReportName}`}</Text>

• We change the logic for copy action here -
  

  App/src/pages/home/report/ContextMenu/ContextMenuActions.js

  Line 190 in b95c1dd

  const messageHtml = isTaskAction ? lodashGet(originalMessage, 'html', '') : lodashGet(message, 'html', '');

For this we can create a new method in ReportActionUtils - getTaskActionText(actionName) it will return translated key for all the CONST.REPORT.ACTIONS.TYPE and then use it on above mentioned line while copying the text

What alternative solutions did you explore? (Optional)

[zanyrenney]

Yep, reproducible here - adding external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012810233ffe197834

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

The problem is we are copying originalMessage which is redundant here, also it doesn't translate when the language is changed. We should be copying the localization as that's what's displayed, so @DylanDylann's proposal looks good to me.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[luacmartins]

Agreed with C+ assessment.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @SofoniasN 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[DylanDylann]

@Ollyws @luacmartins The PR #27119 ready for review

[parasharrajat]

If we are solving this issue here, we should solve it completely to cover all the cases.

1. Tasks [$500] Web - Assigned task title doesn't update when copying after changing it #26571
2. IOU. [$500] The updated amount is not copied to clipboard. #26664
3. other such actions.

I would still suggest that we wait as it have been confirmed a regression from #24569 (comment)

[pecanoro]

This got a bit chaotic, mostly because #26571 was opened and reported before this one so the other one should take priority. That means that we won't be paying the reporting bonus for this one.

However, we DO need to fix all cases in one single PR. That means that either @DylanDylann, you fix all problems in your PR or the original contributor does it.

[DylanDylann]

@pecanoro I will fix all cases in my PR. My current PR also fix #26571

[pecanoro]

Awesome, glad to hear! I will close the other one!

@zanyrenney The original reporter is @oleksandr-pantsyr since this was a duplicate with the same root cause.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @DylanDylann got assigned: 2023-09-10 06:02:55 Z
• when the PR got merged: 2023-09-19 01:01:37 UTC
• days elapsed: 5

On to the next one 🚀

[DylanDylann]

The PR is out of scope to fix some related issues. It caused the timeline to extend beyond 3 days

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/26753: Colon added to completed reopened task messages when copy pasting #27119

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @DylanDylann requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[oleksandr-pantsyr]

Hi @pecanoro @izarutskaya

I've not got an offer in Upwork. It seems to go to the original reporter.

Could you resolve this issue?

[pecanoro]

I don't think we have sent any offers yet, we will handle after the regression period.

[melvin-bot]

📣 @oleksandr-pantsyr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[zanyrenney]

@Ollyws requires payment offer (Reviewer) $500 PAID
@DylanDylann requires payment $500
@oleksandr-pantsyr requires payment for reporting bonus $50 (PAID $500 accidentally so requested refund for $450)

[zanyrenney]

waiting on @DylanDylann and @oleksandr-pantsyr to accept job offers.

[zanyrenney]

ugh upwork automation messed this one up and gave the payment for @oleksandr-pantsyr wrong. i have reached out to them In DM to request they decline the payment - when I try to submit a refund i get this error:

[DylanDylann]

This PR lasted long time because this PR is out of scope (fix another issue) as mentioned #26753 (comment). So are we eligible for a bonus here? The PR may be merged sooner if only fix this issue

@pecanoro @Ollyws Could you help to check this? Many thanks

[zanyrenney]

Sorry @DylanDylann this doesn't qualify for the bonus, the rules are set on the days taken to merge. As with all issues, we try to be as fair as possible but are operating within the guidelines set.

[Ollyws]

BugZero Checklist:
I don't think we can really say this is a regression from any PR, as the context-menu has been copying the message from the backend here since its implementation.
I don't think a regression test would be helpful here because: It's not related to an important flow, it's not particularly easy to test for nor is it an impactful bug.

[zanyrenney]

All paid out!