[HOLD for payment 2023-10-02] [$500] mWeb - Opening smaller profile pic from request money details causes zoom in zoom out glitch

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: User should have another user in recent chats that has profile pic which does not cover full width on opening

1. Open the app in android chrome
2. Click on plus and click on request money
3. Enter any amount and click next
4. Select the user with smaller profile pic
5. Click on user profile to open user details
6. Click on profile pic and observe that it zooms in and zooms out in few seconds

Expected Result:

App should not glitch when opening smaller profile pic from user details page

Actual Result:

App glitches when opening smaller profile pic from user details visited from details page of request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.64.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

glitch.on.opening.profile.pic.mp4

Screen_Recording_20230906_105609_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693559822391119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01845037b08588f72c
• Upwork Job ID: 1702059344831913984
• Last Price Increase: 2023-09-13
• Automatic offers:
• dukenv0307 | Contributor | 26743899
• dhanashree-sawant | Reporter | 26743903

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

asking clarification question

https://expensify.slack.com/archives/C049HHMV9SM/p1694123811151679?thread_ts=1693559822.391119&cid=C049HHMV9SM

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

Bumping slack

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01845037b08588f72c

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[kevinksullivan]

confirmed reproducible and moving forward.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App glitches when opening smaller profile pic from user details visited from details page of request money

What is the root cause of that problem?

Here, we'll show the image as soon as isLoading becomes false, however the zoomScale is set after isLoading, so there's a brief time isLoading is false but zoomScale is still 0, causing the resizeMode to be contain here. So the small image initially fills the screen, until resizeMode becomes center right after that (after the zoomScale state is set), then it moves to the correct size and position.

What changes do you think we should make in order to solve the problem?

We can update this line to

style={(isLoading || zoomScale === 0) ? undefined : [styles.w100, styles.h100]}

so we'll make sure to only show the image after the zoomScale is set.

This line can be updated similarly as well so we still show the loading indicator when zoomScale is not set yet.

What alternative solutions did you explore? (Optional)

We can make sure zoomScale state is always set already before we set isLoading to false. We can do that by setting isLoading to false only in useEffect after the zoomScale becomes set

useEffect(() => {
    if (zoomScale > 0) {
        setIsLoading(false);
    }
}, [zoomScale])

Another alternative, we can probably remove the isLoading state and derive it from the zoomScale instead, since they are always updated along side each other, and if zoomScale = 0 / > 0, it pretty much means that isLoading is true / false

const isLoading = zoomScale === 0;

[kevinksullivan]

Hey @sobitneupane what do you think about the proposal above?

[sobitneupane]

Thanks for the proposal @dukenv0307
Proposal from @dukenv0307 looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Li357]

@dukenv0307 Proposal looks good, thanks!

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($500)

[dukenv0307]

@sobitneupane The PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @sobitneupane / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-09-19 01:54:39 Z
• when the PR got merged: 2023-09-21 07:38:39 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Adding zoom scale condition to profile image to prevent the App from glitches when opening a smaller profile pic from the user details page #27739

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @dukenv0307 requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@Li357, @kevinksullivan, @sobitneupane, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@Li357, @kevinksullivan, @sobitneupane, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#9279

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/9279/files#r1349952938

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is an edge case missed while introducing new feature.

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#26882 (comment)

[sobitneupane]

Regression Test Proposal

1. Open the app in android chrome
2. Use very small image as the profile picture of the user.
3. Send message
4. Click on users profile to open user details.
5. Open the profile picture by clicking on it.
6. Verify that there is no glitch while opening the picture.

Do we agree 👍 or 👎

[sobitneupane]

#26882 (comment)

As it qualifies for an urgency bonus, I am requesting a payment of $750 in newDot.

[kevinksullivan]

Payment summary

Reporter: @dhanashree-sawant $50
Contributor: @dukenv0307 $750
C+: @sobitneupane $750 (in NewDot)

[kevinksullivan]

Paid out @dhairyasenjaliya and @dukenv0307

[JmillsExpensify]

$750 payment approved for @sobitneupane based on BZ summary.

[JmillsExpensify]

Also did the regression test get added? Re-opening to confirm.

[kevinksullivan]

Ah good catch, adding.