Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] LHN reflects wrong hint when user sents message after an attachment #26997

Closed
1 of 6 tasks
kavimuru opened this issue Sep 7, 2023 · 59 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Sep 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

step 1: open workspace from user A
step 2: add user B to the work space
step 3: send attachment from user A
step 4: send message from user B
step 5: observe LHN tab hint from user A

Expected Result: LHN tab hint shows the message

Actual Result: LHN tab hint shows attachment

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.65-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

admin.LHN.hint.gets.wrong.when.user.sends.message.after.admin.sennt.attachment.mp4
Recording.1565.mp4

Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693315853678109

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0163d7b176bbb6f038
  • Upwork Job ID: 1715323614227767296
  • Last Price Increase: 2023-12-08
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@rmm-fl

This comment was marked as outdated.

@jscardona12
Copy link
Contributor

It is reproducible on lastest main
Screenshot 2023-09-07 at 4 42 28 PM

@allroundexperts
Copy link
Contributor

This should be fixed from the backend. The pusher is not sending the updated lastMessageTranslationKey for the report.

Screenshot 2023-09-08 at 3 04 15 AM

@allroundexperts
Copy link
Contributor

We can also solve this by removing this but I think we should fix it from the backend.

@s-alves10
Copy link
Contributor

This would be fixed by this PR
I think we can hold this issue

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

@allroundexperts do you agree with this?

This would be fixed by this PR
I think we can hold this issue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

@johncschuster johncschuster changed the title LHN reflects wrong hint when user sents message after an attachment [HOLD for #26850] LHN reflects wrong hint when user sents message after an attachment Sep 19, 2023
@johncschuster johncschuster added Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2023
@johncschuster
Copy link
Contributor

Putting this on hold while we wait for https://github.com/Expensify/App/pull/26850/files

@johncschuster
Copy link
Contributor

Ok! It looks like #26850 has been deployed to prod. @kavimuru / @lidiyakelay can you check to see if this behavior persists?

@johncschuster
Copy link
Contributor

bump @kavimuru / @lidiyakelay

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@johncschuster
Copy link
Contributor

bump @kavimuru / @lidiyakelay

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@lidiyakelay
Copy link

@johncschuster SORRY!! for the late reply. This issue doesn't seem to be occurring anymore.

Lhn_GITHUB.mp4

@lidiyakelay
Copy link

@johncschuster but this seems to be still occurring on mobile app

@lidiyakelay
Copy link

bump @johncschuster

@s77rt
Copy link
Contributor

s77rt commented Nov 18, 2023

@johncschuster Let's close this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 18, 2023
@s77rt
Copy link
Contributor

s77rt commented Nov 20, 2023

@johncschuster ^

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fourth week). Are we good to close?

@melvin-bot melvin-bot bot added the Overdue label Nov 23, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

@johncschuster, @s77rt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 24, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@s77rt
Copy link
Contributor

s77rt commented Nov 27, 2023

@johncschuster This can be closed

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

@johncschuster, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 30, 2023
@s77rt
Copy link
Contributor

s77rt commented Dec 1, 2023

@johncschuster ^

@melvin-bot melvin-bot bot removed the Overdue label Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@s77rt
Copy link
Contributor

s77rt commented Dec 4, 2023

Not overdue. To be closed

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 4, 2023
@s77rt
Copy link
Contributor

s77rt commented Dec 7, 2023

To be closed ^

@melvin-bot melvin-bot bot removed the Overdue label Dec 7, 2023
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fifth week)

Copy link

melvin-bot bot commented Dec 8, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@johncschuster, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 13, 2023

@johncschuster, @s77rt Huh... This is 4 days overdue. Who can take care of this?

@johncschuster
Copy link
Contributor

Looks like we can close this one. Thanks, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests