After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

pradeepmdk · 2023-09-06T05:53:16Z

Details

Fixed Issues

$ #24246
PROPOSAL: #24246 (comment)

Tests

Log in to userA's account.
Go to Settings > Workspace > New Workspace.
Go to Member > Invite > Select user B.
Go to the 'announce' chat of the created workspace.
Pin the 'announce' chat to view the LHN properly.
Open another browser and login with userB’s account.
Go to the 'announce' page of userA's workspace.
Send an image to the announce chat.
Go back to userA’s account.
Send a message and delete it.
Now go to the userB’s account and delete the attachment.
Notice userA’s LHN displays 'No activity yet'.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.mp4

Mobile Web - Chrome

Untitled.mov

Mobile Web - Safari

Untitled.mov

Desktop

Untitled.mov

iOS

Untitled.mov

Android

Untitled.mov

melvin-bot · 2023-09-06T05:53:52Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-09-10T12:59:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-13.at.18.07.30.mov

Mobile Web - Chrome

Screen.Recording.2023-09-13.at.18.31.44.mov

Mobile Web - Safari

Screen.Recording.2023-09-13.at.18.16.45.mov

Desktop

Screen.Recording.2023-09-13.at.18.13.35.mov

iOS

Screen.Recording.2023-09-13.at.18.25.55.mov

Android

Screen.Recording.2023-09-13.at.18.28.34.mov

eVoloshchak

@pradeepmdk, there are a couple of changes needed for the author checklist

Tests section seems to be incorrect

Now go to the userB’s account and delete the attachment.
Notice userA’s LHN displays '[Attachment]' instead of 'No activity yet'.

That's how it works currently, without the fix. Tests should describe how to test if the bug was fixed

Screenshots/Videos section contains screenshots only for Web and iOS (should be for all of the platforms). Moreover, it shouldn't contain screenshots, but videos of going through steps for both accounts side by side (similar to this video, but with the fix applied)

Other than that, the code looks good and tests well, good job on this one!

pradeepmdk · 2023-09-10T14:18:44Z

@eVoloshchak all updated

Li357 · 2023-09-11T16:49:44Z

Unassigned @marcochavezf and assigning myself since I reviewed the proposals here.

eVoloshchak · 2023-09-12T17:33:34Z

@pradeepmdk, bug:

Go to announce, send an attachment, then send a text message
Delete the text message
Look at LHN, notice it shows common.attachment instead of [Attachment] for a brief period of time

Screen.Recording.2023-09-12.at.20.31.11.mov

pradeepmdk · 2023-09-13T01:13:52Z

@eVoloshchak looks like this different bug you want fix it here. here lastMessageText sending the
"common.attachment"

fix for this

if (translationKey && (text === CONST.ATTACHMENT_MESSAGE_TEXT || text === CONST.TRANSLATION_KEYS.ATTACHMENT)) {
        return translationKey === CONST.TRANSLATION_KEYS.ATTACHMENT;
    }

this issue coming from here in optimisticData they are setting text key as a CONST.TRANSLATION_KEYS.ATTACHMENT
https://github.com/Expensify/App/pull/26194/files

eVoloshchak · 2023-09-13T13:46:31Z

looks like this different bug you want fix it here

I couldn't reproduce this on staging, I think it's introduced by this PR (could you double-check that please?)
If it is, we should fix it here

pradeepmdk · 2023-09-13T14:37:18Z

I couldn't reproduce this on staging, I think it's introduced by this PR (could you double-check that please?)
If it is, we should fix it here

Yes I agree in this optimisticData they are sending common.attachement but now here we only allowing [Attachment] . so i am fixing here.

Screen.Recording.2023-09-13.at.8.05.20.PM.mov

pradeepmdk · 2023-09-13T15:54:21Z

@eVoloshchak fixed

eVoloshchak

LGTM

melvin-bot · 2023-09-13T16:23:20Z

🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #27374.

OSBotify · 2023-09-13T18:53:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-14T10:52:31Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:10:30Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

pradeepmdk requested a review from a team as a code owner September 6, 2023 05:53

melvin-bot bot requested review from marcochavezf and removed request for a team September 6, 2023 05:53

pradeepmdk added 2 commits September 8, 2023 09:16

adding condition

8792382

fix conflicts

00718d8

pradeepmdk force-pushed the fix/24246-attachement-no-activity branch from 156da40 to 00718d8 Compare September 8, 2023 03:54

eVoloshchak suggested changes Sep 10, 2023

View reviewed changes

Li357 requested review from Li357 and removed request for marcochavezf September 11, 2023 16:49

fix

1850aa8

make const changes

03522c3

eVoloshchak approved these changes Sep 13, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Sep 13, 2023

[2023-09-25] Payment issue for E/App PR#26850 #27374

Closed

Li357 approved these changes Sep 13, 2023

View reviewed changes

Li357 merged commit 4ff85db into Expensify:main Sep 13, 2023
12 checks passed

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

lanitochka17 mentioned this pull request Sep 14, 2023

[$500] Chat - Console error shows up when receiving message in #announce room #27447

Closed

6 tasks

johncschuster mentioned this pull request Sep 26, 2023

[$500] LHN reflects wrong hint when user sents message after an attachment #26997

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

pradeepmdk commented Sep 6, 2023 •

edited

Loading

melvin-bot bot commented Sep 6, 2023

eVoloshchak commented Sep 10, 2023 •

edited

Loading

eVoloshchak left a comment

pradeepmdk commented Sep 10, 2023

Li357 commented Sep 11, 2023

eVoloshchak commented Sep 12, 2023

pradeepmdk commented Sep 13, 2023 •

edited

Loading

eVoloshchak commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023 •

edited

Loading

pradeepmdk commented Sep 13, 2023

eVoloshchak left a comment

melvin-bot bot commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

Conversation

pradeepmdk commented Sep 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2023

eVoloshchak commented Sep 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

pradeepmdk commented Sep 10, 2023

Li357 commented Sep 11, 2023

eVoloshchak commented Sep 12, 2023

pradeepmdk commented Sep 13, 2023 • edited Loading

eVoloshchak commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023 • edited Loading

pradeepmdk commented Sep 13, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

pradeepmdk commented Sep 6, 2023 •

edited

Loading

eVoloshchak commented Sep 10, 2023 •

edited

Loading

pradeepmdk commented Sep 13, 2023 •

edited

Loading

pradeepmdk commented Sep 13, 2023 •

edited

Loading