Deploy Checklist: New Expensify 2023-09-14

[OSBotify]

Release Version: 1.3.70-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• @radoslawkrzemien/13604 local testing of GitHub actions #21937
• Convert SearchPage to functional component #23076
• Add focus trap to the RHP #24316
• fix: check canUseTouchScreen on each render #24356
• Hide flagged attachment in attachment carousel #24564
• feat: update electron builder to generate separate builds #24588
• Followup #23961: update IOU report total in optimistic data on edit money request #25498
• fix: cursor issue starting on left of text #25528
• [No QA] [TS migration] Migrate display.js to TypeScript #25817
• Improve translations - flatten translation objects #25846
• [No QA] [TS Migration] migrate bold to TypeScript #25851
• [No QA] [TS migration] Migrate 'cardStyles' style to TypeScript  #25886
• fix: maintain consistent topbar colour on login #25908
• [No QA] [TS Migration] migrate containerComposeStyles style to TypeScript #25920
• [No QA] [TS migration] Migrate 'useThemeStyles.js' style to TypeScript #25946
• fix: change field style colors when input is not editable #25991
• [No QA] [TS Migration] Migrate ThemeStylesProvider component to TypeScript #26060
• Fix/deeplinks when app in background #26073
• [No QA] [TS migration] Migrate 'getComponentDisplayName.js' lib to TypeScript #26080
• feat(selection-list): add tooltip #26091
• [No QA][TS migration] Migrate 'willBlurTextInputOnTapOutside' lib to TypeScript #26107
• https://github.com/Expensify/App/pull/26140
• Flavors support follow ups #26157
• Add /workspaces/* path into universal_link #26172
• [No QA] [TS migration] Migrate 'focusTextInputAfterAnimation' lib to TypeScript #26180
• reopen keyboard when tap back on gallery page. #26221
• Datetime polyfill, removed moment.tz.guess() #26248
• [NO QA] Feat: Add theme switching HOCs #26276
• [No QA] [TS migration] Migrate 'VisualViewport' lib to TypeScript  #26290
• Fix overlay size #26385
• Restrict Plaid link on Native too #26394
• fix: 26075 image does not show in full view on Staging Server #26411
• fix(selection-list): focus input on screen focus #26415
• fix image props for web #26452
• Categories UI/UX #26501
• Fix: adds FullPageNotFoundView view for completed task #26634
• [No QA] [TS Migration] migrate GetStyledTextArray to Typescript #26644
• fix close message #26662
• [No QA] [TS Migration] migrate CollectionUtils to Typescript #26668
• Update en.js: 'Home page' to 'home page' #26671
• [TS migration] Migrate 'getSecureEntryKeyboardType' lib to TypeScript #26673
• add message when search no result for timezone selector #26678
• Fix: Add avatar details to the Lounge Access Page  #26687
• fixed race condition in task creation and onyx #26692
• [TS migration] Migrate 'GooglePlacesUtils.js' lib to TypeScript #26750
• [No QA] [TS migration] Migrate 'StartupTimer' lib to TypeScript #26771
• [No QA] [TS migration] Migrate 'HapticFeedback' lib to TypeScript #26774
• disable "Didn't receive magic code" while loading #26783
• Implement new layout for SecurityPage #26784
• Change route for teachers unite campaign and add deep link to it #26806
• [TS migration] Migrate 'RequestThrottle.js' lib to TypeScript #24807 #26808
• Fix: 25448 ESC keyboard shortcut shows up in modal on second render on login page #26809
• [TS migration] Migrate 'StringUtils.js' lib to TypeScript #26810
• fix composer focusing for popups #26826
• Disable sequential keyboard navigation to pickers on Safari #26846
• After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850
• [No QA][TS migration] Migrate 'tryResolveUrlFromApiRoot.js' lib to TypeScript #26855
• [No QA] [TS migration] Migrate 'NumberUtils.js' lib to TypeScript #26864
• Fix: styling of Google Sign In button on Safari #26874
• [TS migration] Migrate 'Tab.js' lib to TypeScript #26932
• [No QA] [TS migration] Migrate 'Growl.js' lib to TypeScript #26933
• [No QA] [TS migration] Migrate 'LocaleDigitUtils.js' lib to TypeScript #26935
• [No QA] [TS migration] Migrate 'Network.js' lib to TypeScript #26949
• #26126: Tag menu item and Tag picker (1st PR) #26954
• [No QA] [TS migration] Migrate 'Modal.js' lib to TypeScript #26957
• [TS migration] Migrate 'Composer.js' lib to TypeScript #26974
• Update electron-builder to fix semver vulnerabilities #27001
• Add margin left to green dot icon #27008
• [No QA][TS migration] Migrate 'ActiveClients.js' lib to TypeScript #27014
• [No QA][TS migration] Migrate 'Metrics' lib to TypeScript #27022
• [NoQA] Copy category over from expense when Editing a Money Request #27055
• Fix scroll to bottom when number of waypoints increases don't work properly #27076
• Fix: Request Money/Scan: Validation messages are not translated to Spanish #27089
• Fix: Web -Workspace - Inconsistency in Workspace Notification for HTML Cha… #27091
• [No QA] [TS migration] Migrate 'CurrentDate.js' lib to TypeScript #27116
• Edit margin of green tick icon #27129
• Update Onyx to use a map for Onyx collection keys  #27130
• [No QA] [TS Migration] TwoFactorAuthActions lib #27132
• Add ability to request money from iou and expense report #27133
• fix: don't focus on composer when open right modal #27155
• Fix: Incorrect tooltip position when hovering over email #27171
• fix duplicated IOU report #27194
• fix DM disappears after open IOU report #27197
• [No QA] Fix deploy checklist #27209
• Hide settle button when the request is canceled #27212
• Use correct app icon colour bg for notifications #27213
• [No QA] Make dummy markdown change for test CP #27215
• [CP Stag] Return early if the value is empty or non-string #27217
• Display "Receipt missing details" title when needed #27218
• fix: use more specific popover anchor #27231
• [No QA] [TS Migration] Migrate 'Browser' lib to TypeScript #27233
• Fix mark as unread in LHN #27245
• [No QA][TS migration] Migrate 'addEncryptedAuthTokenToURL.js' lib to TypeScript #27248
• fix(pronouns): unselect item #27256
• Fix: Select all checkbox is not aligned with member checkboxes #27264
• [CP Staging] fix: 26824 Unread messages get marked as read without me visiting the chats #27270
• Fix: Cannot edit policy expense request in offline mode #27285
• Fix: App loses focus on money request participant selector's text input #27294
• Revert "26121-remove-domain-name" #27300
• Revert "Fix: Keyboard shouldn't be active/enabled automatically for request details" #27301
• The toggle attribution button is not placed on the right position for android #27302
• [No QA][TS migration] Improve translations: keep translations in sync #27310
• [No QA][TS migration] Improve translations: keep translations in sync #27322
• Feat: Re-structure theme styles and simplify ThemeStylesProvider #27324
• [Snyk] Security upgrade electron from 25.8.0 to 25.8.1 #27360
• Revert "Convert SearchPage to functional component" #27476
• [NO QA] Revert PR 24588 #27504
• Revert "Add focus trap to the RHP" #27559
• fix infinite loading after first opening personal details page #27647

Deploy Blockers:

• [$500] [HOLD for payment 2023-09-04] Cleared Statement Reappears Briefly When Deleting Comment Changes #25690
• IOU - Tapping on tag , menu picker does not appear and unable to select tag #27444
• [HOLD for payment 2023-09-27] mWeb/safari- Transition is not smooth when search page opened #27457
• Split bill - IOU preview in 1:1 DM is blank with undefined username when bill is split offline #27467
• [HOLD for payment 2023-09-27] Web - search field or new group field remain focused after CTRL + K, CTRL + J or CTRL + SHIFT + K, CTRL + J #27516
• [$500] [HOLD for payment 2023-09-27] Web – 2FA – App with 2FA installed crashes when trying to access 2FA menu #27519
• [$500] [HOLD for payment 2023-09-27] Android - Infinite loading after opening personal details page #27560

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.70-2 🚀

[kavimuru]

Checking off PRs deployed in past builds
#26221
#26394
#26385
#26452
#26415
#26501
#26634
#26671
#26673
#26687
#26692
#26783
#26784
#26809
#26846
#26874
#26932
#27001
#27008
#27076
#27089
#27130
#27155
#27197
#27212
#27213
#27218
#25846
#24564
#25528
#25908
#26140
#26662
#26808
#26810
#26826
#26974
#27091
#27129
#27217
#27245
#27256
#27300
#27301
#25991
#26073
#26172

[kavimuru]

@mountiny Still desktop build is not available (version 1.3.70-2). Getting a notification "update available", nothing happens clicking on it.

[mountiny]

cc @AndrewGable I am off to bed

[Julesssss]

Hi @kavimuru, I mentioned a workaround here. But Within the next few minutes a new build should appear with the fix for the missing Desktop build 🤞

[Julesssss]

Checking off #27504

Desktop builds should now be available again!

[mvtglobally]

@mountiny Regression is 9% left. We just have IOS 17 slots outstanding

Blockers
#27457
#27516
#27519

Unchecked PRs
#26850 is failing #27447 repro in PROD checking off
#26954 is failing #27444
#26806 is blocked #19915 (comment). repro in PROD

[kavimuru]

@Julesssss Regression is 5% left. We are working on last iOS 17 beta slot.

Blockers :
#27457
#27516
#27519
#27560

Unchecked PRs:
#26850 is failing #27447 repro in PROD checking off
#26954 is failing #27444
#26806 is blocked #19915 (comment). repro in PROD

[kavimuru]

@mountiny Regression completed

Blockers :
#27457
#27516
#27519
#27560

Unchecked PRs:
#26850 is failing #27447 repro in PROD checking off
#26954 is failing #27444
#26806 is blocked #19915 (comment). repro in PROD

[amyevans]

Checked off #27457 as a revert PR is being cherry picked

[thienlnam]

Checked off #27519 and #27519 due to the revert PR #27559

[thienlnam]