Add /workspaces/* path into universal_link #26172

studentofcoding · 2023-08-29T11:05:02Z

Details

The problem is only appearing on Safari Mobile, with the detail of

Workspaces - Visual flickering when navigating back to workspace list from a WS

Some extra note:

The scope is on Workspace related page, but we also include /save-the-world/* which is outside of the scope of the issues
The Screenshots are Expected results to be (on mobile safari section) since the Smart App Banner only shows on the production code.
It seems like on the Save the World page, there is a small bug (different background color) on the SafeArea on top, if that is the case, a bug report has already been sent here & just want to note this, to avoid regression after it's merged

Fixed Issues

$ 24341
PROPOSAL: #24341 (comment)

Tests

Open the staging weblink
Go to Settings > Workspaces
Select a workspace to open WS settings
Go back to workspace list by tapping on the back button
See that the Smart App Banner is also shown on Workspace Page Detail and the layout is fixed

Verify that no errors appear in the JS console

Offline tests

Open the staging weblink
Go to Settings > Workspaces
Select a workspace to open WS settings
Go back to workspace list by tapping on the back button
See that the Smart App Banner is also shown on Workspace Page Detail and the layout is fixed

QA Steps

Open the staging weblink
Go to Settings > Workspaces
Select a workspace to open WS settings
Go back to workspace list by tapping on the back button
See that the Smart App Banner is also shown on Workspace Page Detail and the layout is fixed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Workspace

Save the world

Desktop

iOS

Android

melvin-bot · 2023-08-31T18:43:11Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-08-31T18:44:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

allroundexperts · 2023-08-31T23:01:38Z

@studentofcoding How am I supposed to test this on my localhost? Can you please update the test steps?

studentofcoding · 2023-09-01T05:05:59Z

@studentofcoding How am I supposed to test this on my localhost? Can you please update the test steps?

We can't test it locally or on other sites as the Smart App Banner can only be shown on the production/staging site that is listed on associated-domains key in Xcode project points to below domains.

<key>com.apple.developer.associated-domains</key>
	<array>
		<string>applinks:new.expensify.com</string>
		<string>applinks:staging.new.expensify.com</string>
		<string>webcredentials:new.expensify.com</string>
	</array>

But we can expect it'll behave the same as another path as it's using the same structure, and no other changes are introduced in this case

Anyway Thanks @aswin-s for the detailed explanation

studentofcoding · 2023-09-01T17:11:42Z

Leave the note here for additional context

The PR are planned to be merged on Sept 1 (after 1 day) but on Hold because of freeze

So after disscusion with Internal Team, it'll have a bonus of 50%

Below are the discussion on slack for context

dangrous · 2023-09-05T15:11:42Z

I'm updating the reviewers on this, not sure why it didn't pick us properly. Ignore this issue, @youssef-lr !

dangrous

Two edits on the comments!

Do we know of a way to actually test this? Now that we can make different test builds would any of those work, maybe? cc @Julesssss since you worked on the test builds thing

.well-known/apple-app-site-association

Change comment on Workspace Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

Change comment on Save the World Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

studentofcoding · 2023-09-06T15:28:26Z

Two edits on the comments!

Do we know of a way to actually test this? Now that we can make different test builds would any of those work, maybe? cc @Julesssss since you worked on the test builds thing

Done it @dangrous, also This is our last discussion with Aswin on apple-app-site-association

https://expensify.slack.com/archives/C01GTK53T8Q/p1693544190232139?thread_ts=1693543888.454649&cid=C01GTK53T8Q

Julesssss · 2023-09-06T15:29:46Z

Do we know of a way to actually test this? Now that we can make different test builds would any of those work, maybe? cc @Julesssss since you worked on the test builds thing

I kicked off a test build job for you here. A comment should appear shortly with links to all platforms

studentofcoding · 2023-09-06T17:25:53Z

iOS build failed @Julesssss @dangrous (probably because the Branch isn't synced as Master Branch)

Also upon checking on my iPhone for the web, the Smart App Banner didn't show on all the pages, it's probably related to how it only loads on the listed URL here :

I might be wrong (as my context in this matter is limited) but it seems that the only alternative way to test this is to change https://new.expensify.com/apple-app-site-association and add our URL there, therefore it'll only be testable later on production?

dangrous · 2023-09-07T14:40:18Z

Ah okay. I thinkkkk it'll probably be fine? It's definitely not going to break anything, the question is whether or not it will actually work once deployed, haha. So maybe we just push (when the freeze is off) with prod QA, and handle any issues at that point.

studentofcoding · 2023-09-07T17:30:00Z

Ah okay. I thinkkkk it'll probably be fine? It's definitely not going to break anything, the question is whether or not it will actually work once deployed, haha. So maybe we just push (when the freeze is off) with prod QA, and handle any issues at that point.

Yess, I also think that it'll finee. This is actually intriguing as we only can make sure after its being deployed later lol

Meanwhile, I'll re-check and add another configuration (if needed)

studentofcoding · 2023-09-11T04:00:57Z

As the conferences are done, I think its safe to continue @mountiny ?

Also waiting for your approval @allroundexperts

Thanks!

studentofcoding · 2023-09-11T05:07:37Z

Also Do I need to merge main to this PR branch @dangrous

mountiny · 2023-09-11T08:34:36Z

@studentofcoding yes please, merge main and retest please. Thanks!

studentofcoding · 2023-09-11T10:50:41Z

Main is merged @dangrous @allroundexperts, It's ready to be merged to main & tested there!

studentofcoding · 2023-09-11T15:01:55Z

Can we remove the HOLD merge freeze @mountiny ? Thanks

dangrous · 2023-09-11T15:05:28Z

I think this is good to go, I'm just checking to see what the process is for having this tested on prod instead of on staging

studentofcoding · 2023-09-11T15:21:43Z

I think this is good to go, I'm just checking to see what the process is for having this tested on prod instead of on staging

Noted, I'll standby in case any extra conf needed from my part

allroundexperts

Let's 🚀 it!

melvin-bot · 2023-09-11T22:52:44Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #27205.

studentofcoding · 2023-09-12T02:12:22Z

Lets merged itt!

cc: @dangrous @allroundexperts

OSBotify · 2023-09-12T15:09:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-13T09:14:05Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:28:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:55:22Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-09-14T12:00:23Z

@dangrous @studentofcoding We tested in staging in the last regression. Should we validate in production in this list?
#27313 (comment)

dangrous · 2023-09-14T19:28:48Z

yes please!

studentofcoding · 2023-09-14T19:41:05Z

Also added additional context here @dangrous @kavimuru as Smart App Banner is showing fine on Staging while on Production it isn't, and this is my hunch on it

My hunch is this behavior is happening because the Production still didn't have the last updated change from Staging, which is the change from internal PR below (that basically change /save-the-world/* into /teachersunite/* that make the Smart App Banner didn't behave as expected

I've poked Aswin as well, hopefully we can get more insight on it 😄

OSBotify · 2023-09-18T10:13:21Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

studentofcoding added 3 commits August 29, 2023 18:00

Add /workspaces/* path into universal_link

2532feb

Merge branch 'main' into Fix-flickering-on-workspace-detail-page

e441cc6

Add Teachers related page

e3840d5

studentofcoding marked this pull request as ready for review August 31, 2023 18:42

studentofcoding requested a review from a team as a code owner August 31, 2023 18:42

melvin-bot bot requested review from youssef-lr and removed request for a team August 31, 2023 18:43

studentofcoding mentioned this pull request Aug 31, 2023

Payment Sep 25 [$1000] Workspaces - Visual flickering when navigating back to workspace list from a WS #24341

Closed

6 tasks

mountiny changed the title ~~Add /workspaces/* path into universal_link~~ [HOLD merge freeze] Add /workspaces/* path into universal_link Sep 1, 2023

mountiny assigned studentofcoding Sep 1, 2023

dangrous requested review from dangrous and allroundexperts and removed request for youssef-lr September 5, 2023 15:11

dangrous requested changes Sep 6, 2023

View reviewed changes

.well-known/apple-app-site-association Outdated Show resolved Hide resolved

.well-known/apple-app-site-association Outdated Show resolved Hide resolved

studentofcoding and others added 2 commits September 6, 2023 22:25

Update .well-known/apple-app-site-association

1693afa

Change comment on Workspace Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

Update .well-known/apple-app-site-association

2975d73

Change comment on Save the World Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>

Julesssss added the Ready To Build label Sep 6, 2023

Expensify deleted a comment from OSBotify Sep 7, 2023

dangrous approved these changes Sep 7, 2023

View reviewed changes

Merge branch 'main' into Fix-flickering-on-workspace-detail-page

c952e51

dangrous changed the title ~~[HOLD merge freeze] Add /workspaces/* path into universal_link~~ Add /workspaces/* path into universal_link Sep 11, 2023

allroundexperts approved these changes Sep 11, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Sep 11, 2023

Payment issue for E/App PR#26172 #27205

Closed

dangrous merged commit c0363b7 into Expensify:main Sep 12, 2023
12 checks passed

OSBotify mentioned this pull request Sep 13, 2023

Deploy Checklist: New Expensify 2023-09-13 #27313

Closed

72 tasks

lanitochka17 mentioned this pull request Sep 13, 2023

[$500] mweb/Safari - Settings - Smart App Banner is not shown on the Workspace Page Detail #27345

Closed

6 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

abdulrahuman5196 mentioned this pull request Oct 23, 2023

[$500] mWeb - FAB - Fab button glitches on mWeb Safari #29436

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add /workspaces/* path into universal_link #26172

Add /workspaces/* path into universal_link #26172

studentofcoding commented Aug 29, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

allroundexperts commented Aug 31, 2023 •

edited

Loading

allroundexperts commented Aug 31, 2023

studentofcoding commented Sep 1, 2023 •

edited

Loading

studentofcoding commented Sep 1, 2023 •

edited

Loading

dangrous commented Sep 5, 2023

dangrous left a comment

studentofcoding commented Sep 6, 2023

Julesssss commented Sep 6, 2023 •

edited

Loading

studentofcoding commented Sep 6, 2023 •

edited

Loading

dangrous commented Sep 7, 2023

studentofcoding commented Sep 7, 2023

studentofcoding commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

mountiny commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

dangrous commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

allroundexperts left a comment

melvin-bot bot commented Sep 11, 2023

studentofcoding commented Sep 12, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

kavimuru commented Sep 14, 2023 •

edited

Loading

dangrous commented Sep 14, 2023

studentofcoding commented Sep 14, 2023

OSBotify commented Sep 18, 2023

Add /workspaces/* path into universal_link #26172

Add /workspaces/* path into universal_link #26172

Conversation

studentofcoding commented Aug 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

allroundexperts commented Aug 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Aug 31, 2023

studentofcoding commented Sep 1, 2023 • edited Loading

studentofcoding commented Sep 1, 2023 • edited Loading

dangrous commented Sep 5, 2023

dangrous left a comment

Choose a reason for hiding this comment

studentofcoding commented Sep 6, 2023

Julesssss commented Sep 6, 2023 • edited Loading

studentofcoding commented Sep 6, 2023 • edited Loading

dangrous commented Sep 7, 2023

studentofcoding commented Sep 7, 2023

studentofcoding commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

mountiny commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

dangrous commented Sep 11, 2023

studentofcoding commented Sep 11, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 11, 2023

studentofcoding commented Sep 12, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

kavimuru commented Sep 14, 2023 • edited Loading

dangrous commented Sep 14, 2023

studentofcoding commented Sep 14, 2023

OSBotify commented Sep 18, 2023

studentofcoding commented Aug 29, 2023 •

edited

Loading

allroundexperts commented Aug 31, 2023 •

edited

Loading

studentofcoding commented Sep 1, 2023 •

edited

Loading

studentofcoding commented Sep 1, 2023 •

edited

Loading

Julesssss commented Sep 6, 2023 •

edited

Loading

studentofcoding commented Sep 6, 2023 •

edited

Loading

kavimuru commented Sep 14, 2023 •

edited

Loading