fix(selection-list): focus input on screen focus #26415

thiagobrez · 2023-08-31T17:01:01Z

Details

TextInput was not being focused after coming back from pages, only on first mount.

Refactored the focus logic to always focus the TextInput when the screen is focused
Removed the unnecessary shouldDelayFocus prop, since every list that has a TextInput should delay the focus to after the animation completes, so the animation is not overriden

This is basically a copy of @roryabraham 's Draft PR + removing the unused prop in propTypes and fixing tests.

Fixed Issues

$ #25893
PROPOSAL:

Tests

Verify that no errors appear in the JS console

In all pages listed below, verify this criteria:

When you open the page, input should be focused after animation ends
If the page has the ? help button, press to navigate to the help page, then go back. The input should be focused again
Profile -> Pronouns
Profile -> Timezone
Profile -> Personal Details -> Date of birth -> Year (this is not a common page, it's a Modal, but should work the same)
Workspace -> Members (has ? button)
Workspace -> Members -> Invite (has ? button)

Offline tests

QA Steps

Verify that no errors appear in the JS console

In all pages listed below, verify this criteria:

When you open the page, input should be focused after animation ends
If the page has the ? help button, press to navigate to the help page, then go back. The input should be focused again
Profile -> Pronouns
Profile -> Timezone
Profile -> Personal Details -> Date of birth -> Year (this is not a common page, it's a Modal, but should work the same)
Workspace -> Members (has ? button)
Workspace -> Members -> Invite (has ? button)

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mp4

Desktop

desktop.mov

iOS

ios.native.mp4

Android

android.native.mov

melvin-bot · 2023-08-31T17:01:06Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

src/components/SelectionList/BaseSelectionList.js

melvin-bot · 2023-09-01T09:56:36Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thiagobrez · 2023-09-01T09:58:43Z

Hey @roryabraham here's the follow up to the Draft PR you sent. It's basically the same + a few polishings on propTypes and fixing tests. I left a question for you here, if I can understand what were the issues with your first approach I could maybe try to investigate that road. Thanks!

roryabraham · 2023-09-01T16:08:37Z

Yes @thiagobrez I can explain (original explanation here.

There were a few approaches I tried:

useFocusEffect and InteractionsManager.runAfterInteractions, as suggested in the react-navigation docs here. This does not work because on web InteractionsManager.runAfterInteractions uses requestAnimationFrame, which interrupts the transition animation.
set up a listener for transitionEnd and focus the text input there. This does not work when popping a screen off the stack (for example pressing the back button to go from the workspace invite page to the workspace members list). The reason for this is because transitionEnd only runs for the top card on the stack, as explained by Satya in this comment. This means that when you pop a card off the stack, transitionEnd is not fired for the card that is on top after the transition finishes. I think this is a bit of a weird design as both the top and second-to-top card in the stack are affected by the transition, but the maintainer has rejected a PR to change this in the past.

Santhosh-Sellavel · 2023-09-04T00:43:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-09-04.at.5.55.52.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-09-04.at.6.06.35.AM.mov

iOS

Screen.Recording.2023-09-04.at.6.11.17.AM.mov

Android

Screen.Recording.2023-09-04.at.6.17.02.AM.mov

Santhosh-Sellavel

LGTM tests well!

roryabraham · 2023-09-04T15:22:54Z

Thanks, hoping to merge this as soon as the merge freeze is lifted.

roryabraham · 2023-09-10T17:24:14Z

I think this ready to merge but I want to hold off until after 1 more production deploy to prevent us having an unmanageably huge deploy checklist

roryabraham · 2023-09-12T03:46:31Z

@thiagobrez can you resolve conflicts here?

thiagobrez · 2023-09-12T07:55:22Z

@roryabraham Done!

roryabraham

LGTM, thanks!

OSBotify · 2023-09-12T08:10:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

huzaifa-99 · 2023-09-12T11:13:23Z

src/pages/settings/Profile/PronounsPage.js

Just confirming if this change was intentional? @thiagobrez

Hey @huzaifa-99, yeah it was intentional. The regression came in due to the fact that I wasn't aware that a pronoun could be un-selected. I already sent a comment in the issue

OSBotify · 2023-09-13T09:14:41Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2023-09-14T07:02:28Z

@mvtglobally raised this is failing #25893 on Android, @thiagobrez could you double check?

thiagobrez · 2023-09-14T07:40:08Z

@mountiny Yep, on it

thiagobrez · 2023-09-14T08:01:17Z

@mountiny Works for me on latest main:

Screen.Recording.2023-09-14.at.08.59.11.mov

If you have more info how to reproduce, I can test it again!

OSBotify · 2023-09-14T10:28:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:55:58Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:13:57Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix(selection-list): focus input on screen focus

a3c16e5

chore: fix lint and tests

5e9fcf8

kubabutkiewicz reviewed Sep 1, 2023

View reviewed changes

src/components/SelectionList/BaseSelectionList.js Show resolved Hide resolved

thiagobrez mentioned this pull request Sep 1, 2023

[HOLD for payment 2023-09-21] Web - Input field not focused on click of back button from Get assistance page #25893

Closed

6 tasks

thiagobrez marked this pull request as ready for review September 1, 2023 09:56

thiagobrez requested a review from a team as a code owner September 1, 2023 09:56

melvin-bot bot removed the request for review from a team September 1, 2023 09:56

melvin-bot bot requested a review from Santhosh-Sellavel September 1, 2023 09:56

roryabraham approved these changes Sep 1, 2023

View reviewed changes

roryabraham mentioned this pull request Sep 1, 2023

[Tracker] Selection List Refactor #11795

Closed

Santhosh-Sellavel approved these changes Sep 4, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham September 4, 2023 00:48

roryabraham mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-10-09] [$1000] The transition animation doesn't work for the request money page #22388

Closed

6 tasks

roryabraham previously approved these changes Sep 4, 2023

View reviewed changes

thiagobrez mentioned this pull request Sep 5, 2023

[HOLD #11795][$1000] No transition animation on timezone selector #24139

Closed

6 tasks

thiagobrez added 2 commits September 12, 2023 08:42

chore: resolve conflicts

db007e0

chore: fix lint

13ed92c

thiagobrez dismissed roryabraham’s stale review via 13ed92c September 12, 2023 07:54

thiagobrez requested a review from roryabraham September 12, 2023 07:55

roryabraham approved these changes Sep 12, 2023

View reviewed changes

roryabraham merged commit a365583 into Expensify:main Sep 12, 2023
12 checks passed

huzaifa-99 reviewed Sep 12, 2023

View reviewed changes

Ollyws mentioned this pull request Sep 12, 2023

Fix Pronouns loses focus on coming back from new group page or search page #27147

Closed

59 tasks

OSBotify mentioned this pull request Sep 13, 2023

Deploy Checklist: New Expensify 2023-09-13 #27313

Closed

72 tasks

roryabraham mentioned this pull request Sep 14, 2023

[HOLD for payment 2023-09-06] [$1000] No animation for Members and Invite Members page #25860

Closed

6 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

dukenv0307 mentioned this pull request Sep 14, 2023

[HOLD for payment 2023-10-12] [$500] Web - Members page search bar does not get focused after removing and inviting a member #26955

Closed

6 tasks

Ollyws mentioned this pull request Sep 15, 2023

[$500] Pronouns loses focus on coming back from new group page or search page #26350

Closed

6 tasks

filip-solecki mentioned this pull request May 17, 2024

CRITICAL: Desktop - Chat Switcher is slow and doesn't recognize keystrokes #28071

Closed

6 tasks

filip-solecki mentioned this pull request Jun 7, 2024

Fix Slow Chat Switcher issue #43099

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(selection-list): focus input on screen focus #26415

fix(selection-list): focus input on screen focus #26415

thiagobrez commented Aug 31, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Sep 1, 2023

thiagobrez commented Sep 1, 2023

roryabraham commented Sep 1, 2023 •

edited

Loading

Santhosh-Sellavel commented Sep 4, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

roryabraham commented Sep 4, 2023

roryabraham commented Sep 10, 2023

roryabraham commented Sep 12, 2023

thiagobrez commented Sep 12, 2023

roryabraham left a comment

OSBotify commented Sep 12, 2023

huzaifa-99 Sep 12, 2023 •

edited

Loading

thiagobrez Sep 12, 2023

huzaifa-99 Sep 12, 2023

OSBotify commented Sep 13, 2023

mountiny commented Sep 14, 2023

thiagobrez commented Sep 14, 2023

thiagobrez commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

fix(selection-list): focus input on screen focus #26415

fix(selection-list): focus input on screen focus #26415

Conversation

thiagobrez commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Sep 1, 2023

thiagobrez commented Sep 1, 2023

roryabraham commented Sep 1, 2023 • edited Loading

Santhosh-Sellavel commented Sep 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

roryabraham commented Sep 4, 2023

roryabraham commented Sep 10, 2023

roryabraham commented Sep 12, 2023

thiagobrez commented Sep 12, 2023

roryabraham left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 12, 2023

huzaifa-99 Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

thiagobrez Sep 12, 2023

Choose a reason for hiding this comment

huzaifa-99 Sep 12, 2023

Choose a reason for hiding this comment

OSBotify commented Sep 13, 2023

mountiny commented Sep 14, 2023

thiagobrez commented Sep 14, 2023

thiagobrez commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

thiagobrez commented Aug 31, 2023 •

edited

Loading

roryabraham commented Sep 1, 2023 •

edited

Loading

Santhosh-Sellavel commented Sep 4, 2023 •

edited

Loading

huzaifa-99 Sep 12, 2023 •

edited

Loading