[$500] Pronouns loses focus on coming back from new group page or search page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->profile->pronouns
3. Open new group page or search page using keyboard shortcut
4. Go back

Expected Result:

App should not lose focus on coming back to pronouns page

Actual Result:

App loses focus on coming back to pronouns page from new group page or search page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

app.loses.focus.from.pronouns.on.coming.back.to.that.page.mp4

Recording.1543.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692636606892199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c665e819f5153b8
• Upwork Job ID: 1698565526817005568
• Last Price Increase: 2023-09-04
• Automatic offers:
• Ollyws | Reviewer | 26511522
• hoangzinh | Contributor | 26511523
• dhanashree-sawant | Reporter | 26511526

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pronouns loses focus on coming back from new group page or search page

What is the root cause of that problem?

In the PronounsPage component, we're using SelectionList component to render selection, and in SelectionList component, it only focuses on the search input when component is mounted

App/src/components/SelectionList/BaseSelectionList.js

Lines 269 to 285 in 1b63c76

	/** Focuses the text input when the component mounts. If `props.shouldDelayFocus` is true, we wait for the animation to finish */
	useEffect(() => {
	if (shouldShowTextInput) {
	if (shouldDelayFocus) {
	focusTimeoutRef.current = setTimeout(() => textInputRef.current.focus(), CONST.ANIMATED_TRANSITION);
	} else {
	textInputRef.current.focus();
	}
	}
	return () => {
	if (!focusTimeoutRef.current) {
	return;
	}
	clearTimeout(focusTimeoutRef.current);
	};
	}, [shouldDelayFocus, shouldShowTextInput]);

We don't have any logic to refocus on the search input when the component/page refocus

What changes do you think we should make in order to solve the problem?

In BaseSelectionList, we need to hook into Navigation focus (by using either useIsFocused hook or withNavigationFocus HOC), then we will add it into dependency list of above useEffect (and checking if it's true in the above useEffect as well). It will help to trigger refocus on the search input when the component is focus/refocus.

[sophiepintoraetz]

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c665e819f5153b8

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

@hoangzinh's proposal looks good to me.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

🟢 for that proposal.

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@tgolen, @hoangzinh, @Ollyws, @sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...

[Ollyws]

Not overdue, waiting for the PR.

[hoangzinh]

sorry, I missed the notification. I will make the PR within today

[hoangzinh]

@Ollyws @tgolen Thanks for accepting my proposal. The PR is ready here #27147. Please help me review it. Thanks

[Ollyws]

@sophiepintoraetz We closed the PR as the issue was fixed by #26415 while we were working on it.

[sophiepintoraetz]

Got it - and it was reported earlier here - I think this issue is essentially a dupe. Apologies for not catching this earlier and thanks for the efforts involved so far!

[Ollyws]

@sophiepintoraetz I think according to section 19 of the process doc, in this situation payment is due for the C+ and contributor. Thanks.

[hoangzinh]

@sophiepintoraetz the issue #25893 has been paid and closed.

[sophiepintoraetz]

Cool - olly is paid - reclosing!

[hoangzinh]

@sophiepintoraetz I think according to section 19 of the process doc, in this situation payment is due for the C+ and contributor. Thanks.

@sophiepintoraetz I haven't received the payment as a Contributor yet. Could you help to check? Thanks

[hoangzinh]

@sophiepintoraetz Could you check my comment above? Thanks

[sophiepintoraetz]

You're all set, @hoangzinh.

[hoangzinh]

Thanks @sophiepintoraetz