Implement new layout for SecurityPage #26784

hungvu193 · 2023-09-05T14:17:17Z

Details

Implement new layout for SecurityPage

Fixed Issues

$ #26775
PROPOSAL: #26775 (comment)

Tests

Go to Settings => Security
Verify that it matches the design.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Go to Settings => Security
Verify that it matches the design.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-05.at.21.23.21.mov

Mobile Web - Chrome

RPReplay_Final1693926508.MP4

Mobile Web - Safari

Screen.Recording.2023-09-05.at.22.05.02.mov

Desktop

Screen.Recording.2023-09-05.at.22.03.08.mov

iOS

Screen.Recording.2023-09-05.at.22.09.34.mov

Android

Screen.Recording.2023-09-05.at.22.56.17.mov

melvin-bot · 2023-09-05T15:59:55Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-09-05T16:00:33Z

@narefyev91 PR is ready for review! Please have a look. Ty 😄

narefyev91 · 2023-09-06T10:50:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

roryabraham · 2023-09-06T11:46:14Z

Thanks, HOLDing this PR due to the ongoing merge freeze. Will likely review + merge on Monday

roryabraham

lol, this layout is not right:

Expected	Actual

roryabraham · 2023-09-11T01:38:43Z

Maybe it's actually a problem with the lottie animation itself though (not being the right aspect ratio)

hungvu193 · 2023-09-11T01:39:53Z

@roryabraham yeah I think that's issue with the height of lottie file, do we have a max height for it?

roryabraham · 2023-09-11T03:31:33Z

Safe.json.zip

Try this one. had to briefly learn how to use AfterEffects so hopefully it works. 😅 Looks good in the LottieFiles preview

roryabraham · 2023-09-11T04:20:10Z

Can you also merge main into your branch please?

hungvu193 · 2023-09-11T06:43:08Z

Can you also merge main into your branch please?

Sure

hungvu193 · 2023-09-11T07:48:50Z

Looks much better 😄 , merged with main as well @roryabraham

update lottie file

roryabraham · 2023-09-11T08:37:05Z

Comparing to the mockup, the safe takes up a bit more space than in the mockup, but I think it looks ok.

Expected	Actual

Also compared to another page to make sure the colorful top half is taking up the same height:

Security	Workspaces

ios.mov

roryabraham · 2023-09-11T08:38:24Z

@shawnborton will you take a look at this and make sure it's satisfactory? If not let me know and I can adjust the lottie animation to zoom it out a bit so it's a bit smaller within the same size bounding box

shawnborton · 2023-09-11T14:57:08Z

This feels pretty good to me, but when you scale things, I'm curious if you are keeping the stroke width at 1px? For example, the stroke widths look different between the safe and the planet. Ideally both should have consistent 1px strokes for everything.

BTW how are you opening lottie files in After Effects? I would love to take a look at them this way too.

roryabraham · 2023-09-12T02:56:50Z

BTW how are you opening lottie files in After Effects?

Happy to show you! You have to install the bodymovin plugin

roryabraham

ok, I don't have the 🦅 👀 of @shawnborton but I've done my best to verify in AE that we have 1px stroke everywhere. For now I think I'm going to merge this and if we want to swap out the asset that should be easy for a non-engineer to do later. Hoping this is good enough for now

Edit: Disclaimer – I don't actually know what I'm doing w/ AE and I think it might take me too long to upskill enough to be able to actually adjust anything with the animation quickly – I found a very specific YouTube tutorial which told me how to adjust the bounding box, but beyond that I'm a bit out of my depth

OSBotify · 2023-09-12T03:50:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-13T09:14:59Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2023-09-14T09:45:09Z

@hungvu193 https://expensify.slack.com/archives/C049HHMV9SM/p1694494708815589 It seems it is regression from this PR

hungvu193 · 2023-09-14T10:24:19Z

@hungvu193 https://expensify.slack.com/archives/C049HHMV9SM/p1694494708815589 It seems it is regression from this PR

Thank you @DylanDylann
@roryabraham Since you implemented the WorkspaceListPage, is there any special config that make the page fullscreen in Safari? I checked the layout between these pages and can't see the difference. This issue also happens with SaveTheWorld page.

OSBotify · 2023-09-14T10:29:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:56:19Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:14:18Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mountiny · 2023-10-02T15:16:08Z

src/pages/settings/Security/SecuritySettingsPage.js

+            title={props.translate('initialSettingsPage.security')}
+            onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}
+            shouldShowBackButton
+            shouldShowCloseButton


I see this is in the design file but the Close buttons are deprecated with the new navigation framework so I am going to remove this

hungvu193 force-pushed the feature-26775 branch from 6ce9cd9 to 762e82d Compare September 5, 2023 14:22

hungvu193 marked this pull request as ready for review September 5, 2023 15:59

hungvu193 requested a review from a team as a code owner September 5, 2023 15:59

melvin-bot bot requested review from narefyev91 and removed request for a team September 5, 2023 15:59

narefyev91 approved these changes Sep 6, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham September 6, 2023 10:50

roryabraham requested changes Sep 11, 2023

View reviewed changes

roryabraham mentioned this pull request Sep 11, 2023

[HOLD for payment 2024-01-24] [$500] Implement new layout in About page #26779

Closed

Implement new layout for SecurityPage

898d0f6

update lottie file

hungvu193 force-pushed the feature-26775 branch from cdc05f8 to 898d0f6 Compare September 11, 2023 07:53

roryabraham requested a review from shawnborton September 11, 2023 08:37

roryabraham approved these changes Sep 12, 2023

View reviewed changes

roryabraham merged commit d28b359 into Expensify:main Sep 12, 2023

OSBotify mentioned this pull request Sep 13, 2023

Deploy Checklist: New Expensify 2023-09-13 #27313

Closed

72 tasks

melvin-bot bot mentioned this pull request Sep 14, 2023

[HOLD for payment 2023-09-21] [$500] Implement new layout for SecurityPage #26775

Closed

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

mountiny reviewed Oct 2, 2023

View reviewed changes

burczu mentioned this pull request Dec 1, 2023

[HOLD for payment 2023-11-21] [$500] Security - Status bar color does not match with header #27453

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement new layout for SecurityPage #26784

Implement new layout for SecurityPage #26784

hungvu193 commented Sep 5, 2023 •

edited

Loading

melvin-bot bot commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

narefyev91 commented Sep 6, 2023

narefyev91 left a comment

roryabraham commented Sep 6, 2023

roryabraham left a comment

roryabraham commented Sep 11, 2023 •

edited

Loading

hungvu193 commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

hungvu193 commented Sep 11, 2023

hungvu193 commented Sep 11, 2023 •

edited

Loading

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

shawnborton commented Sep 11, 2023

roryabraham commented Sep 12, 2023

roryabraham left a comment •

edited

Loading

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

DylanDylann commented Sep 14, 2023

hungvu193 commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

mountiny Oct 2, 2023

mountiny Oct 2, 2023

Implement new layout for SecurityPage #26784

Implement new layout for SecurityPage #26784

Conversation

hungvu193 commented Sep 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

narefyev91 commented Sep 6, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

roryabraham commented Sep 6, 2023

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Sep 11, 2023 • edited Loading

hungvu193 commented Sep 11, 2023

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

hungvu193 commented Sep 11, 2023

hungvu193 commented Sep 11, 2023 • edited Loading

roryabraham commented Sep 11, 2023

roryabraham commented Sep 11, 2023

shawnborton commented Sep 11, 2023

roryabraham commented Sep 12, 2023

roryabraham left a comment • edited Loading

Choose a reason for hiding this comment

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

DylanDylann commented Sep 14, 2023

hungvu193 commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

mountiny Oct 2, 2023

Choose a reason for hiding this comment

mountiny Oct 2, 2023

Choose a reason for hiding this comment

hungvu193 commented Sep 5, 2023 •

edited

Loading

roryabraham commented Sep 11, 2023 •

edited

Loading

hungvu193 commented Sep 11, 2023 •

edited

Loading

roryabraham left a comment •

edited

Loading