fix close message #26662

namhihi237 · 2023-09-04T13:23:04Z

Details

Update clearReportActionErrors use correct originalReportID

Fixed Issues

$ #23066
PROPOSAL: #23066 (comment)

Tests

Log in to the same account on 2 browsers (or 2 devices)
On browser 1 create a WS
Send any message to the admin room
On browser 2 go to the thread above the message and send any message
Turn off the network and delete the parent message on the thread
On browser 1 delete WS
On browser 2 back online, go to the above thread message, and see the error
Verify that can click the close button and the error message disappear

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

The same test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

and.mov

melvin-bot · 2023-09-04T14:27:17Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

namhihi237 · 2023-09-04T14:28:30Z

@abdulrahuman5196 @mountiny The PR already review.

mountiny · 2023-09-04T15:36:44Z

@abdulrahuman5196 can you prioritize this PR by any chance? Thank you very much! 🙇

abdulrahuman5196 · 2023-09-04T16:01:12Z

@abdulrahuman5196 can you prioritize this PR by any chance? Thank you very much! 🙇

@mountiny Yes. I am planning to test it out tomorrow morning. Code looks fine.

But this PR won't move through merge freeze right? If this PR is something urgent, I can re-shuffle and review it sooner.

mountiny · 2023-09-04T17:03:00Z

I actually think this could go through the merge freeze, I have found that clearing the error just to get it back after going back to the report is really bad ux so I would prefer to prioritize this one

abdulrahuman5196 · 2023-09-04T17:43:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-04.at.10.51.36.PM.mp4

Screen.Recording.2023-09-04.at.11.19.04.PM.mov

Mobile Web - Chrome

az_recorder_20230904_225913.mp4

az_recorder_20230904_232623.mp4

Mobile Web - Safari

Untitled.mp4

Desktop

Screen.Recording.2023-09-04.at.11.07.47.PM.mp4

Screen.Recording.2023-09-04.at.11.34.17.PM.mp4

iOS

Screen.Recording.2023-09-04.at.11.04.11.PM.mp4

Screen.Recording.2023-09-04.at.11.29.09.PM.mp4

Android

Screen.Recording.2023-09-04.at.11.05.25.PM.mp4

Screen.Recording.2023-09-04.at.11.30.56.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2023-09-04T18:14:13Z

NAB: @namhihi237 Kindly mark "Offline tests" as N/A on the author's checklist

namhihi237 · 2023-09-04T18:15:54Z

Updated @abdulrahuman5196

mountiny · 2023-09-05T09:45:17Z

Appreacite the urgency on this one, I have gone back to Slack to discuss with the team and while this is valuable addition its actually not that common to get these errors in produciton so nobody found this issue, hence its not critical and we wont merge this so we dont distract from the main goals

namhihi237 · 2023-09-05T09:48:31Z

@mountiny I have a question for the PRs that are held merged eligible to receive urgency bonuses or not? Thanks

mountiny · 2023-09-06T10:20:05Z

I have a question for the PRs that are held merged eligible to receive urgency bonuses or not? Thanks

it was discussed in slack, but this time around we are going to not consider bonuses or penalties, its easier and this was the information at the beginning so its the most fair, you can focus on more prs at the same time, until monday the bonuses are not important

abdulrahuman5196 · 2023-09-11T18:28:17Z

@namhihi237 Could you do a merge from main as suggested here https://expensify.slack.com/archives/C01GTK53T8Q/p1694405959277169

namhihi237 · 2023-09-11T18:39:11Z

Merge main and retest work well

Screen.Recording.2023-09-12.at.01.37.28.mov

abdulrahuman5196 · 2023-09-11T19:11:49Z

I did re-test after merge from main.

Changes looks good and works well.

All yours. @mountiny Good to merge.

🎀 👀 🎀
C+ Reviewed

mountiny

Thanks!

OSBotify · 2023-09-12T03:11:13Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.68-7 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:41:49Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:56:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:14:45Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix close message

337aede

namhihi237 marked this pull request as ready for review September 4, 2023 14:27

namhihi237 requested a review from a team as a code owner September 4, 2023 14:27

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team September 4, 2023 14:27

mountiny assigned namhihi237 Sep 4, 2023

abdulrahuman5196 approved these changes Sep 4, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny September 4, 2023 18:12

mountiny changed the title ~~fix close message~~ [HOLD freeze] fix close message Sep 5, 2023

Merge branch 'main' into fix-23066-close-message-error

794d222

mountiny changed the title ~~[HOLD freeze] fix close message~~ fix close message Sep 12, 2023

mountiny approved these changes Sep 12, 2023

View reviewed changes

mountiny merged commit 4537100 into Expensify:main Sep 12, 2023
13 checks passed

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

melvin-bot bot mentioned this pull request Sep 13, 2023

[HOLD for payment 2023-09-20] [$1000] Web - Close message error button can be clicked but nothing happens #23066

Closed

6 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix close message #26662

fix close message #26662

namhihi237 commented Sep 4, 2023 •

edited

Loading

melvin-bot bot commented Sep 4, 2023

namhihi237 commented Sep 4, 2023

mountiny commented Sep 4, 2023

abdulrahuman5196 commented Sep 4, 2023

mountiny commented Sep 4, 2023

abdulrahuman5196 commented Sep 4, 2023 •

edited

Loading

abdulrahuman5196 left a comment

abdulrahuman5196 commented Sep 4, 2023

namhihi237 commented Sep 4, 2023

mountiny commented Sep 5, 2023

namhihi237 commented Sep 5, 2023 •

edited

Loading

mountiny commented Sep 6, 2023

abdulrahuman5196 commented Sep 11, 2023

namhihi237 commented Sep 11, 2023

abdulrahuman5196 commented Sep 11, 2023

mountiny left a comment

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

fix close message #26662

fix close message #26662

Conversation

namhihi237 commented Sep 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 4, 2023

namhihi237 commented Sep 4, 2023

mountiny commented Sep 4, 2023

abdulrahuman5196 commented Sep 4, 2023

mountiny commented Sep 4, 2023

abdulrahuman5196 commented Sep 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Sep 4, 2023

namhihi237 commented Sep 4, 2023

mountiny commented Sep 5, 2023

namhihi237 commented Sep 5, 2023 • edited Loading

mountiny commented Sep 6, 2023

abdulrahuman5196 commented Sep 11, 2023

namhihi237 commented Sep 11, 2023

abdulrahuman5196 commented Sep 11, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

namhihi237 commented Sep 4, 2023 •

edited

Loading

abdulrahuman5196 commented Sep 4, 2023 •

edited

Loading

namhihi237 commented Sep 5, 2023 •

edited

Loading