Deploy Checklist: New Expensify 2023-09-12

[OSBotify]

Release Version: 1.3.68-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Rename Card-Rev-Share-for-Approved-Partners.md to Card-Revenue-Share-… #24245
• Apply Onyx updates in an ordered fashion #25455
• [No QA][TS migration] Migrate 'Url.js' constants dependency to TypeScript #25744
• [No QA][TS migration] Migrate 'ROUTES.js' constant to TypeScript #25748
• [No QA] [TS migration] Migrate 'spacing.js' style to TypeScript #25829
• Fix scroll when opening the currency selector page #25835
• fix: maintain consistent topbar colour on login #25908
• [TS migration] Migrate 'getTooltipStyles.js' style to TypeScript #26062
• 25714 stop using report participants #26102
• [No QA][TS migration] Migrate 'hashCode.js' lib to TypeScript #26106
• clear callbacks when closing the account #26119
• https://github.com/Expensify/App/pull/26140
• [No QA] [TS migration] Migrate 'shouldRenderOffscreen' lib to TypeScript #26158
• fix(pronouns-page): pronouns displayed without search #26192
• Fix different grayness levels on parent and child message #26213
• Fix: Prevent clearing server error on blur #26225
• [No QA] add support for device selection when running ios #26230
• Display not found page with invalid field edit #26269
• [24321] Large amounts are no longer cut off on smaller widths. #26280
• Fix the composer being hidden by the keyboard by subscribing to top most report changes in ReportScreen #26283
• Show header in profile pages when personal details are loading #26346
• Fix/25636: Incorrect when inviting existing member #26364
• Translate the MODIFIEDEXPENSE messages #26370
• Android App Notification Logo Update #26381
• [No QA] [TS migration] Migrate 'isInputAutoFilled.js' lib to TypeScript #26473
• Emoji Suggestions Adjustments + Remove Duplicates #26507
• Fix deleting parent thread message temporary disappearing #26548
• 26121-remove-domain-name #26638
• [No QA] [TS migration] Migrate 'Timers.js' lib to TypeScript #26639
• [No QA] [TS migration] Migrate 'RoomNameInputUtils.js' lib to TypeScript #26640
• fix delay showing Notfound page #26658
• fix close message #26662
• [TS migration] Migrate 'canFocusInputOnScreenFocus' lib to TypeScript #26675
• Resolve stuck hover due to the mouse leave event not triggered. #26690
• Checking ToS box before filling fields throws error in mweb but not in android app #26699
• fix: sort valid waypoints #26705
• Refactor reportAction of context menu #26741
• fix: pressing enter doesn't open the selected option page #26743
• fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745
• [TS migration] Migrate 'GooglePlacesUtils.js' lib to TypeScript #26750
• Fix: Thread - No space between message and compose box when sender leave thread #26770
• chore: migrate SettlementButton.js class to function component #26794
• [TS migration] Migrate 'RequestThrottle.js' lib to TypeScript #24807 #26808
• fix no subtitle in IOU header when offline #26823
• fix composer focusing for popups #26826
• Fix money request getting paid on selecting emoji with 'enter' #26840
• Implement localization for ContextMenu options #26841
• Fix composer invisible text covered up the chat/report screen #26847
• fix: 25709 drop container does not add opacity to entire height of the drawer #26849
• Fix Deeplinks except chat reports are not working on web #26856
• fix share code avatar differs from profile avatar #26858
• [No QA] [TS migration] Migrate 'NumberUtils.js' lib to TypeScript #26864
• [TS migration] Migrate 'ReportActionComposeFocusManager.js' lib to TypeScript #26868
• [No QA][TS migration] Migrate 'ControlSelection' lib to TypeScript #26870
• import moment for es locale #26902
• feat: index emoji name parts #26910
• [NO QA] Add policyRecentlyUsedCategories_ as collection key #26920
• fix(task-pages): Force task page editions only for task reports #26924
• 26222: Fix padding jump when isComposerFullSize #26926
• Fix: Keyboard shouldn't be active/enabled automatically for request details #26964
• [TS migration] Migrate 'Receipt.js' lib to TypeScript #26965
• [Snyk] Security upgrade electron from 25.4.0 to 25.5.0 #26967
• [TS migration] Migrate 'Composer.js' lib to TypeScript #26974
• Remove optimistic parent report action when adding system message #26976
• [NO QA] Fix: Dev: console error if we open RHN page directly  #26980
• fix-margin-top-server-error-message #26981
• fix css height not working for onfido #26983
• [CP Staging] iPad layout fix (by forcing narrow layout) #27004
• [No QA] Adjust Github lint workflow name  #27005
• Update the paid message to use same language as the button #27006
• [NO QA] Update reference to deprecated provisioning profile #27007
• [No QA][TS migration] Migrate 'AppUpdate.js' lib to TypeScript #27013
• fix: android app - expand icon doesn't disappear immediately after sending the message #27015
• [CP Staging] [NoQA] Require full screen for iOS #27016
• [TS migration] Migrate 'Trie' lib to TypeScript #27019
• Fix: Web -Workspace - Inconsistency in Workspace Notification for HTML Cha… #27091
• [Snyk] Security upgrade electron from 25.4.0 to 25.8.0 #27096
• [No QA] Add CocoaPods caching to speed up iOS builds  #27102
• Fix Auto navigation back to user contacts when magic code is incorrect full filled and network is offline then online-  #27112
• [NO QA] Changing types to accept both number and string on TS #27121
• [NO QA] Add new property to Transaction Typescript definiton #27122
• Kill SaaStr & SBE demo flows #27124
• Edit margin of green tick icon #27129
• [No QA] [TS Migration] TwoFactorAuthActions lib #27132
• [NoQA] [TS migration] Update to ROUTES.ts #27135
• Update strikethrough replace rule to fix multiple tilde error #27169
• Revert "Android App Notification Logo Update" #27177
• [No QA] Fix deploy checklist #27209
• [No QA] Make dummy markdown change for test CP #27215
• [CP Stag] Return early if the value is empty or non-string #27217
• Fix mark as unread in LHN #27245
• fix(pronouns): unselect item #27256
• Revert "26121-remove-domain-name" #27300
• Revert "Fix: Keyboard shouldn't be active/enabled automatically for request details" #27301

Internal QA:

• [NO QA] Update checklist for cherry-picked PRs #26295 - @roryabraham

Deploy Blockers:

• [HOLD for payment 2023-09-20] Android - The updated Expensify logo has no background on Android notification #27145
• [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] Web - Bank account - App crashes when checking ToS checkbox and Continue CTA is not working #27234
• [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] web - Pronouns - Unable to deselect pronouns once it is selected #27235
• [$500] [HOLD for payment 2023-09-21] [HOLD for payment 2023-09-20] mWeb-LHN- Site crashes while interacting with Pinned and mark as unread menu options #27238
• Web - App crashes when marking report unread in LHN #27239
• Web - Unable to type when popover is open from emoji reaction #27250

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mvtglobally]

Checking off PRs deployed in past builds

#25455
#26102
#26280
#26381
#26507
#26699
#26770
#26840
#26847
#26849
#26856
#26926
#26965
#27004
#27015
#27177

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.68-11 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dangrous]

Checking off #27250 - it's still open but should not be a Deploy Blocker

[francoisl]

Fix for blockers 27238 and 27239 were CP'ed and tested on staging, checking those off.

[kavimuru]

@AndrewGable Regression TR 75% completed
Team retesting these PRs #26225 #26983 #27006 which were blocked by #27234
#26638 is still failing in mweb and native apps #26121
#26964 still failing #26702 in android
#26841 still failing #25704 in web

[Julesssss]

Checking off #27300 which is a revert PR of #26638 -- which I also checked off

[mvtglobally]

Main regression is completed. We are just left with 3 IOS 17 BETA slots. Same steps were tested on non Beta IOS

Current open PRs

#26964 still failing #26702 in android
#27256 iOS validation pending, rest platforms pass
#27245 iOS validation pending, rest platforms pass

[Julesssss]

Checking off #27301 which is a revert of #26964 -- which I also checked off

[mvtglobally]

And this one #26225 (comment)

[Julesssss]

#26964 still failing #26702 in android

✅

#27256 iOS validation pending, rest platforms pass

Verified iOS manually

#27245 iOS validation pending, rest platforms pass

verified iOS manually

And this one #26225 (comment)

Checking off as it's not a blocker and a follow up is already in progress

[Julesssss]

App performance Timing had a spike, but this was deemed an outlier ✅

[Julesssss]

While checking Firebase there were two new tricky-to-decipher native crashes:

• Android -- TypeError: undefined is not a function
  • Slack Discussion
• iOS -- Cannot read property 'toLowerCase' of undefined
  • Slack Discussion

[Julesssss]

Firebase issues cleared. Pre-existing

[Julesssss]

Github status ✅

[Julesssss]