Fix Deeplinks except chat reports are not working on web #26856

hungvu193 · 2023-09-06T08:31:53Z

Details

Fixed Issues

$ #26852
PROPOSAL: #26852 (comment)

Tests

Test RHP deeplink

Log out
Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
Log in
Verify that App navigates to that url after logging in.

Test conference deeplink new account

Log out on web/ mWeb
Go to /sbe route
Sign in with account which is completely new (never used to sign in)
Verify you are deeplinked to a new workspace chat and clicking Up in top left corner navigates you to the LHN

Test conference deeplink existing account

Log out on web/ mWeb
Go to /sbe route
Sign in with the account from previous step (or any other account which already existed)
Verify you are deeplinked to the workspace chat and clicking Up in top left corner navigates you to the LHN

Test Concierge deeplink

Log out
Go to /concierge route
Sign in
Verify you are deeplinked to a concierge chat and clicking Up in top left corner navigates you to the LHN

Test specific chat report deeplink

Log out
Go to /r/ route (some valid for the account)
Sign in
Verify you are deeplinked to that report chat and clicking Up in top left corner navigates you to the LHN (in narrow view)

Test specific chat report deeplink

Log out
Go to /r/ route (some valid for the account)
Sign in
Verify you are deeplinked to that report chat and clicking Up in top left corner navigates you to the LHN (in narrow view)

Test annonymous user claiming their account from public room

Log out
Go to /r/ route where this is a public_announce room which you can access as an anonymous user
Take some action to go to sign in page to claim the account
Sign in
Verify you are correctly signed in and you can see the public chat room in the LHN

Verify that no errors appear in the JS console

Offline tests

This bug is not related to offline mode. No extra steps needed.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-06.at.15.38.55.mov

Mobile Web - Chrome

RPReplay_Final1693989804.MP4

Mobile Web - Safari

RPReplay_Final1693989686.MP4

Desktop

Screen.Recording.2023-09-06.at.15.38.55.mov

iOS

Screen.Recording.2023-09-06.at.16.38.40.mov

Android

Screen.Recording.2023-09-06.at.16.07.13.mov

Only reset root with authenticated route

melvin-bot · 2023-09-06T08:51:09Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-09-06T08:53:05Z

@mountiny @adamgrzybowski PR is ready!

mountiny · 2023-09-06T09:21:21Z

@hungvu193 the ios recording did not redirect anywhere

mountiny · 2023-09-06T09:31:38Z

Updated the tests, could you also please run through them and make sure they work across platfroms? @hungvu193

hungvu193 · 2023-09-06T09:32:19Z

Updated the tests, could you also please run through them and make sure they work across platfroms? @hungvu193

Sure, let me give it a try

parasharrajat · 2023-09-06T09:40:17Z

@hungvu193 Can you please explain the changes to me? Why were we reset the state there and now how has the behavior changed for that effect?

hungvu193 · 2023-09-06T09:45:38Z

@hungvu193 Can you please explain the changes to me? Why were we reset the state there and now how has the behavior changed for that effect?

According the comment here, We need to force state rehydration so the CustomRouter can add the CentralPaneNavigator route if necessary. However, this also accidentally clear the pending route when user tried to login from deeplink, which made the app couldn't navigate to that route after logging in. My PR prevented that happened.

parasharrajat · 2023-09-06T09:56:28Z

It does not give any hint. I am going to test it.

hungvu193 · 2023-09-06T09:57:05Z

@mountiny

From route:

from.route.mov

From sbe:

sbe.mwebmp4.mov

From anonymous user:

anonymous.mov

SAATR:

Screen.Recording.2023-09-06.at.17.20.20.mov

parasharrajat · 2023-09-06T10:22:59Z

~~Found a bug:~~

Can't reproduce it now. May be just a glitch.

Details: Navigating to the Sbe route after you are logged in directly via URL shows you the anonymous report view for the SBE room with all the chats of the logined user.

Login with a user who is not a member of Sbe Rooms.
Now, change the url and use /sbe.
Observe whether it takes you to the Sbe room chat or not.

hungvu193 · 2023-09-06T10:27:30Z

Found a bug:

@parasharrajat can you post it in our conversation in the original issue here? #26852

parasharrajat · 2023-09-06T10:30:19Z

Added details. Probably a glitch but how?

parasharrajat · 2023-09-06T10:35:27Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-09-06.at.4.27.03.PM.mov

Screen.Recording.2023-09-06.at.4.24.21.PM.mov

Screen.Recording.2023-09-06.at.7.06.52.PM.mov

Screen.Recording.2023-09-06.at.7.08.55.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-09-06.at.4.22.54.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-09-08.at.4.09.34.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-09-06.at.4.03.03.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-09-08.at.3.55.07.AM.mov

Screen.Recording.2023-09-08.at.4.11.46.AM.mov

🔲 Android / native

Ignore the error, I accessed an internal link.

Screen.Recording.2023-09-08.at.4.17.45.AM.mov

mountiny · 2023-09-06T10:48:08Z

@hungvu193 @parasharrajat for the concierge, sbe and saastr tests, please also adding theese:

It must be completely new account, which never signed up before
When deeplinked for the first time, try clicking the Up button in to left corner to navigate back to the LHN, this was broken before and fixed recently
Also try with account which already existed

mountiny · 2023-09-06T10:49:28Z

Clarified that in the test steps

parasharrajat · 2023-09-06T11:05:03Z

I am seeing double navigation animation via deeplink on iOS. Checking this on main.

Screen.Recording.2023-09-06.at.4.31.16.PM.mov

hungvu193 · 2023-09-06T11:13:43Z

I am seeing double navigation animation via deeplink on iOS. Checking this on main.

Screen.Recording.2023-09-06.at.4.31.16.PM.mov

@parasharrajat that's existing issue and being addressed here:
#23441

hungvu193 · 2023-09-06T11:18:24Z

@hungvu193 @parasharrajat for the concierge, sbe and saastr tests, please also adding theese:

It must be completely new account, which never signed up before

When deeplinked for the first time, try clicking the Up button in to left corner to navigate back to the LHN, this was broken before and fixed recently

Also try with account which already existed

Verified it's working. I'll be afk for next couple of hours, but can still chat, please tag me if you guys have any questions. Thanks!
Posted video to slack thread:
https://expensify.slack.com/archives/C049HHMV9SM/p1693998649036349

mountiny · 2023-09-06T11:22:07Z

Given this might be a bigger change I prefer to test thoroughly

Julesssss · 2023-09-07T08:16:14Z

Hey @parasharrajat can you please tag me on the Android deep link not working when app killed bug you created please, it's odd but sounds like an issue in the JS logic.

parasharrajat · 2023-09-07T08:29:12Z

I haven't reported it yet. I will do that in 15-20 mins.

parasharrajat · 2023-09-07T09:56:39Z

@mountiny What do you think about that bug #26856 (comment)?

I also reported it on Slack https://expensify.slack.com/archives/C049HHMV9SM/p1694080489810799

mountiny · 2023-09-07T10:01:29Z

@parasharrajat I think thats same as the enable-payments? Does that work in this case? Why would it be different?

parasharrajat · 2023-09-07T10:26:52Z

yes. It is same.

hungvu193 · 2023-09-07T13:41:05Z

I think we can move forward with this PR @mountiny @parasharrajat

parasharrajat · 2023-09-07T15:21:19Z

Yes, Doing the final tests now.

parasharrajat

There is a deep link issue as posted here on Android but the rest is working.

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

mountiny

I believe this is important enough to move through the merge freeze, thanks everyone 🙇

OSBotify · 2023-09-08T09:13:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

hoangzinh · 2023-09-09T16:43:24Z

Hey team, It seems that deeplinks doesn't work in Native app (IOS) in latest main. Just wanna raise if you have same experience

parasharrajat · 2023-09-10T10:59:03Z

@hoangzinh Steps?

hoangzinh · 2023-09-10T14:44:50Z

@parasharrajat The 1st test case in the GH description

Test RHP deeplink

Log out
Go to any app URL (/enable-payments) or /concierge or some other deeplink activated route
Log in
Verify that App navigates to that url after logging in.

Screen.Recording.2023-09-10.at.21.42.16.mp4

parasharrajat · 2023-09-10T15:28:40Z

Sounds like this https://expensify.slack.com/archives/C049HHMV9SM/p1694080489810799

hoangzinh · 2023-09-10T16:44:16Z

Thanks @parasharrajat

OSBotify · 2023-09-11T03:48:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-09-11T20:49:11Z

@hungvu193 desktop is failing with this issue #25790 (comment).

parasharrajat · 2023-09-11T21:01:45Z

@kavimuru that might be intended behaviour #25790 (comment)

kavimuru · 2023-09-11T21:39:19Z

@parasharrajat PR is to test with log out. How should we test this one?

kavimuru · 2023-09-11T21:46:45Z

@parasharrajat This is the video

26856_Desktop.mp4

parasharrajat · 2023-09-11T22:10:03Z

We are trying to test that deep link URLs open the correct page on the app itself. I understand that on desktop, we also show a prompt to natively installed app but that is something out of the scope of this PR/issue. The related bug might be another issue.

Also, in #25790 (comment), It was confirmed that while the user is logged out we don't show the native app prompt for the desktop app.

Let me know if you still have some doubts.

OSBotify · 2023-09-11T23:44:34Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-12T00:19:22Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:45:49Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Update NavigationRoot.js

0063c33

Only reset root with authenticated route

hungvu193 changed the title ~~Update NavigationRoot.js~~ Fix Deeplinks except chat reports are not working on web Sep 6, 2023

hungvu193 marked this pull request as ready for review September 6, 2023 08:51

hungvu193 requested a review from a team as a code owner September 6, 2023 08:51

melvin-bot bot requested review from eVoloshchak and removed request for a team September 6, 2023 08:51

mountiny assigned hungvu193 Sep 6, 2023

mountiny requested review from parasharrajat and mountiny and removed request for eVoloshchak September 6, 2023 09:20

mountiny added the Ready To Build label Sep 6, 2023

parasharrajat approved these changes Sep 7, 2023

View reviewed changes

Julesssss approved these changes Sep 8, 2023

View reviewed changes

mountiny approved these changes Sep 8, 2023

View reviewed changes

mountiny merged commit 7c9fc84 into Expensify:main Sep 8, 2023
14 checks passed

OSBotify mentioned this pull request Sep 11, 2023

Deploy Checklist: New Expensify 2023-09-11 #27120

Closed

31 tasks

kavimuru mentioned this pull request Sep 11, 2023

Web - Log in - Crash when navigating to deeplink .../enable-payments and loging in #27206

Closed

6 tasks

melvin-bot bot mentioned this pull request Sep 11, 2023

[HOLD for payment 2023-09-18] [$1000] Deeplinks except chat reports are not working on web #26852

Closed

6 tasks

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

Fix Deeplinks except chat reports are not working on web #26856

Fix Deeplinks except chat reports are not working on web #26856

Conversation

hungvu193 commented Sep 6, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Test RHP deeplink

Test conference deeplink new account

Test conference deeplink existing account

Test Concierge deeplink

Test specific chat report deeplink

Test specific chat report deeplink

Test annonymous user claiming their account from public room

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2023

hungvu193 commented Sep 6, 2023

mountiny commented Sep 6, 2023

mountiny commented Sep 6, 2023

hungvu193 commented Sep 6, 2023

parasharrajat commented Sep 6, 2023

hungvu193 commented Sep 6, 2023 • edited Loading

parasharrajat commented Sep 6, 2023

hungvu193 commented Sep 6, 2023 • edited Loading

parasharrajat commented Sep 6, 2023 • edited Loading

hungvu193 commented Sep 6, 2023

parasharrajat commented Sep 6, 2023

parasharrajat commented Sep 6, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

mountiny commented Sep 6, 2023

mountiny commented Sep 6, 2023

parasharrajat commented Sep 6, 2023 • edited Loading

hungvu193 commented Sep 6, 2023

hungvu193 commented Sep 6, 2023 • edited Loading

mountiny commented Sep 6, 2023

Julesssss commented Sep 7, 2023

parasharrajat commented Sep 7, 2023

parasharrajat commented Sep 7, 2023 • edited Loading

mountiny commented Sep 7, 2023

parasharrajat commented Sep 7, 2023 • edited Loading

hungvu193 commented Sep 7, 2023

parasharrajat commented Sep 7, 2023

parasharrajat left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 8, 2023

hoangzinh commented Sep 9, 2023

parasharrajat commented Sep 10, 2023

hoangzinh commented Sep 10, 2023

parasharrajat commented Sep 10, 2023

hoangzinh commented Sep 10, 2023

OSBotify commented Sep 11, 2023

kavimuru commented Sep 11, 2023

parasharrajat commented Sep 11, 2023

kavimuru commented Sep 11, 2023

kavimuru commented Sep 11, 2023

parasharrajat commented Sep 11, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

hungvu193 commented Sep 6, 2023 •

edited by mountiny

Loading

hungvu193 commented Sep 6, 2023 •

edited

Loading

hungvu193 commented Sep 6, 2023 •

edited

Loading

parasharrajat commented Sep 6, 2023 •

edited

Loading

parasharrajat commented Sep 6, 2023 •

edited

Loading

parasharrajat commented Sep 6, 2023 •

edited

Loading

hungvu193 commented Sep 6, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat commented Sep 7, 2023 •

edited

Loading

parasharrajat left a comment •

edited

Loading