-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix composer focusing for popups #26826
fix composer focusing for popups #26826
Conversation
@ArekChr I have attached the screen recording for web, will update the desktop also soon. But I'm wondering what should I do for mobile devices. It's not like we can type without keyboard open/we can see report or composer when RHP is opened. Please guide me on how can we proceed with the mobile devices. @MariaHCD Would need your opinion as well. Thanks. |
The issue was only reported for web, so on mobile devices just testing that the composer box works as expected should be sufficient. |
Ok, will update the screen recordings. Thanks. |
@ArekChr I have added the screen-recordings as well. Please check. Thanks. |
@mountiny merged with main & it's working fine. Not able to type on composer or wasn't able to re-produce the issue as mentioned in the slack thread. |
I have found a new issue while verifying this, which is I can paste and get composer focus even a popup is opened (ex: attachment picker) - was able re-produce in staging too. So it's a previous issue. |
Sorry for the delay. Too many issues I have been assigned to since I was at the RNEU conference. Reviewing |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemweb.chrome.movMobile Web - Safarimweb.safari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js
Outdated
Show resolved
Hide resolved
…ons.js Co-authored-by: Arkadiusz Chrabąszczewski <Arkadiuszchr@gmail.com>
Updated!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works. Looks good to me!
@MariaHCD Lets try to merge this one before next deploy 🚀 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.68-8 🚀
|
Hi! This caused this bug report - #27250 - which also happens for the right click context menu. I'm personally not sure if it's a bug / regression, I think it might end up being expected behavior, BUT it's definitely a change from what happened previously (and what happens on production). Let me know if you can think of a way to fix this that doesn't undo your change! Thanks. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.70-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
ka
Details
Fixes issues which composer getting focus when popup are closed which sets
modal.isVisible
onyx key asfalse
even though we have RHN opened.Fixed Issues
$ #23403
PROPOSAL: #23403 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Kapture.2023-09-06.at.02.21.19.mp4
Mobile Web - Chrome
Kapture.2023-09-07.at.01.14.29.mp4
Mobile Web - Safari
Kapture.2023-09-07.at.01.11.02.mp4
Desktop
Kapture.2023-09-07.at.01.04.02.mp4
iOS
Kapture.2023-09-07.at.01.12.59.mp4
Android
Kapture.2023-09-07.at.01.11.54.mp4