[HOLD for payment 2023-09-20] [$1000] Web - User can use the composer and chat while the RHP is open

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Make sure you have a workspace created.

1. Login and open any chat room.
2. Go to settings by clicking on your avatar and open the RHP.
3. Refresh the page ( IMPORTANT! ).
   ( Now we want to open any Modal, let's use the "delete workspace" modal )
4. Go to workspaces and click on a workspace.
5. Click on the 3 dots at the top right.
6. Click Delete workspce to show the modal
7. Click Cancel to close the modal
8. Now start typing while The RHP is open.

Expected Result:

User Shouldn't be able to type anything because the RHP is open, and the composer text input is not focused.

Actual Result:

Once the user start typing while the RHP is open, The composer is focused and user can use it to type and send messages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.21-07-23.08_28_24.webm

Recording.3831.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689919902028749

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a88e9c324c81b2d4
• Upwork Job ID: 1689477016355319808
• Last Price Increase: 2023-08-31
• Automatic offers:
• b4s36t4 | Contributor | 26489111
• Ahmed-Abdella | Reporter | 26489112

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Same root cause as #23184?

[kadiealexander]

Reproduced:

2023-07-25_16-44-32.mp4

[kadiealexander]

@parasharrajat as the C+ for #23184, do you think this has the same root cause?

[parasharrajat]

@kadiealexander Yes.

[kadiealexander]

Awesome thanks Rajat! I'll place this on hold for @Santhosh-Sellavel's investigation here too.

[kadiealexander]

@Santhosh-Sellavel any update?

[PauloGasparSv]

Hey @kadiealexander we discussed this issue and #16098 over at this slack thread and we decided that it is best to close #16098 and work on this issue as usual letting the CPlus/Engineer assigned here take care of the bug.

Putting this off hold and changing back to daily.

[kadiealexander]

Thanks @PauloGasparSv!!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a88e9c324c81b2d4

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[b4s36t4]

@Ahmed-Abdella I think because of update with the bot, upwork will only show 50$. I'm sure it's 250$ because this was create before the change.

[MariaHCD]

Since this bug was reported in July (and before the change on Aug 30th), I think the previous rates will apply for this issue. I'll defer to @kadiealexander, though!

[Ahmed-Abdella]

@MariaHCD then should I accept the offer or wait for @kadiealexander to change it

[MariaHCD]

I think you can wait until @kadiealexander is able to address this

[kadiealexander]

Agreed! I'll change the amounts. Sorry team, these kinds of changes are never smooth!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @b4s36t4 got assigned: 2023-09-04 13:05:19 Z
• when the PR got merged: 2023-09-12 02:55:17 UTC
• days elapsed: 5

On to the next one 🚀

[ArekChr]

I have been OOO for three days after @b4s36t4 got assigned.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix composer focusing for popups #26826

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @b4s36t4 requires payment offer (Contributor)
• @Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2023-09-20] [$1000] Web - User can use the composer and chat while the RHP is open #23403 (comment)
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [HOLD for payment 2023-09-20] [$1000] Web - User can use the composer and chat while the RHP is open #23403 (comment)
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [HOLD for payment 2023-09-20] [$1000] Web - User can use the composer and chat while the RHP is open #23403 (comment)
• [@ArekChr] Determine if we should create a regression test for this bug.
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/318381

[ArekChr]

• Link to the PR: No bug identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: I think we may have a regression test for that issue.

Regression Test Proposal

1. Login and open any chat room.
2. Go to settings by clicking on your avatar and open the RHP.
3. Go to workspaces and click on any workspace.
4. Click on the three dots at the top right.
5. Click Delete workspace to show the modal.
6. Click Cancel to close the modal.
7. Start typing while The RHP is open.
8. Ensure that the composer is still not focused and that input doesn't change.

Do we agree 👍 or 👎

[kadiealexander]

Payouts due:

• Issue Reporter: $250 @Ahmed-Abdella
• Contributor: $1000 @b4s36t4

Eligible for 50% #urgency bonus? No

Upwork job is here.

[kadiealexander]

Payments complete!

[b4s36t4]

@kadiealexander #23403 (comment) as per the comment maybe bonus applies? @ArekChr for any input if possible?

[ArekChr]

@kadiealexander I was at the RNEU conference when this proposal was approved, which caused me to postpone the review for three days

[b4s36t4]

@kadiealexander friendly bump ^^.