-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scroll when opening the currency selector page #25835
Conversation
@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Friendly ping @robertKozik |
I'll review it today 👌🏼 thanks for ping |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid.-.native.movMobile Web - SafariiOS.-.web.movDesktopdesktop.moviOSios.-.native.movAndroidandroid.-.native.mov |
Another friendly ping @robertKozik 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@robertKozik While testing I found a potential deploy blocker present on main: Screen.Recording.2023-09-11.at.16.16.21.movClosing the manual request currency selector opens the distance request tab. |
@joh42 please fill the bug report on |
@joh42 @robertKozik is this on main as well as this branch? |
I cant repro it on my side |
Turns out that the issue above was due to some problems with my local environment. After resolving those the fix here works as intended |
Thanks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
<ScreenWrapper includeSafeAreaPaddingBottom={false}> | ||
<ScreenWrapper | ||
includeSafeAreaPaddingBottom={false} | ||
onEntryTransitionEnd={() => optionsSelectorRef.current && optionsSelectorRef.current.focus()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this doesn't work for the case of when a screen is popped to reveal the selector. See this PR for an example of a reliable way to auto-focus a text input when a screen opens after the transition finishes:
const focusTimeoutRef = useRef(null);
useFocusEffect(
useCallback(() => {
focusTimeoutRef.current = setTimeout(() => optionsSelectorRef.current?.focus(), CONST.ANIMATED_TRANSITION);
return () => {
if (!focusTimeoutRef.current) {
return;
}
clearTimeout(focusTimeoutRef.current);
};
}, []);
);
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.68-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
Details
When opening the currency selector page, there used to be a scroll for some currencies (specifically VND and VUV)
Fixed Issues
$ #24336
PROPOSAL: #24336 (comment)
Tests
Offline tests
Same as regular tests
QA Steps
Same as regular tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-08-30.at.19.24.18.mov
Mobile Web - Chrome
Screen.Recording.2023-08-30.at.19.22.09.mov
Mobile Web - Safari
Screen.Recording.2023-08-30.at.19.28.11.mov
Desktop
Screen.Recording.2023-08-30.at.20.06.36.mov
iOS
Screen.Recording.2023-08-30.at.19.38.58.mov
Android
Screen.Recording.2023-08-30.at.16.47.34.mov