fix: 26075 image does not show in full view on Staging Server #26411

tienifr · 2023-08-31T15:49:44Z

Details

Fixed Issues

$ #26075
PROPOSAL: #26075 (comment)

Tests

go to Settings > Preferences
turn on Use Staging Server
go to any chat and send any image
click on that image
verify the image is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

go to Settings > Preferences
turn on Use Staging Server
go to any chat and send any image
click on that image
verify the image is shown

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-31.at.22.08.04.mp4

Mobile Web - Chrome

Screenrecorder-2023-08-31-22-25-47-40.1.mp4

Mobile Web - Safari

Screen.Recording.2023-08-31.at.22.31.42.mp4

Desktop

Screen.Recording.2023-08-31.at.22.36.22.mp4

iOS

Screen.Recording.2023-08-31.at.22.57.03.mov

Android

Screen.Recording.2023-08-31.at.22.57.03.mov

melvin-bot · 2023-08-31T15:59:21Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

tienifr · 2023-08-31T16:52:09Z

@0xmiroslav Thanks for your review. I updated the PR

0xmiros · 2023-09-01T16:56:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiros · 2023-09-01T16:56:39Z

@tienifr please fix lint

0xmiros

LGTM!

mountiny · 2023-09-01T18:57:34Z

src/components/AttachmentModal.js

-                            source={tryResolveUrlFromApiRoot(props.source)}
+                            source={props.source}


Will this actually work once deployed? Will you see pics on staging sent from production? Pics from production sent from staging?

We can safely remove tryResolveUrlFromApiRoot because we already add tryResolveUrlFromApiRoot in

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

Line 40 in 6e17b64

const source = tryResolveUrlFromApiRoot(isAttachmentOrReceipt ? htmlAttribs[CONST.ATTACHMENT_SOURCE_ATTRIBUTE] : htmlAttribs.src);

. You can check the videos above to see the result

mountiny · 2023-09-01T18:58:17Z

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js

+})(
+    memo(
+        ImageRenderer,
+        (prevProps, nextProps) =>
+            lodashGet(prevProps, 'tnode.attributes') === lodashGet(nextProps, 'tnode.attributes') &&
+            lodashGet(prevProps, 'user.shouldUseStagingServer') === lodashGet(nextProps, 'user.shouldUseStagingServer'),
+    ),
+);


Can you explain this change to me? Is this actioning as shouldComponentUpdate?

That's correct. We want to use shouldUseStagingServer from CONST.ONYX.USER, but we don't have any way to get only this property, that why I have to get the whole user object. I want to use memo with compare function here to prevent ImageRenderer component re-render unnecessarily

tienifr · 2023-09-13T03:23:06Z

@mountiny I think we can remove Hold title and continue processing this PR

mountiny · 2023-09-13T07:50:04Z

Correct, waiting for a next deploy now so the checklist is somewhat manageable

mountiny

Thanks!

OSBotify · 2023-09-13T09:27:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-14T10:53:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:11:18Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: 26075 image does not show in full view on Staging Server

539a304

tienifr marked this pull request as ready for review August 31, 2023 15:59

tienifr requested a review from a team as a code owner August 31, 2023 15:59

melvin-bot bot requested review from 0xmiros and removed request for a team August 31, 2023 15:59

tienifr mentioned this pull request Aug 31, 2023

[Awaiting C+ newdot payment] [$1000] DEV: image does not show in full view on Staging Server #26075

Closed

6 tasks

0xmiros reviewed Aug 31, 2023

View reviewed changes

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js Outdated Show resolved Hide resolved

0xmiros reviewed Aug 31, 2023

View reviewed changes

src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js Outdated Show resolved Hide resolved

fix: remove memo and withLocalize

e220b16

add memo hook

0f0b95a

fix: lint

865bf60

0xmiros approved these changes Sep 1, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny September 1, 2023 17:04

mountiny reviewed Sep 1, 2023

View reviewed changes

mountiny changed the title ~~fix: 26075 image does not show in full view on Staging Server~~ [HOLD merge freeze] fix: 26075 image does not show in full view on Staging Server Sep 1, 2023

Merge branch 'main' into fix/26075

17ed5c1

mountiny assigned tienifr Sep 13, 2023

mountiny changed the title ~~[HOLD merge freeze] fix: 26075 image does not show in full view on Staging Server~~ fix: 26075 image does not show in full view on Staging Server Sep 13, 2023

mountiny approved these changes Sep 13, 2023

View reviewed changes

mountiny merged commit 6e3ab3d into Expensify:main Sep 13, 2023
13 checks passed

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 26075 image does not show in full view on Staging Server #26411

fix: 26075 image does not show in full view on Staging Server #26411

tienifr commented Aug 31, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

tienifr commented Aug 31, 2023

0xmiros commented Sep 1, 2023

0xmiros commented Sep 1, 2023

0xmiros left a comment

mountiny Sep 1, 2023

tienifr Sep 4, 2023

mountiny Sep 1, 2023

tienifr Sep 4, 2023

mountiny Sep 13, 2023

tienifr commented Sep 13, 2023

mountiny commented Sep 13, 2023

mountiny left a comment

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

		source={tryResolveUrlFromApiRoot(props.source)}
		source={props.source}

fix: 26075 image does not show in full view on Staging Server #26411

fix: 26075 image does not show in full view on Staging Server #26411

Conversation

tienifr commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

tienifr commented Aug 31, 2023

0xmiros commented Sep 1, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros commented Sep 1, 2023

0xmiros left a comment

Choose a reason for hiding this comment

mountiny Sep 1, 2023

Choose a reason for hiding this comment

tienifr Sep 4, 2023

Choose a reason for hiding this comment

mountiny Sep 1, 2023

Choose a reason for hiding this comment

tienifr Sep 4, 2023

Choose a reason for hiding this comment

mountiny Sep 13, 2023

Choose a reason for hiding this comment

tienifr commented Sep 13, 2023

mountiny commented Sep 13, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

tienifr commented Aug 31, 2023 •

edited

Loading