#26126: Tag menu item and Tag picker (1st PR) #26954

BeeMargarida · 2023-09-07T12:38:29Z

Details

This PR includes the tag menu item in a Money Request Confirmation as well as a way of choosing another tag. The picker is still on it's simpler form, the more complex form will come in the next PR.
This is using mock data with the setup mentioned in the collapsed section below. It does not change the IOU data, this will come in another PR.

Note: I added support for this working by creating the money request from the FAB menu. Let me know if the solution implemented is correct.

Mock data

Go to a workspace page
Copy the workspace/policyID in the URL
In MoneyRequestConfirmPage add the following code to a useEffect(() => {...}, []):

Onyx.set('policyTags_<POLICY ID>', {
    Accounting: {name: 'Accounting', enabled: true},
    Engineering: {name: 'Engineering', enabled: true},
    HR: {name: 'HR', enabled: true},
    Marketing: {name: 'Marketing', enabled: true},
});
Onyx.merge('iou', {
    tag: 'Marketing',
});

Fixed Issues

$ #26126

Tests

Start a Money Request from inside a report or in the FAB button
Choose any of the selectors
Open the 'show more' section
Click on the Tag menu item
See that the tag menu picker appears and allow to select one tag

Verify that no errors appear in the JS console

Offline tests

Start a Money Request from inside a report or in the FAB button
Choose any of the selectors
Open the 'show more' section
Click on the Tag menu item
See that the tag menu picker appears and allow to select one tag

QA Steps

Start a Money Request from inside a report or in the FAB button
Choose any of the selectors
Open the 'show more' section
Click on the Tag menu item
See that the tag menu picker appears and allow to select one tag

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

webs_t.mp4

webc_t.mp4

Mobile Web - Chrome

mchrome_t.mp4

Mobile Web - Safari

msafari_t.mp4

Desktop

desktop_t.mp4

iOS

ios_t.mp4

Android

android_t.mp4

src/components/TagPicker/index.js

melvin-bot · 2023-09-07T14:22:53Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-09-08T06:53:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-11.at.02.18.13.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Screen.Recording.2023-09-11.at.03.00.27.mov

Android

Screen.Recording.2023-09-11.at.10.36.32.mov

BeeMargarida · 2023-09-08T10:06:48Z

@rushatgabhane I made a commit containing the types and a correction to the recently used tags collection. It should not cause any difference in behaviour, since this is currently using mock data. This came from a review from #26501, which I'm also covering now.

rushatgabhane · 2023-09-10T20:24:54Z

We’ll add a new user-level NVP, recentlyUsedTags, which we’ll use to store the names of the five most recently used tags, per policy, for each user

@BeeMargarida this is from the design doc. Would recently used tags be part of next PRs?

rushatgabhane

LGTM!

just left some non blocking comments

src/CONST.ts

src/components/TagPicker/tagPickerPropTypes.js

src/components/MoneyRequestConfirmationList.js

src/components/TagPicker/index.js

src/components/tagPropTypes.js

rushatgabhane

More than 8 tags
When a policy has 8 or more tags, we'll render up to three sections, as well as show the text input for search.

@BeeMargarida as per the design doc,

when we have more than 8 tags we should show search input.
If a tag name is super long, it will continue onto a second line in the same OptionRow.

Is this in scope on this PR?

BeeMargarida · 2023-09-11T08:24:34Z

We’ll add a new user-level NVP, recentlyUsedTags, which we’ll use to store the names of the five most recently used tags, per policy, for each user

@BeeMargarida this is from the design doc. Would recently used tags be part of next PRs?

Will be implemented in the next PR, since it's the one that will contain sections in the tag picker component.

@BeeMargarida as per the design doc,

1. when we have more than 8 tags we should show search input.

2. If a tag name is super long, it will continue onto a second line in the same OptionRow.

Is this in scope on this PR?

No, it will come in the next one. This one is only for the less than 8 tags. In the next one, I'll include the complete tag picker behaviour, including that super long behaviour.

BeeMargarida · 2023-09-11T08:32:47Z

@rushatgabhane Update and ready for another review

src/components/MoneyRequestConfirmationList.js

src/components/tagPropTypes.js

src/pages/iou/MoneyRequestTagPage.js

src/types/onyx/PolicyTag.ts

BeeMargarida · 2023-09-12T16:58:08Z

Updated!

amyevans · 2023-09-12T17:02:09Z

@puneetlath all you!

puneetlath

Looks good! A couple tiny comments.

src/components/MoneyRequestConfirmationList.js

src/components/TagPicker/tagPickerPropTypes.js

BeeMargarida · 2023-09-13T08:26:35Z

@puneetlath Ready for a review

puneetlath

Looks good, but more conflicts 😢

BeeMargarida · 2023-09-13T15:16:10Z

Conflicts fixed!

OSBotify · 2023-09-13T15:42:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ayazhussain79 · 2023-09-13T17:54:31Z

How can i see tags ?

OSBotify · 2023-09-14T10:52:40Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

amyevans · 2023-09-14T13:22:03Z

src/components/MoneyRequestConfirmationList.js

@@ -499,6 +520,16 @@ function MoneyRequestConfirmationList(props) {
                            disabled={didConfirm || props.isReadOnly}
                        />
                    )}
+                    {canUseTags && !!tagList && (


I just noticed this line is incorrect, we should use !_.isEmpty(tagList) instead of !!tagList. @BeeMargarida can you add that change to your next PR?

OSBotify · 2023-09-18T10:10:39Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

lukemorawski

Good job. Looks solid!

lukemorawski · 2023-09-19T15:25:52Z

src/pages/iou/MoneyRequestTagPage.js

+    // Fetches the first tag list of the policy
+    const tagListKey = _.first(_.keys(policyTags));
+    const tagList = lodashGet(policyTags, tagListKey, {});
+    const tagListName = lodashGet(tagList, 'name', '');


just a minor thing, but that way we could remove the OR operator on line 70 :)

const tagListName = lodashGet(tagList, 'name', translate('common.tag'));

Thank you, I applied this refactor in the PR I have opened!

lukemorawski · 2023-09-19T15:27:31Z

src/pages/iou/MoneyRequestTagPage.js

+            shouldEnableMaxHeight
+        >
+            <HeaderWithBackButton
+                title={tagListName || translate('common.tag')}


if the tagListName had a default of translate('common.tag') than titleparam value could be justtagListName`. See above

flodnv · 2024-03-12T15:15:19Z

src/languages/en.ts

@@ -544,6 +546,7 @@ export default {
            `changed the ${valueName} to ${newValueToDisplay} (previously ${oldValueToDisplay})`,
        threadRequestReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} request${comment ? ` for ${comment}` : ''}`,
        threadSentMoneyReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} sent${comment ? ` for ${comment}` : ''}`,
+        tagSelection: ({tagName}: TagSelectionParams) => `Select a ${tagName} to add additional organization to your money`,


I don't think this copy was checked? It does not really read like a proper English sentence. We're going to create an issue to modify it.

It's the copy that was in the mocks in the design doc, but yeah I am not sure if it was run through marketing prior to landing in the mocks (I did not run it through after, that much I know 😅). I agree it's a bit awkward wording and could be improved.

Fixed here: #38242

BeeMargarida added 7 commits September 7, 2023 11:28

feat: tag picker component

002bcf0

feat: money request tag page and tag menu item

c0e2352

feat: pass IOU tag to confirmation list

6e6ec88

feat: fetch reportID from IOU participants

412e191

feat: add missing translation

e2cf2b5

fix: small typo

7aca47c

fix: lint errors

601231f

pac-guerreiro reviewed Sep 7, 2023

View reviewed changes

src/components/TagPicker/index.js Show resolved Hide resolved

pac-guerreiro approved these changes Sep 7, 2023

View reviewed changes

BeeMargarida marked this pull request as ready for review September 7, 2023 14:22

BeeMargarida requested a review from a team as a code owner September 7, 2023 14:22

melvin-bot bot requested review from rushatgabhane and removed request for a team September 7, 2023 14:22

docs: add missing comment for recently used tags of a policy

51b6979

feat: add type and change collection key according to category

92cf2a6

refactor: rename method

68a3893

rushatgabhane approved these changes Sep 11, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans September 11, 2023 04:18

rushatgabhane suggested changes Sep 11, 2023

View reviewed changes

BeeMargarida added 2 commits September 11, 2023 09:26

fix: review improvements

b4f8adf

Merge branch 'main' into feat/26126-tag_menu_item_and_picker

1112ae6

rushatgabhane approved these changes Sep 11, 2023

View reviewed changes

BeeMargarida added 2 commits September 11, 2023 09:39

fix: small lint error

feb8020

fix: small linter fix

40bd151

amyevans reviewed Sep 12, 2023

View reviewed changes

fix: review fixes

c42584c

amyevans previously approved these changes Sep 12, 2023

View reviewed changes

puneetlath requested changes Sep 12, 2023

View reviewed changes

src/components/MoneyRequestConfirmationList.js Outdated Show resolved Hide resolved

src/components/TagPicker/tagPickerPropTypes.js Outdated Show resolved Hide resolved

BeeMargarida added 2 commits September 13, 2023 09:19

fix: small comment fix and code simplification

3f40a65

Merge branch 'main' into feat/26126-tag_menu_item_and_picker

2a0d68b

BeeMargarida dismissed amyevans’s stale review via 2a0d68b September 13, 2023 08:24

BeeMargarida added 2 commits September 13, 2023 09:25

fix: remove duplicated key from merge with main

40eabd8

fix: remove duplicated key

02d1ddd

puneetlath previously approved these changes Sep 13, 2023

View reviewed changes

Merge branch 'main' into feat/26126-tag_menu_item_and_picker

298193d

BeeMargarida dismissed puneetlath’s stale review via 298193d September 13, 2023 15:15

amyevans approved these changes Sep 13, 2023

View reviewed changes

amyevans merged commit d494433 into Expensify:main Sep 13, 2023
13 checks passed

amyevans mentioned this pull request Sep 8, 2023

[HOLD for payment 2023-10-02] [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI #26126

Closed

2 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

amyevans reviewed Sep 14, 2023

View reviewed changes

lanitochka17 mentioned this pull request Sep 14, 2023

IOU - Tapping on tag , menu picker does not appear and unable to select tag #27444

Closed

6 tasks

lukemorawski reviewed Sep 19, 2023

View reviewed changes

eh2077 mentioned this pull request Nov 3, 2023

[HOLD for payment 2023-12-04] [$500] [Wave 6: Tags] In the Tag list, two tags are highlighted at the same time #30465

Closed

6 tasks

flodnv reviewed Mar 12, 2024

View reviewed changes

flodnv mentioned this pull request Mar 13, 2024

Update tagSelection and categorySelection copies #38242

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#26126: Tag menu item and Tag picker (1st PR) #26954

#26126: Tag menu item and Tag picker (1st PR) #26954

BeeMargarida commented Sep 7, 2023 •

edited

Loading

melvin-bot bot commented Sep 7, 2023

rushatgabhane commented Sep 8, 2023 •

edited

Loading

BeeMargarida commented Sep 8, 2023

rushatgabhane commented Sep 10, 2023

rushatgabhane left a comment

rushatgabhane left a comment •

edited

Loading

BeeMargarida commented Sep 11, 2023 •

edited

Loading

BeeMargarida commented Sep 11, 2023

BeeMargarida commented Sep 12, 2023

amyevans commented Sep 12, 2023

puneetlath left a comment

BeeMargarida commented Sep 13, 2023

puneetlath left a comment

BeeMargarida commented Sep 13, 2023

OSBotify commented Sep 13, 2023

ayazhussain79 commented Sep 13, 2023

OSBotify commented Sep 14, 2023

amyevans Sep 14, 2023

BeeMargarida Sep 14, 2023

OSBotify commented Sep 18, 2023

lukemorawski left a comment

lukemorawski Sep 19, 2023

BeeMargarida Sep 19, 2023

lukemorawski Sep 19, 2023

flodnv Mar 12, 2024

amyevans Mar 12, 2024

flodnv Mar 13, 2024

#26126: Tag menu item and Tag picker (1st PR) #26954

#26126: Tag menu item and Tag picker (1st PR) #26954

Conversation

BeeMargarida commented Sep 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 7, 2023

rushatgabhane commented Sep 8, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

BeeMargarida commented Sep 8, 2023

rushatgabhane commented Sep 10, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

BeeMargarida commented Sep 11, 2023 • edited Loading

BeeMargarida commented Sep 11, 2023

BeeMargarida commented Sep 12, 2023

amyevans commented Sep 12, 2023

puneetlath left a comment

Choose a reason for hiding this comment

BeeMargarida commented Sep 13, 2023

puneetlath left a comment

Choose a reason for hiding this comment

BeeMargarida commented Sep 13, 2023

OSBotify commented Sep 13, 2023

ayazhussain79 commented Sep 13, 2023

OSBotify commented Sep 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Sep 18, 2023

lukemorawski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BeeMargarida commented Sep 7, 2023 •

edited

Loading

rushatgabhane commented Sep 8, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

BeeMargarida commented Sep 11, 2023 •

edited

Loading