[HOLD for payment 2023-09-29] [$500] Chat - Conversations do not load if you interrupt the Internet connection when logging in

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a New Expensify app
2. Log in with HT account
3. Turn off the internet for 5 seconds when the download starts
4. Turn the internet back on

Expected Result:

The app should in all situations download the entire conversation history if online

Actual Result:

If you turn off the internet when logging into your HT account and then turn it back on, the app can't load the conversation history and only loads the last active one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6193244_Recording__204.mp4

Record_Android.mp4

Production

20230908_220010.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0159e32a8761c731e6
• Upwork Job ID: 1701890298391609344
• Last Price Increase: 2023-09-13
• Automatic offers:
• tienifr | Contributor | 26751852

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[deetergp]

I'm pretty sure I was able to recreate this on production… So I'm not sure it's a DeployBlocker.

[deetergp]

I'm going to mark this as External and see what our contributors can do with it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0159e32a8761c731e6

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[nahid633]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Conversations do not load if you interrupt the Internet connection when logging in

What is the root cause of that problem?

in AuthScreen.js
line 140 there is NetworkConnection.onReconnect(() => {}) function listen for reconnect and call the function. inside that function App.reconnectApp is called. What i get from my investigation is that App.reconnectApp() and App.openApp command returns different data therefore we don't see the all convestions history.

What changes do you think we should make in order to solve the problem?

if we are solving this issue in FE. adding App.openApp(); next to App.reconnectApp() will get latest results and conversations.
line 142 App.openApp();

What alternative solutions did you explore? (Optional)

Other solution is to fix ReconnectApp api response to get same results as OpenApp().

chathistoryproblem.mp4

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Conversations do not load if you interrupt the Internet connection when logging in

What is the root cause of that problem?

After login successfully, we call API OpenApp, if users turn off the network for a long time, browser will reject this request. And because it's the read API, we don't have the logic to re-run.

Although we already we the logic to run reconnectApp API when users go online, but this API doesn't get all data like OpenApp

What changes do you think we should make in order to solve the problem?

We should create the new Onyx key named IS_LOADING_APP to indicate that OpenApp is loading or not
When calling OpenApp API, we should update it to true, and set to false in successData and failureData

In AuthScreen, subscribe IS_LOADING_APP and use this value in

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Line 129 in 2ed276b

NetworkConnection.onReconnect(() => App.reconnectApp(this.props.lastUpdateIDAppliedToClient));

        NetworkConnection.onReconnect(() => {
            isLoadingApp? App.openApp(): App.reconnectApp(this.props.lastUpdateIDAppliedToClient)
        });

Result

Screen.Recording.2023-09-13.at.18.26.33.mp4

[narefyev91]

Proposal from @tienifr looks good to me #27054 (comment)
We should separate usage of App.openApp(); and App.reconnectApp(this.props.lastUpdateIDAppliedToClient); - and not try to make them working as a one call or combine both in one
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @deetergp is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[nahid633]

Proposal from @tienifr looks good to me #27054 (comment)
We should separate usage of App.openApp(); and App.reconnectApp(this.props.lastUpdateIDAppliedToClient); - and not try to make them working as a one call or combine both in one
🎀 👀 🎀 C+ reviewed

Adding IS_LOADING_APP is good idea but there is one problem with

isLoadingApp? App.openApp(): App.reconnectApp(this.props.lastUpdateIDAppliedToClient)
});

After successfully login if there is network lost and then it is not gonna able to call APP.write so we will lose data. I would suggest to add.

App.reconnectApp(this.props.lastUpdateIDAppliedToClient) });

if(!isLoadingApp) {
App.openApp():
}

[tienifr]

@deetergp What do you think about my proposal above?

[deetergp]

Your solution looks good @tienifr, thanks!

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

🎯 ⚡️ Woah @narefyev91 / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-09-19 09:42:17 Z
• when the PR got merged: 2023-09-20 07:29:09 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 27054 Conversations do not load if you interrupt the Internet connection when logging in #27380

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@deetergp, @narefyev91, @bfitzexpensify, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[deetergp]

Are we still holding on this?

[bfitzexpensify]

Payment complete to @tienifr.

No payment required to @narefyev91.

Think we're now good to close this out.