[HOLD for payment 2023-10-10] [$500] Chat - Status emoji is not fully visible in conversation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-condition: Set a status emoji and message

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Note status emoji in any sent message or send a message and note

Expected Result:

The status emoji must be displayed fully in the conversation page

Actual Result:

The status emoji is only half visible in conversation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6196165_o.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a2a729000f5e1f1f
• Upwork Job ID: 1702434843606450176
• Last Price Increase: 2023-09-21
• Automatic offers:
• tienifr | Contributor | 26921541

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jscardona12]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Status emoji is not fully visible in conversation page

What is the root cause of that problem?

The root cause is because the emoji status lacks of a min height so when the page get smaller, the meesage date gets relevance and "overlaps" the emoji

What changes do you think we should make in order to solve the problem?

In

App/src/styles/styles.js

Lines 3918 to 3922 in 1ae51cc

	userReportStatusEmoji: {
	fontSize: variables.fontSizeNormal,
	marginRight: 4,
	},
	draggableTopBar: {

we should add the style minHeight: variables.fontSizeNormalto match the default size of the emoji in case of this value changes.

Solution Working.

Screen.Recording.2023-09-11.at.10.05.34.AM.mp4

What alternative solutions did you explore? (Optional)

[strepanier03]

I'm not able to reproduce this any longer on 1.368-15, can anyone confirm if they can still repro?

[jscardona12]

Hi @strepanier03, still reproducible on latest main.

[strepanier03]

All right, I'll move it forward, thank you @jscardona12 for testing again

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a2a729000f5e1f1f

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status emoji is clipped in report.

What is the root cause of that problem?

The message date may overlap with this emoji when screen gets smaller. Since both the message date and message sender specifies the flexShrink behavior while status emoji does not thus the page will automatically distribute content base on that.

What changes do you think we should make in order to solve the problem?

Add flexShrink: 0 to styles.userReportStatusEmoji just like we did with ReportActionItemDate.

App/src/styles/styles.js

Lines 3965 to 3968 in cd9e86e

	userReportStatusEmoji: {
	fontSize: variables.fontSizeNormal,
	marginRight: 4,
	},

App/src/styles/styles.js

Lines 1642 to 1647 in c36ac0c

	chatItemMessageHeaderTimestamp: {
	flexShrink: 0,
	color: theme.textSupporting,
	fontSize: variables.fontSizeSmall,
	paddingTop: 2,
	},

Note: The minWidth solution does not address this issue on real mobile browsers and with different emojis (i.e., still clipped), since it is set with a fixed width. We should let the content dynamically adjusts.

Results

Safari

Chrome

[melvin-bot]

@strepanier03, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

@parasharrajat - Friendly bump on the proposals, thank you!

[parasharrajat]

Will be checking tomorrow.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[strepanier03]

Thank you @mvtglobally.

[tienifr]

Still reproducible. Notice that the participant's name should be long enough to be overflown:

cc @mvtglobally @strepanier03

[tienifr]

PR is up #28392.

[melvin-bot]

🎯 ⚡️ Woah @parasharrajat / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-09-28 10:03:32 Z
• when the PR got merged: 2023-09-29 07:08:59 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Status emoji is overlap in report action item #28392

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - N/A internal report
• Contributor that fixed the issue - @tienifr - $500 + $250 (speed bonus) = $750 via Upwork
• Contributor+ that helped on the issue and/or PR - @parasharrajat - $500 + $250 (speed bonus) = $750 via MR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Display status in chats #24526
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Display status in chats #24526 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This was missed from testing. Regression steps are enough to capture this.
• [@parasharrajat] Determine if we should create a regression test for this bug. = Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/326590

[strepanier03]

Sorry for the hold-up here everyone, I've been pretty slammed but I'm working on this now. Thanks for your patience 🙌

[strepanier03]

@tienifr - I've finished paying via UPwork and closed the contract. Thank you again!

---

@parasharrajat - Feel free to update me with the checklist stuff when you can and then submit a manual request for payment. I updated this payment comment with the amount. Thank you as well!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Display status in chats #24526
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Display status in chats #24526 (comment)
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required. This was missed from testing. Regression steps are enough to capture this.
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Log in with any account
2. Go to Settings >> Profile >> Display name, change the display name to be very long
3. Go to Setting >> Profile >> Status, set an emoji status 💨
4. Go to any chat
5. Send a message
6. Verify that the status emoji does not overlap or cropped.

Do you agree 👍 or 👎 ?

[melvin-bot]

@strepanier03, @parasharrajat, @stitesExpensify, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

QA is done and checklist updated. We're all set here.

---

@parasharrajat - I'm assigning Jason to this, if you haven't already please submit for manual payment based on this payment summary.

[parasharrajat]

Payment requested as per #27149 (comment)

[JmillsExpensify]

$750 payment approved for @parasharrajat based on this comment.